Aaron Patterson
91930dc30b
reduce the number of times current_connection_id is called in with_connection()
2010-08-06 16:38:53 -07:00
Aaron Patterson
001a574785
test to ensure that respond_to? delegates to arel
2010-08-06 15:23:11 -07:00
Aaron Patterson
a897a1f4a3
sorry AR, my privates are none of your business
2010-08-06 14:52:33 -07:00
Aaron Patterson
8fb0c9f509
do not rely on arel class structure
2010-08-06 11:31:32 -07:00
Aaron Patterson
0a86cb5972
fixing whitespace errors
2010-08-05 08:15:07 -07:00
Aaron Patterson
05a49c7718
avoid passing lists of lists to the group clause
2010-08-04 16:24:29 -07:00
Xavier Noria
902d732617
Merge remote branch 'docrails/master' into 3-0-stable
2010-08-05 01:15:08 +02:00
Xavier Noria
d191db76e0
standarizes the use of the article "an" for "SQL" and "SQLite"
2010-08-05 01:09:09 +02:00
Aaron Patterson
ba9602b9e7
call to_a since we are not passing anything to all()
2010-08-04 14:22:20 -07:00
Aaron Patterson
906ef233e4
fisting indentation
2010-08-04 14:11:20 -07:00
Aaron Patterson
f316a851dd
do not pass AR objects to ARel
2010-08-04 08:44:35 -07:00
wycats
2498cdaf14
I'm unsure how cloning was working in Rails 3 before
2010-08-04 04:05:28 -07:00
Aaron Patterson
9269e55b1f
avoid passing AR::Base objects to Arel when we can
2010-08-03 17:57:59 -07:00
RainerBlessing
8b7219b9d6
query value is converted to_s instead of to_yaml
2010-08-03 14:55:15 -07:00
wycats
7a1bba4799
Allow :name to be a Symbol (was this removed by accident?)
2010-08-03 12:22:10 -07:00
Neeraj Singh
db1c484c55
Dynamic finder method like scoped_by_* create methods so that
...
method_missing is not hit next time. Adding a test for this
scenario.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:46:09 +02:00
Neeraj Singh
807239f5a1
Making Active Record base_test.rb thinner by moving tests
...
to relevant files.
Number of assertions before refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors
Number of assertions after refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:45:54 +02:00
Neeraj Singh
74f7e172c7
fixing documentation
2010-08-03 04:14:14 -04:00
Xavier Noria
4dc2521028
Merge remote branch 'docrails/master' into 3-0-stable
2010-08-03 02:15:12 +02:00
Neeraj Singh
db0e3e5ad1
Correcting the documentation which wrongly states that each dynamic finder creates
...
method on the class. Only dynamic finders using <tt>scoped_by_*</tt> creates new
methods.
2010-08-02 13:10:32 -04:00
Neeraj Singh
d3eacf9352
Adding to AR::Base documentation about dynamically scopeded_by query
...
User.scoped_by_user_name('David')
2010-08-02 13:07:18 -04:00
Neeraj Singh
1ce40ca562
ensuring that description does not exceed 100 columns
2010-08-02 12:25:26 -04:00
José Valim
9effe3cc18
Remove duplicated logic.
2010-08-02 17:20:17 +02:00
Neeraj Singh
009aa8825b
Eager loading an association should not change the count of children
...
[#4971 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-02 17:12:59 +02:00
Neeraj Singh
b8d9d9ce0a
updating documentation to ensure line does not exceed 100 columns
2010-08-02 11:09:31 -04:00
José Valim
e1344bf504
Tidy up previous commit.
2010-08-02 16:51:08 +02:00
Robert Pankowecki
f8b53f35b9
test and fix collection_singular_ids= with string primary keys [ #5125 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-02 16:41:20 +02:00
José Valim
b613c3cc7b
Add an internal (private API) after_touch callback. [ #5271 state:resolved]
2010-08-02 16:16:46 +02:00
Jakub Kuźma
311ea94f73
added failing touch propagation test
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-02 15:56:49 +02:00
Neeraj Singh
b29c23a618
ensuring that documentation does not exceed 100 columns
2010-08-01 21:32:36 -04:00
Neeraj Singh
6ac9482905
ensuring that documentation does not exceed 100 columns
2010-07-31 07:12:29 -04:00
Neeraj Singh
69b401220c
adding the missing closing tag
2010-07-31 07:04:08 -04:00
Neeraj Singh
4f63294b0f
fixing documentation just a little bit
2010-07-31 06:55:33 -04:00
Xavier Noria
3d7099891f
Merge remote branch 'rails/master'
2010-07-31 11:55:24 +02:00
Aaron Patterson
834e304b22
reverting where() functionality, adding a test
2010-07-30 14:12:01 -07:00
Aaron Patterson
ecfb252e7a
fewer method calls, using faster methods when possible
2010-07-30 14:05:26 -07:00
Aaron Patterson
d1c53a9ad2
reducing function calls and using faster methods for testing
2010-07-30 13:38:09 -07:00
Neeraj Singh
0e20e3ebc2
returns not returned . fixing documentation for reflection
2010-07-30 14:43:43 -04:00
Tarmo Tänav
2ea922bcec
Don't increment and then decrement the same counter when re-assigning a belongs_to association
...
[#2786 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-07-29 22:37:20 -03:00
Xavier Noria
ccd45618ed
Merge remote branch 'rails/master'
2010-07-30 02:35:24 +02:00
Xavier Noria
755af49755
edit pass to apply API guideline wrt the use of "# =>" in example code
2010-07-30 02:30:04 +02:00
Aaron Patterson
a7a6a2ff46
got the ternary backwards. somehow the sqlite tests passed!
2010-07-29 16:08:30 -07:00
Aaron Patterson
f171bc64a2
PERF: avoiding splat args and reducing function calls
2010-07-29 14:55:57 -07:00
Neeraj Singh
e42945333b
moving time zone related documentation to timestamp.rb from base.rb
2010-07-29 10:37:38 -04:00
Neeraj Singh
873c5a9e59
adding documentation regarding time_zone_aware_attributes and skip_time_zone_conversion_for_attributes
2010-07-29 10:29:33 -04:00
José Valim
0f0bdaea7b
Revert "Avoid uneeded queries in session stores if sid is not given."
...
First step to merge Rails and Rack session stores. Rack always expects to receive the SID since it may have different behavior if the SID is nil.
This reverts commit e210895ba9
2010-07-29 09:10:01 +02:00
Aaron Patterson
d69949ed0d
Shouldn't have committed this! Revert "avoid calling to_sql twice"
...
This reverts commit 1c030a3c3c
2010-07-28 17:03:52 -07:00
Aaron Patterson
1c030a3c3c
avoid calling to_sql twice
2010-07-28 17:01:32 -07:00
Simon Tokumine
f46e841f72
removed ambiguity from autosave description
2010-07-28 14:56:05 -07:00
Neeraj Singh
31f8a0cd23
adding punctuations
2010-07-28 13:10:04 -04:00
