github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-17 09:32:18 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,918 Commits 34 Branches 105 Tags
7c042e09b43fa64492a54350aad691f6763809d8
Commit Graph

182 Commits

Author SHA1 Message Date
David Heinemeier Hansson
ebb7bd7835 Added easy assignment of fragment cache store through use of symbols for included stores (old way still works too) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-13 08:31:32 +00:00
Nicholas Seckar
27962ead03 Add ability to specify Route Regexps for controllers. Closes #1917. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 13:56:43 +00:00
Nicholas Seckar
9e5d64b3bb Provide Named Route's hash methods as helper methods. Closes #1744. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 13:45:55 +00:00
David Heinemeier Hansson
3cf7a0a460 Added Kernel#silence_warnings and puts it into use throughout the framework 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2179 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 04:58:27 +00:00
David Heinemeier Hansson
e3c02d8c66 Fixed that render :partial would fail when :object was a Hash (due to backwards compatibility issues) #2148 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:27:44 +00:00
Nicholas Seckar
3108764367 Fix overwrite params. Closes #1909 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 22:06:11 +00:00
Jamis Buck
6c44d35268 AbstractRequest#domain returns nil when host is an ip address #2012 [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 09:10:31 +00:00
Jamis Buck
e758c2e9db Yield @content_for_ variables to templates #2058 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-01 21:51:27 +00:00
Jamis Buck
01af965a3e Make rendering an empty partial collection behave like :nothing => true #2080 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2093 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-01 21:43:38 +00:00
Nicholas Seckar
68c90ab019 Render refactoring; render error reporting fixes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-26 22:37:36 +00:00
Jamis Buck
211617191e Prevent the benchmark module from blowing up if a non-HTTP/1.1 request is processed 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-23 09:43:36 +00:00
Jamis Buck
c031a01633 Add an :if option to session management, to allow programmatically enabling or disabling the session 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-17 21:05:31 +00:00
Jamis Buck
50e2474433 Make assert_redirected_to properly check URL's passed as strings #1910 [Scott Barron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-06 08:37:25 +00:00
Jamis Buck
a3469cadad Make sure :layout => false is always used when rendering inside a layout 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-05 20:51:03 +00:00
Jamis Buck
44c64a612d Use raise instead of assert_not_nil in Test::Unit::TestCase#process to ensure that the test variables (controller, request, response) have been set 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-01 21:28:17 +00:00
Jamis Buck
08ebab5d20 Make sure assigns are built for every request when testing #1866 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-31 12:16:21 +00:00
Jamis Buck
020ed6fa1f Allow remote_addr to be queried on TestRequest #1668 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-31 10:31:47 +00:00
David Heinemeier Hansson
3d2f0001ea Fixed bug when a partial render was passing a local with the same name as the partial 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 12:24:14 +00:00
David Heinemeier Hansson
d9033bbb28 Demonstrate breakage better 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 12:06:19 +00:00
David Heinemeier Hansson
e95dd53a5d Added two failing tests for partials with locals from controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 09:11:00 +00:00
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
1ae0a53d86 Fixed regression for content_for #1820 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 13:20:29 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985 Added test for template to layout variable transfer 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 08:43:01 +00:00
Jamis Buck
d76439239d Add unit test to ensure that session management options are inherited and overridable in subclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 10:56:53 +00:00
Jamis Buck
06843f8794 Added support for per-action session management #1763 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 10:37:09 +00:00
David Heinemeier Hansson
bd558ef98e Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-21 07:14:35 +00:00
Nicholas Seckar
741316dc71 Fixed construction of get parameters for arrays 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-18 03:12:45 +00:00
Nicholas Seckar
c0771fe7d8 Fix assert_routing with nested controllers. Closes #1582 and #1386. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-15 15:00:39 +00:00
Nicholas Seckar
bf0b7588ee Add RouteSet#named_route so that RouteSet instance methods do not shadow available route names 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1834 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 10:32:37 +00:00
Nicholas Seckar
6ed16ff602 Provide correct defaults for Named Routes which do not specify :action 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 09:09:39 +00:00
David Heinemeier Hansson
16595c93b2 Made pagination faster #1334 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 08:02:01 +00:00
David Heinemeier Hansson
807df4fcf0 Made test_rendering_nothing_on_layout acknowledge the space 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 07:19:26 +00:00
Nicholas Seckar
2bd4ff11f8 Generate URLs for :action => index when :action => nil is supplied. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 00:13:06 +00:00
Nicholas Seckar
9314793239 Named routes should not provide nil values to url_for. Includes factoring and extra testcases. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-13 23:13:15 +00:00
Jamis Buck
847f738cfd Make Request#subdomains handle "foo.foo.com" correctly 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-12 16:16:13 +00:00
Jeremy Kemper
c697be5b69 r2992@asus: jeremy | 2005-07-10 02:43:49 -0700 
Skip ActiveRecordStore tests if neither SQLite 2 nor 3 is available.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-10 05:05:06 +00:00
Jamis Buck
8266867881 Improved error message for DoubleRenderError 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-09 15:31:06 +00:00
Jeremy Kemper
34df31455a r2948@asus: jeremy | 2005-07-08 16:00:23 -0700 
Use save instead of save! in ARStore test also.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-08 18:13:07 +00:00
Nicholas Seckar
c18961f185 Routes now raise an exception if a path component is misconfigured. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-08 08:56:24 +00:00
Nicholas Seckar
4a3ec21b62 Fix routes to generate proper URLs when given Fixnum defaults 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-08 08:45:51 +00:00
Nicholas Seckar
f4bfacb24f Enable routes to recognize uppercase controller names. Closes #1635 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 19:51:20 +00:00
Nicholas Seckar
5727dc2f42 Properly unescape recognized path components. Fixes #1651. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 19:43:03 +00:00
Nicholas Seckar
e3af27c51b Improved testing of functional test setup. 
Fixed functional test setup so that :controller and :action
are stored into path_parameters using string keys.

Added with_routing test helper which can be used to dynamically
replace the current set of routes inside a unit test.



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 19:23:35 +00:00
David Heinemeier Hansson
75157bbf64 Fixed that named routes didn't use the default values for action and possible other parameters #1534 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 14:16:05 +00:00
Jeremy Kemper
afbf54bc3d Add test for dynamic dispatch based on action_name accessor. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 13:45:31 +00:00
David Heinemeier Hansson
212cc3845a Fixed routing snafu 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 10:45:14 +00:00
David Heinemeier Hansson
93ec99c246 Partly tuned docs for release (AP) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 08:27:11 +00:00
Jeremy Kemper
063956b93c r2879@asus: jeremy | 2005-07-05 16:15:16 -0700 
Rollback changesets for Ticket #1229.
 r2880@asus:  jeremy | 2005-07-05 16:17:08 -0700
 Ticket #1229 does not affect Ticket #1614.  Reinstating the changesets.
 r2881@asus:  jeremy | 2005-07-05 16:24:04 -0700
 @test_unchanged in deprecated render test :partials_list action


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 18:31:51 +00:00
Jeremy Kemper
8a2fec8d31 r2874@asus: jeremy | 2005-07-05 16:13:39 -0700 
Unit test for Ticket #1614.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 18:21:26 +00:00