github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 08:48:06 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,585 Commits 34 Branches 105 Tags
816d67b104f9ea59cd0ffaccbcc250b66b7905d0
Commit Graph

760 Commits

Author SHA1 Message Date
Jamis Buck
816d67b104 Make sure passed routing options are not mutated by routing code. (closes #5314) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4444 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-07 16:27:14 +00:00
Jamis Buck
ae7029ddd1 Do some path normalization to prevent the possible_controllers list from containing invalid entries 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-07 16:16:37 +00:00
Jamis Buck
4e3543b467 Make sure named routes are never generated relative to some containing module 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-06 19:09:56 +00:00
Jamis Buck
e768dc694d Improve parameter expiry handling to fix sticky-id issue. Add a more informative Route#to_s method. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-06 17:59:54 +00:00
Jamis Buck
5ced402393 Remove dependency on Pathname in new routes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4439 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 16:01:50 +00:00
Jamis Buck
6c04eb2115 Make sure changing the controller from foo/bar to bing/bang does not change relative to foo. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 15:48:29 +00:00
Jamis Buck
149f5cad85 Escape the entire path before trying to recognize it (closes #3671) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 15:30:09 +00:00
Jamis Buck
2ffc84d23f Make sure :id and friends are properly unescaped (closes #5275). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 14:51:27 +00:00
Jamis Buck
332fcfaf6b Make sure regexp chunks are grouped when the segment has a regexp constraint so that captures are counted correctly (closes #5267) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 14:31:38 +00:00
Jamis Buck
7d88146e9e Fix documentation for with_routing to reflect new reality (closes #5281) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 14:14:32 +00:00
Jeremy Kemper
8cdf9126d3 Rewind readable CGI params so others may reread them (such as CGI::Session when passing the session id in a multipart form). Closes #210. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 06:30:23 +00:00
David Heinemeier Hansson
6dea52c54e Finish custom handling [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:38:28 +00:00
David Heinemeier Hansson
180edf4146 Make new mime types first class [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:30:43 +00:00
David Heinemeier Hansson
5e998d1ea0 Make new mime types first class [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:29:34 +00:00
David Heinemeier Hansson
5240d7a84b Added Mime::TEXT (text/plain) and Mime::ICS (text/calendar) as new default types [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:16:03 +00:00
David Heinemeier Hansson
984aa7eeb9 Added Mime::Type.register(string, symbol, synonyms = []) for adding new custom mime types [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:11:56 +00:00
David Heinemeier Hansson
5c30352328 Added support for Mime objects in render :content_type option [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 03:39:56 +00:00
Jeremy Kemper
ace2a66f0c Excise the headache-prone syswrite in send_file. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 03:34:38 +00:00
Jeremy Kemper
ac66cf1289 Add :status option to send_data and send_file. Defaults to '200 OK'. Closes #5243. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 00:51:56 +00:00
David Heinemeier Hansson
9e7e89a561 Dont keep nothing as a lookup [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 23:23:24 +00:00
Jamis Buck
ef5317f74f Tweaks to integration tests and url rewriter for further compatibility with new routes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 16:20:26 +00:00
Jamis Buck
ba4d4ad4a8 Add RouteSet::Mapper#named_route for compatibility with adding programmatically named routes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 16:00:15 +00:00
Jamis Buck
b20c575ac0 New routes implementation. Simpler, faster, easier to understand. The published API for config/routes.rb is unchanged, but nearly everything else is different, so expect breakage in plugins and libs that try to fiddle with routes. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 15:42:08 +00:00
Jeremy Kemper
ce99c87551 Cope with missing content type and length headers. Parse parameters from multipart and urlencoded request bodies only. Accept multipart PUT parameters. Closes #5235. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 00:01:48 +00:00
David Heinemeier Hansson
f9cd92f4ee Added interrogation of params[:format] to determine Accept type. If :format is specified and matches a declared extension, like "rss" or "xml", that mime type will be put in front of the accept handler. This means you can link to the same action from different extensions and use that fact to determine output [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4384 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-31 18:52:24 +00:00
David Heinemeier Hansson
bf1b06e90a Easy way to set accepting for functional tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-31 04:49:18 +00:00
David Heinemeier Hansson
4a98cbe2dd If not passing a hash, assume :id => whatever 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4381 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-31 04:48:46 +00:00
Jeremy Kemper
6ce3bf70a2 follow_redirect doesn't complain about being redirected to the same controller. Closes #5153. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-22 22:59:56 +00:00
Jeremy Kemper
0cd883e1e1 Change the request.env example in AC::Base docs to a var that exists (REMOTE_IP doesn't) and isn't already wrapped by a request method (i.e. request.remote_ip). Closes #5113. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-17 19:52:06 +00:00
Marcel Molina
7252666b74 Add layout attribute to response object with the name of the layout that was rendered, or nil if none rendered. [Kevin Clark kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-17 07:25:36 +00:00
Michael Koziarski
ff96498848 performance enhancement for previous patch [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4344 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-16 21:09:41 +00:00
Michael Koziarski
d153525c53 Fix NoMethodError when parsing params like &&. [Adam Greenfield]. Closes #4955 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-16 20:56:41 +00:00
Marcel Molina
6ef5b747b3 Fix flip flopped logic in docs for url_for's :only_path option. Closes #4998. [esad@esse.at] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4341 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-14 19:03:14 +00:00
Rick Olson
04ef7f4be6 Small fix in routing to allow dynamic routes (broken after [4242]) [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-30 21:06:49 +00:00
Rick Olson
59bd6586c8 Add Integration Session methods for PUT and DELETE requests [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-30 20:17:06 +00:00
Marcel Molina
9f92dd3984 Replace alias method chaining with Module#alias_method_chain. [Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4312 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-29 20:20:22 +00:00
Marcel Molina
6186490962 Replace Ruby's deprecated append_features in favor of included. [Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4310 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-29 18:10:14 +00:00
Marcel Molina
869c41d8d6 Revert unintential change to filter parameters 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4308 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-29 17:47:10 +00:00
Marcel Molina
0049bd729f Update README 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-29 16:34:23 +00:00
Marcel Molina
c745f47804 Use #flush between switching from #write to #syswrite. Closes #4907. [Blair Zajac <blair@orcaware.com>] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4306 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-29 05:06:49 +00:00
Marcel Molina
f3ce39749c Documentation fix: integration test scripts don't require integration_test. Closes #4914. [Frederick Ros <sl33p3r@free.fr>] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4292 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-27 22:51:39 +00:00
Marcel Molina
dd5397a57c ActionController::Base Summary documentation rewrite. Closes #4900. [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4290 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-27 18:22:20 +00:00
Marcel Molina
8ee378f3c4 Enhance documentation for setting headers in integration tests. Skip auto HTTP prepending when its already there. Closes #4079. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4286 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-26 22:13:31 +00:00
Marcel Molina
cbded64014 Documentation for AbstractRequest. Closes #4895. [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4277 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-26 18:35:53 +00:00
Marcel Molina
09095c7204 Remove all remaining references to @params in the documentation. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-25 17:42:48 +00:00
Marcel Molina
21142201c9 Add documentation for redirect_to :back's RedirectBackError exception. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-25 06:32:07 +00:00
Marcel Molina
7bb20659c2 Update layout and content_for documentation to use yield rather than magic @content_for instance variables. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-25 04:03:51 +00:00
Rick Olson
51cd1aec00 Fix assert_redirected_to tests according to real-world usage. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-25 03:54:46 +00:00
Rick Olson
e1c7b5a7f6 Cache CgiRequest#request_parameters so that multiple calls don't re-parse multipart data. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-23 18:18:17 +00:00
Rick Olson
3900b36896 Diff compared routing options. Allow #assert_recognizes to take a second arg as a hash to specify optional request method [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-23 18:16:51 +00:00