github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 08:48:06 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,585 Commits 34 Branches 105 Tags
816d67b104f9ea59cd0ffaccbcc250b66b7905d0
Commit Graph

510 Commits

Author SHA1 Message Date
Jamis Buck
816d67b104 Make sure passed routing options are not mutated by routing code. (closes #5314) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4444 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-07 16:27:14 +00:00
Jamis Buck
ae7029ddd1 Do some path normalization to prevent the possible_controllers list from containing invalid entries 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-07 16:16:37 +00:00
Jamis Buck
4e3543b467 Make sure named routes are never generated relative to some containing module 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-06 19:09:56 +00:00
Jamis Buck
e768dc694d Improve parameter expiry handling to fix sticky-id issue. Add a more informative Route#to_s method. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-06 17:59:54 +00:00
Jamis Buck
6c04eb2115 Make sure changing the controller from foo/bar to bing/bang does not change relative to foo. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 15:48:29 +00:00
Jamis Buck
149f5cad85 Escape the entire path before trying to recognize it (closes #3671) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 15:30:09 +00:00
Jamis Buck
2ffc84d23f Make sure :id and friends are properly unescaped (closes #5275). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 14:51:27 +00:00
Jamis Buck
332fcfaf6b Make sure regexp chunks are grouped when the segment has a regexp constraint so that captures are counted correctly (closes #5267) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 14:31:38 +00:00
Jeremy Kemper
8cdf9126d3 Rewind readable CGI params so others may reread them (such as CGI::Session when passing the session id in a multipart form). Closes #210. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 06:30:23 +00:00
David Heinemeier Hansson
6dea52c54e Finish custom handling [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:38:28 +00:00
David Heinemeier Hansson
5e998d1ea0 Make new mime types first class [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:29:34 +00:00
David Heinemeier Hansson
984aa7eeb9 Added Mime::Type.register(string, symbol, synonyms = []) for adding new custom mime types [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:11:56 +00:00
David Heinemeier Hansson
5c30352328 Added support for Mime objects in render :content_type option [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 03:39:56 +00:00
Jeremy Kemper
ac66cf1289 Add :status option to send_data and send_file. Defaults to '200 OK'. Closes #5243. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 00:51:56 +00:00
David Heinemeier Hansson
9e7e89a561 Dont keep nothing as a lookup [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 23:23:24 +00:00
Jamis Buck
b20c575ac0 New routes implementation. Simpler, faster, easier to understand. The published API for config/routes.rb is unchanged, but nearly everything else is different, so expect breakage in plugins and libs that try to fiddle with routes. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 15:42:08 +00:00
Jeremy Kemper
ce99c87551 Cope with missing content type and length headers. Parse parameters from multipart and urlencoded request bodies only. Accept multipart PUT parameters. Closes #5235. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 00:01:48 +00:00
David Heinemeier Hansson
f9cd92f4ee Added interrogation of params[:format] to determine Accept type. If :format is specified and matches a declared extension, like "rss" or "xml", that mime type will be put in front of the accept handler. This means you can link to the same action from different extensions and use that fact to determine output [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4384 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-31 18:52:24 +00:00
David Heinemeier Hansson
140a998de3 Added :method handling for other verbs to remote_form_tag and remote_form_for [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-28 23:39:37 +00:00
David Heinemeier Hansson
062845b4da Expanded :method option in FormHelper#form_tag to allow for verbs other than GET and POST by automatically creating a hidden form field named _method, which will simulate the other verbs over post [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-28 01:04:27 +00:00
David Heinemeier Hansson
0b1d6fd9c8 Added :method option to UrlHelper#link_to, which allows for using other verbs than GET for the link. This replaces the :post option, which is now deprecated. Example: link_to "Destroy", person_url(:id => person), :method => :delete [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4370 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-28 00:33:53 +00:00
Jeremy Kemper
6ce3bf70a2 follow_redirect doesn't complain about being redirected to the same controller. Closes #5153. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-22 22:59:56 +00:00
Marcel Molina
7252666b74 Add layout attribute to response object with the name of the layout that was rendered, or nil if none rendered. [Kevin Clark kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-17 07:25:36 +00:00
Michael Koziarski
d153525c53 Fix NoMethodError when parsing params like &&. [Adam Greenfield]. Closes #4955 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-16 20:56:41 +00:00
Jeremy Kemper
c069f361f0 form.text_area handles the :size option just like the original text_area (:size => '60x10' becomes cols="60" rows="10") 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-11 16:36:59 +00:00
Jeremy Kemper
5a960d2568 Excise ingrown code from FormOptionsHelper#options_for_select. Closes #5008. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-09 05:19:32 +00:00
Rick Olson
04ef7f4be6 Small fix in routing to allow dynamic routes (broken after [4242]) [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-30 21:06:49 +00:00
Marcel Molina
43ee8ab6e2 Allow error_messages_for to report errors for multiple objects, as well as support for customizing the name of the object in the error summary header. Closes #4186. [andrew@redlinesoftware.com, Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-26 23:09:08 +00:00
Rick Olson
51cd1aec00 Fix assert_redirected_to tests according to real-world usage. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-25 03:54:46 +00:00
Rick Olson
526c69b49e Diff compared options with #assert_redirected_to [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-22 15:08:25 +00:00
Jamis Buck
e75d27f405 restore some commented lines 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-21 20:15:53 +00:00
Jamis Buck
0a0b5bd722 fix to ';' interpretation in route recognition--only follow a route with ';' if the segment in question actually contains a ';' 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-21 17:21:26 +00:00
Jamis Buck
1f80f540a7 Add support in routes for semicolon delimited "subpaths", like /books/:id;:action 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-21 15:17:02 +00:00
Sam Stephenson
9d8e34808f Change link_to_function and button_to_function to (optionally) take an update_page block instead of a JavaScript string. Closes #4804. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-19 18:08:15 +00:00
Sam Stephenson
23585d721d Added :add_headers option to verify which merges a hash of name/value pairs into the response's headers hash if the prerequisites cannot be satisfied 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-08 07:04:21 +00:00
David Heinemeier Hansson
47b74e6e16 Added ActionController.filter_parameter_logging that makes it easy to remove passwords, credit card numbers, and other sensitive information from being logged when a request is handled #1897 [jeremye@bsa.ca.gov] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-07 22:26:25 +00:00
David Heinemeier Hansson
42d8548e94 Failed test for Marcel to ponder 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-06 03:51:52 +00:00
Marcel Molina
4859b6c09e Honor skipping filters conditionally for only certain actions even when the parent class sets that filter to conditionally be executed only for the same actions. Closes #4522. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-05 04:39:59 +00:00
Thomas Fuchs
1fcc60895b Add additional autocompleter options [aballai, Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-02 14:04:03 +00:00
David Heinemeier Hansson
2cc9b21c07 Skip complete URLs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4099 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-29 21:11:44 +00:00
David Heinemeier Hansson
91383e0426 Added automated timestamping to AssetTagHelper methods for stylesheets, javascripts, and images when Action Controller is run under Rails [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-29 20:57:53 +00:00
David Heinemeier Hansson
31199a9e4a Update description 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-28 01:11:09 +00:00
David Heinemeier Hansson
0c07e08d60 ActionView: Allow to register a Template handler with a Symbol (dont kill markaby) (closes #4328) [murphy@cYcnus.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4056 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 21:50:22 +00:00
Rick Olson
666537572d finish form_for change, allow hash as the second param: form_for :post, :url => { }. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4051 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 20:21:27 +00:00
Rick Olson
4238666627 Change #form_for and #fields_for so that the second argument is not required [Dave Thomas] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4047 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 19:45:56 +00:00
Nicholas Seckar
c05c22a45f Fix double url escaping of remote_function. Add :escape => false option to ActionView's url_for. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4014 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-22 19:41:39 +00:00
David Heinemeier Hansson
f46eb2ab64 Fix test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-22 19:28:46 +00:00
Jamis Buck
b0189f3f2f Fix assert_redirected_to so it works with symbols 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-20 18:16:48 +00:00
Rick Olson
f49ba114db Add :script option to in_place_editor to support evalScripts (closes #4194) [codyfauser@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3985 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 19:40:11 +00:00
Rick Olson
a6cfb4e0e4 Fix mixed case enumerable methods in the JavaScript Collection Proxy (closes #4314) [codyfauser@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 19:38:38 +00:00