github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
24,636 Commits 34 Branches 105 Tags
87152f2604e73b218df90befda576f0acfed0bbf
Commit Graph

6161 Commits

Author SHA1 Message Date
Jon Leighton
6c5f67cac1 Don't refer to ActionController::Base in the wrap_parameters initializer - use config object instead. Cuts about 15% off the load time. (#734) 2011-08-16 00:59:59 +01:00
Santiago Pastorino
4ca605b71b rake assets:precompile executes in production environment as default if RAILS_ENV was not provided 2011-08-15 15:31:47 -03:00
José Valim
652ab436db Ensure changing RAILS_GROUPS will load the proper dependencies. 2011-08-14 10:52:46 -07:00
Franck Verrot
75dd33a0ae Methods like status and location are interfering with redirect_to [Closes #2511] 2011-08-14 19:00:30 +02:00
Xavier Noria
bf2b9d2de3 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	RELEASING_RAILS.rdoc
	actionpack/lib/sprockets/railtie.rb
	actionpack/test/template/sprockets_helper_test.rb
	activerecord/test/cases/calculations_test.rb
	railties/guides/source/3_1_release_notes.textile
	railties/guides/source/active_resource_basics.textile
	railties/guides/source/command_line.textile
 2011-08-13 16:30:07 -07:00
Oge Nnadi
aa0d3cece8 Typo fix 2011-08-13 16:22:35 -07:00
geemus
53e1a9d411 update abstract_controller callbacks to document meta-programmed filters 2011-08-13 16:22:35 -07:00
Casebook Developer
ebfca248f9 ActionView::Helpers::TextHelper#simple_format should not change the text in place. Now it duplicates it. 2011-08-13 16:22:29 -07:00
Waynn Lue
68c4b66015 fix stringify_keys destructive behavior for most FormTagHelper functions 
add four new tests to verify that the other three methods that called stringify_keys! are fixed. verified that the tests break in master without the code patch. Closes #2355
 2011-08-13 16:22:29 -07:00
thoefer
5f3265c471 Fix the issue where default_url_options is being cached on test cases. Closes #1872. Closes #2031. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-08-13 16:22:26 -07:00
José Valim
b6b6e81a5c Rename new method to_path to to_partial_path to avoid conflicts with File#to_path and similar. 2011-08-13 16:22:26 -07:00
Waynn Lue
759815547b remove redundant calls to stringify_keys 2011-08-13 16:22:25 -07:00
Franck Verrot
018b1315b5 We don't need to require erb here. 2011-08-13 16:22:23 -07:00
thedarkone
a53ef97206 Make use of the inherited initializer. 2011-08-13 16:22:23 -07:00
thedarkone
37b30d4b4e There is no need to be destructive with the passed-in options. 
This fixes a bug that is caused by Resource/SingletonResource mangling resource options when using inline "multi"-resource declarations.
 2011-08-13 16:22:23 -07:00
José Valim
554ea3c37b Move the cache to a nested hash which performs better than a hash with array as keys. 2011-08-13 16:22:21 -07:00
José Valim
91ca214ca0 Rename class method to_path to _to_path and make it explicit that it is an internal method. 2011-08-13 16:22:21 -07:00
Grant Hutchins & Peter Jaros
6e671a8536 Let ActiveModel instances define partial paths. 
Deprecate ActiveModel::Name#partial_path. Now you
should call #to_path directly on ActiveModel
instances.
 2011-08-13 16:22:21 -07:00
Joshua Peek
a636a9358e Make Rails.application.assets available in initializers 2011-08-13 16:22:21 -07:00
Christos Zisopoulos
035d31bd93 Improve performance and memory usage for options_for_select with Ruby 1.8.7 2011-08-13 16:22:20 -07:00
Aaron Patterson
ed09aef1a3 simplify conditionals by assuming hash values will never be false 2011-08-13 16:22:19 -07:00
Aaron Patterson
a704fd4ea9 use regular ruby rather than clever ruby 2011-08-13 16:22:19 -07:00
Aaron Patterson
f445bb2671 fixing wildcard path matching when wildcard is inside parenthesis 2011-08-13 16:22:19 -07:00
Santiago Pastorino
1d64041d59 Remove blank line 2011-08-13 16:22:19 -07:00
thoefer
39183f4ede refactored 'assert_redirected_to': local call to validate_request! will be called in assert_response already. changed names of local variables in order to recognize the semantics a bit easier. 2011-08-13 16:22:18 -07:00
Dan Gebhardt
f87b33daaf fixed problem in which options[:html][:remote] would be overridden in form_for() - fixes #2094 2011-08-13 16:22:18 -07:00
Santiago Pastorino
16e3c40426 use_sprockets is not used anymore 2011-08-13 16:22:16 -07:00
Erik Michaels-Ober
710c5eaf2f Allow a route to have :format => true 
When format is true, it is mandatory (as opposed to :format => false).
This is currently not possible with resource routes, which automatically
make format optional by default.
 2011-08-13 16:22:15 -07:00
Santiago Pastorino
5b5b22acb5 Remove unused use_sprockets config 2011-08-13 16:22:15 -07:00
Arun Agrawal
5bc87cc2ee We need [] method here. previously it's an array. 2011-08-13 13:13:05 +05:30
Arun Agrawal
8196c842b6 We actually don't need a reverse_merge! here. dup removed was giving error with nil class. 2011-08-12 16:56:29 +05:30
Andrew Kaspick
61579b7661 when calling url_for with a hash, additional (likely unwanted) values (such as :host) would be returned in the hash... calling #dup on the hash prevents this 2011-08-11 13:28:31 -05:00
Gonzalo Rodriguez and Leonardo Capillera
9e81bfd8fc Remove 'parameters_for_url' parameter from 'form_tag' method signature 
If you use that parameter it will end calling to url_for with two
arguments, which fails because url_for expects only one
 2011-08-10 23:14:56 -03:00
José Valim
bb4f687bc6 Remove lame comment. 2011-08-09 16:49:38 -07:00
Santiago Pastorino
d9b690f71f rake assets:precompile defaults to production env 2011-08-09 20:40:52 -03:00
Aaron Patterson
5f56db4454 adding missing require to fist railties tests 2011-08-09 14:54:56 -07:00
Aaron Patterson
f9f423fa18 deprecating process_view_paths 2011-08-09 12:10:25 -07:00
Aaron Patterson
3ad26c8e48 avoid object creation via useless duping and freezing 2011-08-09 11:41:06 -07:00
Aaron Patterson
26e53a16c4 just use map and case / when rather than modifying the iterating array 2011-08-09 11:30:43 -07:00
Aaron Patterson
7cd3772fe6 only typecast what we need to typecast 2011-08-09 11:26:44 -07:00
Aaron Patterson
b14f1c3ad7 Favor composition over inheritance. 2011-08-09 11:23:02 -07:00
Aaron Patterson
88de343ef4 Array#+ automatically dups, no double duping 2011-08-09 10:54:05 -07:00
Aaron Patterson
14a8fd146a Just remove the sort_locals method 2011-08-09 10:13:02 -07:00
Aaron Patterson
1fbc4704df the freeze trick does nothing on arrays used as hash keys. 2011-08-09 10:09:46 -07:00
Aaron Patterson
233696a027 use functional style to build a list of template objects 2011-08-09 09:32:16 -07:00
Aaron Patterson
37b77c6ae7 refactor the optimized build_query a bit 2011-08-08 22:16:52 -07:00
Aaron Patterson
128467e927 reduce file stats by improving our dir glob pattern 2011-08-08 21:42:45 -07:00
Aaron Patterson
295a7fd1bb hash on the template directory in order to improve cache hits 2011-08-08 21:03:40 -07:00
Aaron Patterson
940404096f use meaningful names with our variables 2011-08-08 21:01:19 -07:00
Aaron Patterson
0155bf4021 use binread to read the files 2011-08-08 19:51:41 -07:00