github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
1,306 Commits 34 Branches 105 Tags
89e06ed4c6191aff7769aeea8842f45df85acf89
Commit Graph

189 Commits

Author SHA1 Message Date
David Heinemeier Hansson
89e06ed4c6 Fixed image_tag so an exception is not thrown just because the image is missing and alt value can't be generated #1395 [Marcel] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:04:23 +00:00
David Heinemeier Hansson
5b3bc3139a Added a third parameter to TextHelper#auto_link called href_options for specifying additional tag options on the links generated #1401 [tyler.kovacs@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:00:18 +00:00
David Heinemeier Hansson
691562746f Fixed TextHelper#highlight to return the text, not nil, if the phrase is blank #1409 [patrick@lenz.sh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:42:47 +00:00
David Heinemeier Hansson
7b47f150fd Its Iraq, not Irak #1443 [ivan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:05:43 +00:00
David Heinemeier Hansson
cc6c48f0a8 Fixed TagHelper such that :name and 'name' keys in the options doesn't result in two attributes #1455 [take_tk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:04:17 +00:00
Jeremy Kemper
7bb486055e r1318@iwill: jeremy | 2005-06-15 01:08:22 -0700 
Ticket 1394 - Helper isolation
 r1319@iwill:  jeremy | 2005-06-15 01:10:00 -0700
 Formulate a test case for helper isolation.
 r1331@iwill:  jeremy | 2005-06-15 15:21:07 -0700
 Update changelog
 r1332@iwill:  jeremy | 2005-06-15 15:21:30 -0700
 Remove superfluous, broken layout_test
 r1333@iwill:  jeremy | 2005-06-15 15:24:10 -0700
 Use an anonymous Module to store helpers per-class instead of tossing them all in template_class.  Create a new helper module for subclasses which includes its superclass' helper module.  Remove unnecessary ActionView::Base.controller_delegate.  Update helper tests.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 17:17:58 +00:00
Jamis Buck
ed7bfc9662 Allow distance_of_time_in_words to work with any value that responds to #to_time (like dates) #969 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 15:19:03 +00:00
Jeremy Kemper
3cb26e9cb3 r2495@sedna: jeremy | 2005-05-27 22:07:18 -0700 
Branch to have scaffold use new render methods
 r2496@sedna:  jeremy | 2005-05-28 10:50:51 -0700
 axe unused process_request method
 r2497@sedna:  jeremy | 2005-05-28 10:51:58 -0700
 sanity assertions in process method check that @controller, @request, @response are set
 r2498@sedna:  jeremy | 2005-05-28 10:53:42 -0700
 clean up escaping.  use instance_variable_get instead of instance_eval.  put id in form action instead of hidden input (like the generated scaffolding)
 r2499@sedna:  jeremy | 2005-05-28 10:54:46 -0700
 clean up interpolation, remove tabs from stylesheet
 r2500@sedna:  jeremy | 2005-05-28 10:56:40 -0700
 modernize dynamic scaffolding.  use params[:id] instead of @params[id].  use consolidated render method instead of render_action, render_file, etc.  use builtin inflections rather than module methods.
 r2501@sedna:  jeremy | 2005-05-28 11:00:26 -0700
 modernize generated scaffolding.  use new-style assertions; use params[:id] instead of @params[id]; use consolidated render method instead of render_*
 r2542@sedna:  jeremy | 2005-06-12 02:24:06 -0700
 use :id => model instead of :id => model.id.  clean up the form helper method.  use flash[:notice] instead of flash['notice'].
 r2543@sedna:  jeremy | 2005-06-12 02:33:22 -0700
 whitespace
 r2544@sedna:  jeremy | 2005-06-12 02:56:57 -0700
 update changelogs
 r2545@sedna:  jeremy | 2005-06-12 03:26:23 -0700
 test dynamic form help when @post is not a new record
 r2546@sedna:  jeremy | 2005-06-12 03:44:14 -0700
 touch up TestCase#process sanity assertions


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 05:33:23 +00:00
David Heinemeier Hansson
3162f386dc Made Action View work with the new render :file/:partial style from the controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-02 20:12:34 +00:00
David Heinemeier Hansson
9bf38dec69 Include flash in the list of attributes with accessors in the view 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-20 07:04:51 +00:00
David Heinemeier Hansson
7160ab1c18 Fixed escaping of :method option in remote_form_tag #1218 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1328 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:08:16 +00:00
David Heinemeier Hansson
45ee71af3c Added Serbia and Montenegro to the country_select #1239 [todd@robotcoop.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:30:53 +00:00
David Heinemeier Hansson
473e5bde74 Fixed that compute_public_path should recognize external URLs, so image_tag("http://www.example.com/images/icon.gif") is not prefixed with the relative url path #1254 [victor-ronr-trac@carotena.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:06:12 +00:00
David Heinemeier Hansson
202d5c0751 Added support for descending year values in DateHelper#select_year, like select_year(Date.today, :start_year => 2005, :end_year => 1900), which would count down from 2005 to 1900 instead of the other way #1274 [nwoods@mail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:40:02 +00:00
David Heinemeier Hansson
26022d8d2a Ajax docing #1282 [Dee.Zsombor@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:29:20 +00:00
David Heinemeier Hansson
496ee0cd1b Fixed that FormHelper#checkbox should return a checked checkbox if the value is the same as checked_value #1286 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:27:08 +00:00
David Heinemeier Hansson
7ec91d4651 Fixed Form.disable in Prototype #1317 [Wintermute] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1311 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:45:53 +00:00
David Heinemeier Hansson
aa20834222 Added accessors to logger, params, response, session, and headers from the view, so you can write <% logger.info "stuff" %> instead of <% @logger.info "others" %> -- more consistent with the preferred way of accessing these attributes and collections from the controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:00:04 +00:00
David Heinemeier Hansson
86d2b2792a Added support for POST data in form of YAML or XML, which is controller through the POST_DATA_MARSHAL header 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-14 08:38:37 +00:00
David Heinemeier Hansson
51f9c931ea Fixed that render_partial_collection should always return a string (and not sometimes an array, despite <%= %> not caring) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1302 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-13 16:27:36 +00:00
David Heinemeier Hansson
8983a09752 Go straight to the class for asset_host 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1299 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-09 11:27:39 +00:00
David Heinemeier Hansson
45780be2a7 Added TextHelper#sanitize that can will remove any Javascript handlers, blocks, and forms from an input of HTML. This allows for use of HTML on public sites, but still be free of XSS issues. #1277 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-09 11:24:18 +00:00
David Heinemeier Hansson
c971c24839 Changed RAILS_ASSET_HOST to become ActionController::Base.asset_host 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-06 05:10:36 +00:00
David Heinemeier Hansson
dacb61c8ca Added that both AssetHelper#stylesheet_link_tag and AssetHelper#javascript_include_tag now accept an option hash as the last parameter, so you can do stuff like: stylesheet_link_tag "style", :media => "all" 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-03 14:39:57 +00:00
David Heinemeier Hansson
d2fb072563 Added FormTagHelper#image_submit_tag for making submit buttons that uses images 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1280 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-03 14:30:53 +00:00
David Heinemeier Hansson
2eebd11e0b Added the option of specifying a RAILS_ASSET_HOST that will then be used by all the asset helpers. This enables you to easily offload static content like javascripts and images to a separate server tuned just for that. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-03 10:25:01 +00:00
David Heinemeier Hansson
577a22c47e Dont benchmark if the logger has been turned off 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 07:05:15 +00:00
David Heinemeier Hansson
90b08c5b92 Fixed documentation #1214 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:50:10 +00:00
David Heinemeier Hansson
98306bed05 Fixed missing id uniqueness in FormTag#radio_button #1207 [Jarkko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:46:22 +00:00
David Heinemeier Hansson
fbd86c2017 Added BenchmarkHelper that can measure the execution time of a block in a template and reports the result to the log 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-27 08:17:25 +00:00
Sam Stephenson
71a616890b Update to Prototype 1.2.1 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 11:16:50 +00:00
David Heinemeier Hansson
0dd497853a More documentation #1148 [Alisdair McDiarmid] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 10:59:55 +00:00
David Heinemeier Hansson
865874ab6a Fixed stringification on all assigned hashes. The sacrifice is that assigns[:person] wont work in testing. Instead assigns["person"] or assigns(:person) must be used. In other words, the keys of assigns stay strings but weve added a method-based accessor to appease the need for symbols. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1223 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 10:26:03 +00:00
David Heinemeier Hansson
bceb88ef9c Fixed that you can now pass an alternative :href option to link_to_function/remote in order to point to somewhere other than # if the javascript fails or is turned off. You can do the same with form_remote_tag by passing in :action. #1113 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 05:15:17 +00:00
Sam Stephenson
d547c3f5ec Update to Prototype 1.2.0 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1198 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 02:16:13 +00:00
David Heinemeier Hansson
dca7efa67e Deprecated the majority of all the testing assertions and replaced them with a much smaller core and access to all the collections the old assertions relied on. That way the regular test/unit assertions can be used against these. Added documentation about how to use it all. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 11:38:01 +00:00
David Heinemeier Hansson
8e8bf37aa9 Fixed DateHelper to return values on the option tags such that they'll work properly in IE with form_remote_tag #1024 [rscottmace@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:44:28 +00:00
David Heinemeier Hansson
ba96827b3d Fixed FormTagHelper#check_box to respect checked #1049 [DelynnB] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:39:01 +00:00
David Heinemeier Hansson
c3ca5ab7a8 Added Element.toggle, Element.show, and Element.hide to the prototype javascript library. Toggle.display has been deprecated, but will still work #992 [Lucas Carlson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 07:52:50 +00:00
David Heinemeier Hansson
ffdd4bc251 Added AssetTagHelper#image_path, AssetTagHelper#javascript_path, and AssetTagHelper#stylesheet_path #1110 [Larry Halff] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:23:27 +00:00
David Heinemeier Hansson
6ee06ebec6 Changed render_partial to take local assigns as the second parameter instead of an explicit object and then the assigns 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-16 16:08:29 +00:00
David Heinemeier Hansson
82456d9392 Fixed partials handling 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-16 16:06:29 +00:00
David Heinemeier Hansson
f3e5e07982 Added submit_to_remote that allows you to trigger an Ajax form submition at the click of the submission button, which allows for multiple targets in a single form through the use of multiple submit buttons #930 [yrashk@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 05:44:43 +00:00
David Heinemeier Hansson
2ad8dc6a1f Added :confirm option to link_to_remote just like link_to has #1082 [yrashk@fp.org.ua] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 05:21:37 +00:00
David Heinemeier Hansson
c29db9f210 Added minute_step as an option to select_minute (and the helpers that use it) to jump in larger increments than just 1 minute. At 15, it would return 0, 15, 30, 45 options #1085 [ordwaye@evergreen.edu] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 05:15:41 +00:00
David Heinemeier Hansson
988dc1e862 Improved tests for NumberHelper 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 04:49:01 +00:00
David Heinemeier Hansson
6f5fcc4469 Made error_messages_for take a symbol as object_name 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1148 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-12 17:44:28 +00:00
David Heinemeier Hansson
7140f65355 Moved TextHelper#human_size to NumberHelper#number_to_human_size, but kept an deprecated alias to the old method name 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-12 08:04:38 +00:00
David Heinemeier Hansson
5cd815addf Fixed spelling of delimiter #1058 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-10 17:30:38 +00:00
David Heinemeier Hansson
ac4b4701c0 Fixed that radio buttons shouldn't have a default size attribute #1074 [hendrik@mans.de] Added ActionView::Helpers::InstanceTag::DEFAULT_RADIO_OPTIONS that contains a hash of default options for radio buttons #1074 [hendrik@mans.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-10 15:11:15 +00:00