Joshua Peek
8a442e0d57
Extracted Template rendering logic into Renderer module
2008-07-03 13:06:00 -05:00
Joshua Peek
7d5c8505f5
Use render on InlineTemplate
2008-07-03 12:50:43 -05:00
Joshua Peek
b6f89a8bf5
Don't rely on view instance logger
2008-07-03 12:49:54 -05:00
Joshua Peek
42d215a925
Moved TemplateHandlers to Base
2008-07-03 12:48:00 -05:00
Michael Koziarski
75e04b5295
Tighten the rescue clause when dealing with invalid instance variable names in form_helper.
2008-07-03 19:43:20 +03:00
Michael Koziarski
d79cde37ea
Move the file exists checks outside write_asset_file_contents.
...
This lets us avoid the relatively costly trip through compute_*_paths if the file already exists.
2008-07-03 19:43:14 +03:00
Michael Koziarski
12cf8f348b
Move template_format logic out to the request so it's alongside the 'regular' request format.
...
Use xhr? instead of the expensive trip through Request#accepts.
2008-07-03 19:43:06 +03:00
Michael Koziarski
7098143f07
Remove unused local_binding option to InstanceTag's Constructor
2008-07-03 19:26:56 +03:00
Michael Koziarski
5dd10d60bb
Remove nested ternary operators from select_year in favour of conditionals.
2008-07-03 19:26:56 +03:00
Michael Koziarski
df36a6f759
Remove unneeded ObjectWrapper class.
...
Was previously needed to work around the semantics of a deprecated (now removed) API to render :partial
2008-07-03 19:26:56 +03:00
Michael Koziarski
e358b1fce8
Remove old method of including javascripts define_javascript_functions.
...
javascript_include_tag and friends do a much better job.
2008-07-03 19:21:04 +03:00
Michael Koziarski
5501166dec
Remove strange alias for JavaScriptHelper
2008-07-03 19:20:47 +03:00
Tarmo Tänav
a37d065f85
Use :namespace instead of :path_prefix for finding controller. [ #544 state:resolved]
...
:namespace is supposed to be the module where controller exists.
:path_prefix can contain anything, including variables, which
makes it unsuitable for determining the module for a controller.
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-07-03 16:11:50 +01:00
Joshua Peek
3b3790a435
Deprecate :use_full_path render option. The supplying the option no longer has an effect.
2008-07-02 21:38:58 -05:00
Mike Subelsky
8f640c381d
Added application/jsonrequest as a synonym for application/json
...
[#536 state:resolved]
2008-07-02 11:39:42 -07:00
Pratik Naik
267d3964eb
Make sure render :collection doesnt set nil local when :as is absent
2008-07-02 17:19:41 +01:00
Pratik Naik
2b43620e3c
Add :as option to render a collection of partials with a custom local variable name. [ #509 state:resolved] [Simon Jefford, Pratik Naik]
2008-07-02 16:40:42 +01:00
Tim Haines
f5052dd8a3
Make sure render :template works with :locals. [ #524 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-07-02 04:30:34 +01:00
Joshua Peek
aff2d33172
Improved test coverage and added RackRequest support for CGI environment variables.
2008-07-01 21:53:55 -05:00
Scott Stewart
7378e23734
Ensure proper output when submit_tag is used with :disabled_with. [ #388 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-07-02 01:39:30 +01:00
gbuesing
4cf93935b2
Fix indentation and update changelogs for previous commit
2008-06-29 13:46:07 -05:00
Ernie Miller
d0092dc44d
Added support for regexp matching of priority zones in time_zone_select [ #195 state:resolved]
2008-06-29 13:37:07 -05:00
Pratik Naik
029a745584
Ensure FormBuilder date helpers respects html_options. [ #506 state:resolved] [Pascal Ehlert]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-06-29 00:36:31 +01:00
Cheah Chu Yeow
3c1e8ab0fe
Allow single quote (the ' character) in the middle of URL when auto_link-ing. [ #471 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-06-27 13:46:17 +01:00
Joshua Peek
a9259ccfe0
Hide InlineTemplate class from ActionController and use ActionView's render API
2008-06-25 06:04:06 -05:00
Joshua Peek
ad772402c4
Made ActionView::Base#render_file private
2008-06-25 05:57:24 -05:00
Joshua Peek
6f5327013d
Consolidate CustomHandlerTest, TemplateFileTest, and TemplateObjectTest and test them at a higher level of abstraction in ViewRenderTest.
2008-06-25 05:49:38 -05:00
Jimmy Baker
670e22e372
Patched HTML::Document#initialize call to Node.parse so that it includes the strict argument. [ #330 ]
2008-06-24 23:11:35 -07:00
Jeremy Kemper
69e72af622
Improve readability
2008-06-24 11:53:49 -07:00
Jeremy Kemper
b409474325
link_to_function and button_to_function shouldn't modify their options hashes
2008-06-23 23:41:21 -07:00
Tammer Saleh
bb6e8eea5a
Fixed polymorphic_url to be able to handle singleton resources.
...
Example usage:
polymorphic_url([:admin, @user, :blog, @post]) # => admin_user_blog_post_url(@user, @post)
[#461 state:resolved]
2008-06-22 18:58:47 -07:00
Jeremy Kemper
f4ccc17953
Performance: javascript helper tweaks to speed up escaping and reduce object allocations when building options strings
2008-06-21 14:54:10 -07:00
Jeremy Kemper
72f93b581f
Check whether blocks are called from erb using a special __in_erb_template variable visible in block binding.
2008-06-19 22:21:56 -07:00
Jeremy Kemper
c440c9b199
Move erb_trim_mode setting to the ERB template handler. Keep a Base.erb_trim_mode= delegator around.
2008-06-19 17:18:07 -07:00
rick
10c581a6de
fix merge
2008-06-19 09:59:36 -07:00
Joshua Peek
bec4b69a3b
Replaced TemplateFinder abstraction with ViewLoadPaths
2008-06-17 21:21:07 -05:00
Jeremy Kemper
d7b3c3395f
Performance: PartialTemplate#initialize
2008-06-17 16:01:48 -07:00
David Heinemeier Hansson
8190bce8bc
Added block-call style to link_to [Sam Stephenson/DHH]
2008-06-17 17:37:29 -05:00
Luke Redpath
7650ff892c
Fix url_for with no arguments when default_url_options is not explicitly defined. [ #339 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-06-17 20:53:41 +01:00
Amos King
1b4b8fbbd9
verify :redirect_to => :back should redirect to the referrer. [ #280 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-06-17 18:08:56 +01:00
Andrew Kaspick
322f3eacf9
Correct code example in dom_id docs. [ #437 state:resolved]
2008-06-17 00:32:37 -07:00
Jeremy Kemper
e433bb16a6
Merge branch 'master' of git@github.com:rails/rails
2008-06-16 03:05:24 -07:00
Pratik Naik
f31651bd6a
Reload cached templates when a new handler is registered
2008-06-15 17:20:31 +01:00
Jeremy Kemper
eab71208db
Performance: integration test benchmarking and profiling. [Jeremy Kemper]
2008-06-14 02:04:38 -07:00
Pratik Naik
eea4fe4c90
Make rescue template xhtml compatible [Sam Ruby] [ #415 status:resolved]
2008-06-13 23:23:44 +01:00
David Heinemeier Hansson
6573f6a4bc
Revert "Lazy load cache and session stores"
...
This reverts commit 19895f087c
2008-06-12 19:52:33 -05:00
Joshua Peek
d4c58c7928
Opps, I forgot to add template_handlers.rb to my index.
2008-06-11 22:22:05 -05:00
Joshua Peek
5ed162d7c1
Moved template handler registration into a mix-in module.
2008-06-11 22:05:36 -05:00
Jonathan del Strother
3e07f320c1
Improve ActionCaching's format-handling
...
Make ActionCaching more aware of different mimetype formats.
It will now use request.format to look up the cache type, in addition to the path extension.
When expiring caches, the request format no longer affects which cache is expired.
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-06-11 13:15:01 +01:00
Pratik Naik
f728e57d22
Make sure cache_template_loading works and don't use to_prepare callback
2008-06-11 09:36:41 +01:00
