github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
25,364 Commits 34 Branches 105 Tags
8df7fe3f630e13da1585c151f6f2f986ea7dcdfd
Commit Graph

2878 Commits

Author SHA1 Message Date
José Valim
9c6d4801d1 Merge pull request #3193 from avakhov/patch-ac-test-case-safe-constantize 
use safe_constantize instead constantize in AC::TestCase
 2011-10-03 02:10:40 -07:00
Alexey Vakhov
8e946daf69 normalize arg for AC::TestCase tests class method 2011-10-03 12:12:07 +04:00
Alexey Vakhov
0eb80fabdd use safe_constantize instead constantize in AC::TestCase 2011-10-03 10:04:14 +04:00
Alexey Vakhov
1bd88fdafd add missing require to html sanitizer 2011-09-27 23:39:52 +04:00
José Valim
e8987c30d0 Use safe_constantize where possible. 2011-09-23 16:46:33 +02:00
Mike Dillon
7fb99e5743 Change log level for CSRF token verification warning 2011-09-10 08:31:04 -07:00
Nicolás Hock Isaza
9821d982ff Fixing record_key_for_dom_id documentation. 
The default implementation joins everything with '_' and not with '-'
 2011-09-06 23:26:56 -05:00
Aaron Patterson
f6ced69a11 Eliminate newlines in basic auth. fixes #2882 2011-09-06 17:25:20 -07:00
Milan Dobrota
9b08afd2f4 if ... nil? is more expensive than unless 2011-09-04 10:44:08 -05:00
Alexey Vakhov
19ec3c1ae6 fix helpers behavior description 2011-09-03 23:13:40 +04:00
Xavier Noria
bb4dedbc2c deletes spurious arrow 2011-08-27 15:34:33 -07:00
Vijay Dev
8526f727cf doc fixes 2011-08-28 02:27:39 +05:30
David Majda
68a13eded3 Make ActionController::TestCase#recycle! set @protocol to nil 
This ensures that the protocol does not get carried over when there are
two or more requests in functional tests. This was a problem when e.g.
the first request was HTTP and the second request was HTTPS.

Closes #2654.

Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
 2011-08-23 15:34:11 +01:00
Andrew White
14cf4b2e35 Don't modify params in place - fixes #2624 2011-08-23 11:07:37 +01:00
Santiago Pastorino
165fb830d0 Merge pull request #2596 from dharmatech/patch-1 
ActionController::Redirecting : fix docs typo
 2011-08-20 14:16:15 -07:00
Santiago Pastorino
71ef72c3d0 Merge pull request #2597 from dharmatech/patch-2 
actionpack/lib/action_controller/base.rb: docs typo
 2011-08-20 14:14:54 -07:00
Vijay Dev
7da70a431c params wrapper docs correction 2011-08-21 00:25:58 +05:30
dharmatech
dfd03fdbd3 actionpack/lib/action_controller/base.rb: docs typo 2011-08-20 00:17:44 -05:00
dharmatech
31d38d37d3 ActionController::Redirecting : fix docs typo 2011-08-20 00:07:34 -05:00
Aaron Patterson
586a944ddd Tags with invalid names should also be stripped in order to prevent 
XSS attacks.  Thanks Sascha Depold for the report.
 2011-08-16 15:24:48 -07:00
Jon Leighton
8e23615245 Use lazy load hooks to set parameter wrapping configuration. This means that it doesn't force Action Controller / Active Record to load, but it doesn't fail if they have already loaded. Thanks @josevalim for the hint. 2011-08-16 19:14:20 +01:00
Jon Leighton
6c5f67cac1 Don't refer to ActionController::Base in the wrap_parameters initializer - use config object instead. Cuts about 15% off the load time. (#734) 2011-08-16 00:59:59 +01:00
Franck Verrot
75dd33a0ae Methods like status and location are interfering with redirect_to [Closes #2511] 2011-08-14 19:00:30 +02:00
Xavier Noria
bf2b9d2de3 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	RELEASING_RAILS.rdoc
	actionpack/lib/sprockets/railtie.rb
	actionpack/test/template/sprockets_helper_test.rb
	activerecord/test/cases/calculations_test.rb
	railties/guides/source/3_1_release_notes.textile
	railties/guides/source/active_resource_basics.textile
	railties/guides/source/command_line.textile
 2011-08-13 16:30:07 -07:00
Oge Nnadi
aa0d3cece8 Typo fix 2011-08-13 16:22:35 -07:00
thoefer
5f3265c471 Fix the issue where default_url_options is being cached on test cases. Closes #1872. Closes #2031. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-08-13 16:22:26 -07:00
Santiago Pastorino
8845ae683e x_sendfile_header now defaults to nil and production.rb env file doesn't 
set a particular value for it. This allows servers to set it through
X-Sendfile-Type, read
https://github.com/rack/rack/blob/master/lib/rack/sendfile.rb for more
info. Anyways you can force this value in your production.rb
 2011-08-07 13:11:50 -03:00
thoefer
860202e8b2 Fix the issue where default_url_options is being cached on test cases. Closes #1872. Closes #2031. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-08-01 11:49:24 +02:00
Oemuer Oezkir
71d18ce48e Changed a few instances of of words in the API docs written in British English to 
American English(according to Weber)
 2011-07-24 10:21:42 +00:00
Jesse Storimer
ac81af40c0 Ensure that status codes are logged properly 
Needed to move AC::Metal::Instrumentation before AM::Metal::Rescue
so that status codes rendered from rescue_from blocks are logged
properly.
 2011-07-18 13:42:07 -04:00
José Valim
1fdbd4708f Merge pull request #2009 from vatrai/autoload-todo-new 
TODO fix explicitly loading exceptations, autoload removed
 2011-07-11 07:35:43 -07:00
Vishnu Atrai
525fd3ac86 TODO fix explicitly loading exceptations, autoload removed 2011-07-11 13:14:02 +05:30
Xavier Noria
b65bd01d55 Merge branch 'master' of git://github.com/lifo/docrails 2011-07-09 12:20:24 +02:00
Akira Matsuda
a3683fd0e4 find(:all) => all 2011-07-08 06:13:21 +09:00
José Valim
7da88c5b29 Remove stream at the class level. 
This is because only template rendering works with streaming.
Setting it at the class level was also changing the behavior
of JSON and XML responses, closes #1337.
 2011-07-06 20:24:30 -03:00
Xavier Noria
289b5253ce Merge branch 'master' of git://github.com/lifo/docrails 2011-07-05 01:42:13 +02:00
Vijay Dev
2949e30a05 document handle_unverified_request method 2011-07-02 21:18:46 +05:30
Vijay Dev
5fe67fa7a3 update doc about resetting the session in case of authenticity token mismatch 2011-07-01 00:00:38 +05:30
José Valim
9c9ec2172e Make sure respond_with with :js tries to render a template in all cases 2011-06-30 11:47:36 -03:00
José Valim
c690b7124d [IMPORTANT] Make "sprockets/railtie" require explicit. 
This makes "sprockets/railtie" explicit. This means that sprockets will
be loaded when you require "rails/all". If you are not using requiring
"rails/all", you need to manually load it with all other framework
railties.

In order to be complete, this commit also adds --skip-sprockets to
the rails generator.
 2011-06-29 09:41:16 -03:00
Esad Hajdarevic
2a61d47b55 Make send_file guess content-type from file extension, if type wasn't supplied (Issue #1847). Update tests & documentation. 2011-06-28 06:58:28 +02:00
Matt Jankowski
2fd1f2e843 clarify which url would be used to cache a page when options are not provided to #cache_page to determine that url 2011-06-26 19:44:55 -04:00
Matt Jankowski
eccd5cb610 elaborate on how web server configuration to check for static files on disk enables page caching to work without hitting the app server stack 2011-06-26 19:41:49 -04:00
James Cox
d446c798a5 make the logs a little simpler to view, put the render message inline with other events, pull processing to char[0] and add a new line to the completed. looks more like a block now, which is useful for serial actions like test/dev 2011-06-24 13:10:06 -07:00
Xavier Noria
1f505a8ef2 Merge branch 'master' of git://github.com/lifo/docrails 2011-06-23 18:08:11 +02:00
Matt Jankowski
620bee45fe more detail on how the flow between redirect and show works, and minor grammar 2011-06-21 10:47:37 -04:00
Jeroen Jacobs
791127eee4 Fixes an issue where cache sweepers with only after filters would have no controller object 
It would raise undefined method controller_name for nil
 2011-06-21 12:34:00 +02:00
Santiago Pastorino
4131fd7c79 Call super here to allow SessionHash initialize new stuff for us 2011-06-19 22:00:22 -03:00
Christine Yen
0a67b745be Tweak linebreak in ActionController::Redirecting doc 2011-06-15 03:18:28 -07:00
Christine Yen
8da91036c0 Improve documentation around status code argument of redirect_to 2011-06-15 01:55:57 -07:00