Neeraj Singh
8fdecaaef2
Ensure we can nest include calls [ #5285 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-14 13:17:29 +02:00
Xavier Noria
08c37ebf6f
be more precise re :validate and :autosave
2010-08-12 19:30:51 +02:00
Xavier Noria
4134d7db34
Merge remote branch 'docrails/master'
2010-08-12 17:36:09 +02:00
Xavier Noria
8af2186d26
revises some autosave docs, style and content
2010-08-12 17:31:04 +02:00
Paco Guzman
8a2b69b727
applied guidelines to "# =>"
2010-08-12 17:09:58 +02:00
José Valim
e4943e93c2
Make update_attribute behave as in Rails 2.3 and document the behavior intrinsic to its implementation.
2010-08-12 12:04:16 -03:00
Xavier Noria
599c505837
commit review: applies guidelines to "# =>"
2010-08-12 16:41:34 +02:00
Neeraj Singh
cfad74cfef
updating documentation for named_scope and default_scope
2010-08-12 10:23:20 -04:00
Mark Turner
1049bae132
fixed indentation in test cases
...
Signed-off-by: wycats <wycats@gmail.com >
2010-08-11 23:55:53 -07:00
Paul Hieromnimon
007c4da9ae
Raising exception if fixture file can't be found
2010-08-11 15:47:34 -07:00
Aaron Patterson
7de03ec765
subtracting blank strings is slightly faster than blank?
2010-08-11 15:45:06 -07:00
Aaron Patterson
06dc884454
avoid multiple hash lookups
2010-08-11 15:00:08 -07:00
Aaron Patterson
ce529b4759
dry up the hash dup and avoid sending nil values
2010-08-11 15:00:02 -07:00
Aaron Patterson
0f502ab88f
avoiding tap saves us time
2010-08-11 11:44:08 -07:00
Aaron Patterson
2b8f24998e
unless Array#empty? is faster than if Array#present?
2010-08-11 11:44:04 -07:00
Aaron Patterson
3c11e92616
stop using private methods
2010-08-11 11:43:57 -07:00
Tobias Lütke
cb9295c8a1
Added test case to verify that transaction callbacks are correctly propagated to class observers
2010-08-09 21:36:06 -04:00
Brian Lopez
188855501b
move mysql2 adapter into core
2010-08-09 14:52:00 -07:00
Brian Lopez
94cff67bd1
ignore this test for mysql2
2010-08-09 12:50:09 -07:00
Brian Lopez
ee9c950f2f
bringing over latest from master
2010-08-09 12:43:49 -07:00
Neeraj Singh
190e270db2
adding more documentation for autosave option
2010-08-09 13:37:51 -04:00
Xavier Noria
4f7565c4de
adds missing requires for Object#try
2010-08-09 15:25:21 +02:00
Xavier Noria
b7c4523a94
Merge remote branch 'docrails/master'
2010-08-08 18:33:55 +02:00
Aaron Patterson
334452098e
reduce the number of times current_connection_id is called in with_connection()
2010-08-06 16:39:12 -07:00
Aaron Patterson
e1596be323
test to ensure that respond_to? delegates to arel
2010-08-06 15:23:25 -07:00
Aaron Patterson
d082a9a2b8
sorry AR, my privates are none of your business
2010-08-06 14:53:01 -07:00
Neeraj Singh
74dde5951a
updating documentation for method configure_dependency_for_has_many
2010-08-06 15:24:53 -04:00
Aaron Patterson
12b3eca420
do not rely on arel class structure
2010-08-06 11:31:05 -07:00
Aaron Patterson
1ca18a6f85
fixing whitespace errors
2010-08-05 08:15:22 -07:00
Aaron Patterson
117b096d0a
avoid passing lists of lists to the group clause
2010-08-04 16:24:01 -07:00
Xavier Noria
3cbe111439
Merge remote branch 'docrails/master'
2010-08-05 01:15:57 +02:00
Xavier Noria
d191db76e0
standarizes the use of the article "an" for "SQL" and "SQLite"
2010-08-05 01:09:09 +02:00
Aaron Patterson
ec736dff7b
call to_a since we are not passing anything to all()
2010-08-04 14:22:29 -07:00
Aaron Patterson
30abb01d07
fisting indentation
2010-08-04 14:11:30 -07:00
Aaron Patterson
cff7f53fbc
do not pass AR objects to ARel
2010-08-04 08:44:53 -07:00
wycats
c25c3879ce
I'm unsure how cloning was working in Rails 3 before
2010-08-04 04:05:54 -07:00
Aaron Patterson
6d6ed55324
avoid passing AR::Base objects to Arel when we can
2010-08-03 17:58:56 -07:00
RainerBlessing
7e4e1f0ca5
query value is converted to_s instead of to_yaml
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-08-03 21:08:43 -03:00
wycats
c0fa4de65b
Allow :name to be a Symbol (was this removed by accident?)
2010-08-03 12:22:36 -07:00
Aaron Patterson
41c1aa607d
order query is already a string, no need to to_s
2010-08-03 09:16:01 -07:00
Neeraj Singh
db1c484c55
Dynamic finder method like scoped_by_* create methods so that
...
method_missing is not hit next time. Adding a test for this
scenario.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:46:09 +02:00
Neeraj Singh
807239f5a1
Making Active Record base_test.rb thinner by moving tests
...
to relevant files.
Number of assertions before refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors
Number of assertions after refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:45:54 +02:00
Neeraj Singh
74f7e172c7
fixing documentation
2010-08-03 04:14:14 -04:00
Xavier Noria
4dc2521028
Merge remote branch 'docrails/master' into 3-0-stable
2010-08-03 02:15:12 +02:00
Brian Lopez
d8b90114dd
skip the before_type_cast_on_datetime test entirely for mysql2
2010-08-02 15:11:00 -07:00
Brian Lopez
42035fd112
move reload after touch
2010-08-02 15:10:34 -07:00
Brian Lopez
ab64499911
reload the owner model after update
2010-08-02 14:51:57 -07:00
Brian Lopez
954de9940b
Merge branch 'master' into mysql2
...
* master:
Bring returning back to ease migration.
Remove duplicated logic.
Eager loading an association should not change the count of children
fix loading of different elements in array then int and string [#5036 state:resolved]
Tidy up previous commit.
test and fix collection_singular_ids= with string primary keys [#5125 state:resolved]
Handle edge cases in the previous patch.
Improved how AppGenerator generates the application name. It now detects the current app name whenever possible. This means that renaming the residing directory will not effect the app name generated by AppGenerator.
ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 state:resolved]
Add missing require in ActiveSupport::HashWithIndifferentAccess [#5189 state:resolved]
Add an internal (private API) after_touch callback. [#5271 state:resolved]
added failing touch propagation test
Makes rails destroy scaffold don't duplicate routes.draw do |map| |map| when using the deprecated syntax
Failing test to check for route file corruption if legacy map parameter is used. [#5263 state:open]
Corrected the rake test:units and test:functionals description [#5251 state:committed]
Use AS::OrderedHash when trusting in the order of the hash
Fix label form helper to use I18n and html options, without the need of 'nil' text param:
2010-08-02 13:30:08 -07:00
Neeraj Singh
db0e3e5ad1
Correcting the documentation which wrongly states that each dynamic finder creates
...
method on the class. Only dynamic finders using <tt>scoped_by_*</tt> creates new
methods.
2010-08-02 13:10:32 -04:00
Neeraj Singh
d3eacf9352
Adding to AR::Base documentation about dynamically scopeded_by query
...
User.scoped_by_user_name('David')
2010-08-02 13:07:18 -04:00
