github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-09 21:55:24 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,390 Commits 34 Branches 105 Tags
9040f406820a9cd2d6a016fd2a7965d21445bbec
Commit Graph

940 Commits

Author SHA1 Message Date
Jeremy Kemper
13e1d295d6 @response.redirect_url works with 201 Created responses: just return headers['Location'] rather than checking the response status. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-28 23:25:00 +00:00
Michael Koziarski
f6e85e4ec6 Merge [5641] to Trunk 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-27 23:56:27 +00:00
Jeremy Kemper
4887e53bf9 Use Location rather than location header. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5635 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-26 05:35:53 +00:00
David Heinemeier Hansson
093c725732 Fix that redirects should set "Location" header, not "location", and remove dead CGI.redirect 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5634 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-26 05:04:57 +00:00
Jeremy Kemper
ba1db2de63 uses_component_template_root looks at caller[0] which turns up the deprecation method rather than the controller. Use caller[1] instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-26 01:24:10 +00:00
David Heinemeier Hansson
396b3f2bef Dont set default charset if the response is sending a file. Closes #6689 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-25 19:29:10 +00:00
Tobias Lütke
ad62d461e8 Added CSV to Mime::SET so that respond_to csv will work 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5623 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-24 16:35:00 +00:00
David Heinemeier Hansson
7c7d58937b Fixed that HEAD should return the proper Content-Length header (that is, actually use @body.size, not just 0) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-23 23:52:25 +00:00
David Heinemeier Hansson
efd0bdd9ea * Added GET-masquarading for HEAD, so request.method will return :get even for HEADs. This will help anyone relying on case request.method to automatically work with HEAD and map.resources will also allow HEADs to all GET actions. Rails automatically throws away the response content in a reply to HEAD, so you dont even need to worry about that. If you, for whatever reason, still need to distinguish between GET and HEAD in some edge case, you can use Request#head? and even Request.headers["REQUEST_METHOD"] for get the "real" answer. Closes #6694 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5621 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-23 23:24:47 +00:00
David Heinemeier Hansson
f15d52fc4a Added text/csv as a default mime type and included example on how to make your own in config/environment.rb [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5620 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-23 17:25:52 +00:00
Nicholas Seckar
d1529a71d1 Update Routing to complain when :controller is not specified by a route. Closes #6669. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5607 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-22 16:31:00 +00:00
Jeremy Kemper
6fc8e143c6 Ensure render_to_string cleans up after itself when an exception is raised. Closes #6658. Great tests! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-20 11:03:21 +00:00
Nicholas Seckar
f92d6a07d0 Reuse named route helper module between Routing reloads to prevent memory leaks. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5548 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-17 22:29:02 +00:00
Jeremy Kemper
96cca7db6d ActionView::Base.erb_variable accessor names the buffer variable used to render templates. Defaults to _erbout; use _buf for erubis. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-17 13:10:23 +00:00
Jeremy Kemper
0100a79913 Deprecate standalone components. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5536 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-16 06:40:37 +00:00
Jeremy Kemper
65ca37b7b7 ARStore needs a data reader method. Closes #4795. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-15 20:08:43 +00:00
Jeremy Kemper
c9e0002d36 assert_select_rjs :remove 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-15 12:45:52 +00:00
Jeremy Kemper
56e3e2fde5 Always clear model associations from session. Closes #4795. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5512 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-13 18:59:01 +00:00
Jeremy Kemper
f0753992ab test controller rescues 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-13 02:03:50 +00:00
Jeremy Kemper
73cc10305e Sync ActionController::StatusCodes::STATUS_CODES with http://www.iana.org/assignments/http-status-codes. Closes #6586. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5482 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-11 01:44:37 +00:00
Jeremy Kemper
0342393b30 Multipart form values may have a content type without being treated as uploaded files if they do not provide a filename. Closes #6401. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-09 18:52:19 +00:00
Jeremy Kemper
57313c54bf assert_response supports symbolic status codes. Closes #6569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5466 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-07 21:45:10 +00:00
Jeremy Kemper
5c2e9a5e48 Cache parsed query parameters. Closes #6559. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-06 21:43:21 +00:00
Jeremy Kemper
a8bb66ace8 Deprecate expire_matched_fragments. Use expire_fragment instead. Closes #6535. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-02 19:29:40 +00:00
Jeremy Kemper
eb7964865a Document that expire_fragment with regexp arg fails on memcached and other caches which don't support iteration over all keys. Closes #6291. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-02 08:48:44 +00:00
David Heinemeier Hansson
b9ffbd3166 Fix scaffolding from using deprecated :post => true (closes #6499) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-26 15:56:48 +00:00
Jamis Buck
897ffd63d2 Use new deprecate syntax so that alternatives are given with the warning 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5358 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-24 17:14:50 +00:00
Jamis Buck
da18193d5f More consistent implementation of filter replacement (thanks Martin! closes #5949) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-21 16:55:14 +00:00
Rick Olson
1d7196b552 Force *_url named routes to show the host in ActionView [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 18:00:20 +00:00
David Heinemeier Hansson
f366eb4b2d GET parameter keys can be escaped too [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-17 22:06:54 +00:00
Jamis Buck
2d33676691 Fix deprecation warnings when rendering the template error template. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 19:59:46 +00:00
Nicholas Seckar
03b383853d Fix routing to correctly determine when generation fails. Closes #6300. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5314 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 19:52:21 +00:00
Jamis Buck
b5ec0fe313 Fix broken assert_generates when extra keys are being checked. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 14:32:11 +00:00
Jamis Buck
39963b4b9d remove an obsolete #dup call. avoid double negatives, to make the code easier to understand and explain 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-15 03:11:08 +00:00
Jamis Buck
ef6921628d make sure filters in subclasses with :only or :except conditions are treated like skip_filter calls 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-14 01:54:42 +00:00
Marcel Molina
065908a4c5 Make page caching respect the format of the resource that is being requested even if the current route is the default route so that, e.g. posts.rss is not transformed by url_for to '/' and subsequently cached as '/index.html' when it should be cached as '/posts.rss'. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 23:29:04 +00:00
Nicholas Seckar
214d236e7d Install named routes into ActionView::Base instead of proxying them to the view via helper_method. Closes #5932. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-11 04:31:57 +00:00
Nicholas Seckar
bbcd508d64 Fix typo 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 22:54:53 +00:00
Jamis Buck
02dc646d55 Fix relative URL root matching problems 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5272 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 19:14:11 +00:00
Jeremy Kemper
eaae0399ad r5540@ks: jeremy | 2006-10-08 23:05:30 -0700 
#5949
 r5541@ks:  jeremy | 2006-10-08 23:07:08 -0700
 Fix filter skipping in controller subclasses.
 r5557@ks:  jeremy | 2006-10-08 23:11:24 -0700
 Update changelog.  Closes #5949, references #6297, references #6299.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 06:11:40 +00:00
Jeremy Kemper
a307b8c7dc render_text may optionally append to the response body. render_javascript appends by default. This allows you to chain multiple render :update calls by setting @performed_render = false between them (awaiting a better public API). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:26:35 +00:00
David Heinemeier Hansson
f9650a23f0 Fixed that caches_action breaks with file extensions (closes #6257) [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:56:13 +00:00
David Heinemeier Hansson
31d3048706 Fixed that rescue template path shouldn't be hardcoded, then it's easier to hook in your own (closes #6295) [mnaberez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:40:05 +00:00
David Heinemeier Hansson
2e766b159f Fixed that some 500 rescues would cause 500's themselves because the response had not yet been generated #6329 [cmselmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:21:47 +00:00
David Heinemeier Hansson
3c6b7a2191 Fixed that assert_select selects the wrong tag by its contents (closes #6332) [jgarber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:20:31 +00:00
David Heinemeier Hansson
717e26dd0e Deprecation cleanup for rescues (closes #6339) [adam] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:17:11 +00:00
Jeremy Kemper
7ea86773a9 r5515@ks: jeremy | 2006-10-08 13:24:42 -0700 
#6281
 r5516@ks:  jeremy | 2006-10-08 13:29:49 -0700
 respond_to :html doesn't assume .rhtml. Closes #6281.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-08 20:30:24 +00:00
Jeremy Kemper
8cb0079fea add response to list of deprecated instance variables 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 22:36:02 +00:00
Jeremy Kemper
297ac55b29 use instance vars in rescue templates since controller may not be instantiated yet 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5217 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 16:32:51 +00:00
Rick Olson
3010e30f0e Fixed some deprecation warnings in ActionPack [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-30 01:38:22 +00:00