github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-13 23:55:16 -05:00
Code Issues Packages Projects Releases Wiki Activity
6,057 Commits 34 Branches 105 Tags
93ec552e9b76be7491dfe06c09e0e636dfd0d3a3
Commit Graph

389 Commits

Author SHA1 Message Date
Jeremy Kemper
4b055a4a6a Update destroy_all and delete_all documentation to better describe their tradeoffs. Closes #10447. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 09:12:18 +00:00
Jeremy Kemper
73673256ac Document Active Record exceptions. Closes #10444. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8362 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 04:13:33 +00:00
Jeremy Kemper
ed6949b2d7 Remove unused ConnectionFailed exception 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 03:34:05 +00:00
Jeremy Kemper
836f32cf7d Axe outdated :ar_joins commentary 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 01:48:14 +00:00
David Heinemeier Hansson
e16ecaf84c Fixed that the truncation of strings longer than 50 chars should use inspect so newlines etc are escaped (closes #10385) [norbert] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-06 00:01:11 +00:00
Marcel Molina
edf32cea3f More complete documentation for find_by_sql. Closes #7912 [fearoffish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 17:37:18 +00:00
Marcel Molina
971ed15360 Document API for exists?'s parameter and provide examples of usage. Closes #7913 [fearoffish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8297 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 17:35:17 +00:00
Marcel Molina
a23bea7c0d Document API for create's attributes parameter and provide examples. Closes #7915 [fearoffish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8296 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 17:33:18 +00:00
Marcel Molina
a7e6e009c9 Documentation for find incorrectly omits the :conditions option from various examples. Closes #7923 [mattwestcott] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8295 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 17:29:27 +00:00
Marcel Molina
1b7a18dec8 Document options and add examples for update. Closes #7985 [fearoffish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8293 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 15:17:34 +00:00
Marcel Molina
6a45e01b32 Document options and add examples for delete. Closes #7986 [fearoffish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8292 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 15:15:56 +00:00
Marcel Molina
ed69b38afa Document options and add examples for destroy. Closes #7988 [fearoffish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8291 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 15:14:40 +00:00
Marcel Molina
4f1d353b18 Document options and add examples for update_all. Closes #7990 [fearoffish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8290 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 15:13:10 +00:00
Marcel Molina
6bd7d30e75 Document options for update_counters. Closes #8091 [fearoffish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 15:06:45 +00:00
Marcel Molina
8c2177c49d Add documentation for freeze and readonly related methods. Closes #8878 [pelargir, jeremymcanally] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8286 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 14:55:54 +00:00
Marcel Molina
d64832c040 Give examples for what tables should be called for models inside a module namespace. Closes #10288 [scott_willson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8282 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 14:28:05 +00:00
Marcel Molina
e4d845ef54 Document automatically generated predicate methods for attributes. Closes #10373 [chuyeow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8280 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 14:22:26 +00:00
David Heinemeier Hansson
326548770d Copy the cache too 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-03 02:22:06 +00:00
David Heinemeier Hansson
e6f54290af Added ActiveRecord::Base#becomes to turn a record into one of another class (mostly relevant for STIs) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-03 02:01:21 +00:00
Jeremy Kemper
3a3e7efee9 attr_protected and _accessible use sets of strings instead of arrays of symbols internally. Closes #10300. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8231 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-28 20:13:17 +00:00
Jeremy Kemper
a33007d31a attr_readonly uses a set of strings instead of an array of symbols internally. References #10300. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-28 20:12:49 +00:00
David Heinemeier Hansson
b318134c99 Kill the whiny_protected_attributes setting and kill the exception raised. Instead, just log the mass-assignment misalignment as a debug warning (closes #9966) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-09 19:57:24 +00:00
Marcel Molina
7143d80147 Smattering of grammatical fixes to documentation. Closes #10083 [BobSilva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-08 03:37:16 +00:00
David Heinemeier Hansson
37adea6ff1 Address shortcomings of changeset [8054] [protocool] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-07 15:07:39 +00:00
Marcel Molina
f770b829f4 Enhance explanation with more examples for attr_accessible macro. Closes #8095 [fearoffish, Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8107 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-06 23:50:23 +00:00
Jeremy Kemper
bef071dd0b Introduce finder :joins with associations. Same :include syntax but with inner rather than outer joins. Closes #10012. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-29 21:39:52 +00:00
Marcel Molina
d761ac4095 Add docs explaining how to protect all attributes using attr_accessible with no arguments. Closes #9631 [boone, rmm5t] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8032 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 04:07:39 +00:00
Marcel Molina
8b2a6014a2 Use VALID_FIND_OPTIONS when resolving :find scoping rather than hard coding the list of valid find options. Closes #9443 [sur] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8025 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 03:20:14 +00:00
Jeremy Kemper
f575757ca4 Qualified column names work in hash conditions, like :conditions => { 'comments.created_at' => ... }. Closes #9733. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 08:08:08 +00:00
Jeremy Kemper
9b6207c3d0 Quote table names. Defaults to column quoting. Closes #4593. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7932 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:06:33 +00:00
Jeremy Kemper
9f5a9aa35f Factor out checks for duplicable objects. Closes #9333. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7908 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 07:13:40 +00:00
Tobias Lütke
0ad5365bf4 find_and_(initialize|create)_by methods can now properly initialize protected attributes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-10 19:11:50 +00:00
Michael Koziarski
3122d321fd Make sure AR::Base#clone handles attr changes made in after_initialize hooks. Closes #7191 [weyus] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-08 06:21:38 +00:00
Jeremy Kemper
84a14f2620 Raise ProtectedAttributeAssignmentError in development and test environments when mass-assigning to an attr_protected attribute. Closes #9699. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-07 19:43:19 +00:00
Michael Koziarski
638505b90f Send the correct INSERT statement when dealing with objects with only primary keys. Closes #9523 [tarmo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7753 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-06 00:49:58 +00:00
Rick Olson
5b2e8b1eb1 Fix that ActiveRecord would create attribute methods and override custom attribute getters if the method is also defined in Kernel.methods. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-06 00:25:07 +00:00
Michael Koziarski
b4ec9904c6 Cache the descends_from_activerecord? call to speed up query generation. [skaes] Closes #9765 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7723 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-03 05:31:36 +00:00
Rick Olson
66d05f5e2c Add attr_readonly to specify columns that are skipped during a normal ActiveRecord #save operation. Closes #6896 [dcmanges] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7693 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-30 07:09:44 +00:00
David Heinemeier Hansson
e3b49c052b Fixed spelling errors (closes #9706) [tarmo/rmm5t] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7666 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-28 14:18:47 +00:00
David Heinemeier Hansson
286bd9b9f0 Docfix (closes #8767) [kampers] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7561 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 18:17:53 +00:00
Tobias Lütke
4a1388adea Define dynamic finders as real methods after first usage. Close #9317 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-18 10:04:11 +00:00
Jeremy Kemper
7495b5ca75 Deprecation: remove deprecated threaded_connections methods. Use allow_concurrency instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-18 06:43:05 +00:00
Jeremy Kemper
e6941149ab Deprecation: removed Reloadable. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-14 00:25:59 +00:00
Jeremy Kemper
54a6ed1482 minor speedups + forward-compat syntax 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7471 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-13 23:13:34 +00:00
Jeremy Kemper
f9ba8566b5 minor speedup 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7469 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-13 08:20:08 +00:00
Jeremy Kemper
55efae2387 Performance: absorb instantiate and initialize_with_callbacks into the Base methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-31 01:56:39 +00:00
David Heinemeier Hansson
3566be4728 Fixed that eager loading queries and with_scope should respect the :group option [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-21 21:58:38 +00:00
Michael Koziarski
5b801b5960 Change the implementation of ActiveRecord's attribute reader and writer methods: 
* Generate Reader and Writer methods which cache attribute values in hashes.  This is to avoid repeatedly parsing the same date or integer columns.
 * Move the attribute related methods out to attribute_methods.rb to de-clutter base.rb
 * Change exception raised when users use find with :select then try to access a skipped column.  Plugins could override missing_attribute() to lazily load the columns.
 * Move method definition to the class, instead of the instance
 * Always generate the readers, writers and predicate methods.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-14 08:53:02 +00:00
Michael Koziarski
bb94ce92fc Let inspect on AR classes work when the table doesn't exist. Closes #9194 [tarmo, nzkoz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-06 00:18:50 +00:00
Michael Koziarski
c4c6662498 Performance enhancement for Base.exists?. CLoses #8769. [hasmanyjosh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-05 00:57:43 +00:00