github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-08 21:25:19 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,995 Commits 34 Branches 105 Tags
94725b02bcc5e623dcbe1d73d57b2ede2c88440e
Commit Graph

1031 Commits

Author SHA1 Message Date
David Heinemeier Hansson
3fb29b172f Fixed that default image extension was not appended when using a full URL with AssetTagHelper#image_tag (closes #4032, #3728) [rubyonrails@beautifulpixel.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 01:54:53 +00:00
David Heinemeier Hansson
3574ab3059 Added that page caching will only happen if the response code is less than 400 (closes #4033) [g.bucher@teti.ch] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3738 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 01:48:56 +00:00
Jamis Buck
8368b5960b restore elided TestProcess#assigns method 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3725 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 19:40:37 +00:00
Jamis Buck
abeb77b286 Make TestProcess methods public for access via Integration::Session. Make return values from some of the Integration::Session methods sane. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3724 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 16:37:11 +00:00
Jamis Buck
9507f5dcc9 Add ActionController::IntegrationTest to allow high-level testing of the way the controllers and routes all work together 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3701 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-28 18:15:46 +00:00
David Heinemeier Hansson
fed41fbe8b Added support to AssetTagHelper#javascript_include_tag for having :defaults appear anywhere in the list, so you can now make one call ala javascript_include_tag(:defaults, "my_scripts") or javascript_include_tag("my_scripts", :defaults) depending on how you want the load order (closes #3506) [Bob Silva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3696 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-28 05:16:34 +00:00
Thomas Fuchs
d0bd952aff Added support for visual effects scoped queues to the visual_effect helper #3530 [Abdur-Rahman Advany] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-27 10:37:59 +00:00
David Heinemeier Hansson
3d1b51b441 Added .rxml (and any non-rhtml template, really) supportfor CaptureHelper#content_for and CaptureHelper#capture #3287 [Brian Takita] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 19:47:50 +00:00
Nicholas Seckar
26eaf073c4 Remove ::Controllers related cruft; fix AP tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3668 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 17:49:09 +00:00
Thomas Fuchs
d11f8d5516 Added script.aculo.us drag and drop helpers to RJS [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3667 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 14:20:21 +00:00
David Heinemeier Hansson
6a83ebfe70 Fixed form_for regression (closes #3962) [t.lucas@toolmantim.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3666 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 07:23:42 +00:00
David Heinemeier Hansson
d94af9a61f mail_to shouldnt include language attribute in script tag #3364 [donald.piret@synergetek.be] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3662 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 01:10:05 +00:00
David Heinemeier Hansson
231a464d4e Fixed that form elements would strip the trailing [] from the first parameter (closes #3545) [ruby@bobsilva.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 01:07:05 +00:00
David Heinemeier Hansson
06dd7b8efa The image_tag helper is not converting the options hash to symbols (closes #3615) [agkr@pobox.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3660 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 00:55:22 +00:00
Nicholas Seckar
de54db3c1e Check NameErrors and re-raise if they do not match the expected constant 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-22 17:29:22 +00:00
Thomas Fuchs
bb7408fd4c Update script.aculo.us to V1.5.3 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3634 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-22 09:59:22 +00:00
Thomas Fuchs
523d54b56d Added various InPlaceEditor options, #3746, #3891, #3896, #3906 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-21 10:52:35 +00:00
David Heinemeier Hansson
e875b0db47 Fixed that the request method would be sticky in tests (closes #3849) [lars@pinds.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-20 23:49:43 +00:00
David Heinemeier Hansson
377bdd02b9 Added :count option to pagination that'll make it possible for the ActiveRecord::Base.count call to using something else than * for the count. Especially important for count queries using DISTINCT #3839 [skaes]. Added :select option to Base.count that'll allow you to select something else than * to be counted on. Especially important for count queries using DISTINCT (closes #3839) [skaes]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3620 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-20 03:15:22 +00:00
David Heinemeier Hansson
8896efd41a Ensure backwards compatibility with symbolized action names for render_action (closes #3869) [anna@wota.jp] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3606 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-19 00:46:34 +00:00
David Heinemeier Hansson
1812dbbfde Make RJS treat symbolic action names nicely #3861 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-17 18:32:21 +00:00
Thomas Fuchs
e8c4cc9503 Update script.aculo.us in Rails trunk to V1.5.2 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-14 10:29:12 +00:00
David Heinemeier Hansson
c7f5a848f1 Refactor the Javascript proxy into a hierarchy for element/collection [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-14 04:39:44 +00:00
David Heinemeier Hansson
35b74de770 Use real assigns instead of a method call [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 21:31:28 +00:00
David Heinemeier Hansson
5f2292ce39 replace_element was renamed replace [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3590 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 21:19:49 +00:00
David Heinemeier Hansson
022a8fc681 Wups, committed too much 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3589 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 20:21:01 +00:00
David Heinemeier Hansson
8dc4f46233 Also support replace and replace_html and some refactoring in JavaScriptElementProxy [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 20:10:59 +00:00
David Heinemeier Hansson
ebdb766e79 Added element and collection proxies to RJS [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 18:48:08 +00:00
David Heinemeier Hansson
db2023d4d2 The session should be saved even if the filter chain is stopped 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3584 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 16:35:15 +00:00
David Heinemeier Hansson
431edf7793 Fixed that flash wasnt being cleared after components refactoring yesterday 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3582 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 16:18:06 +00:00
David Heinemeier Hansson
ff986f19af Flash shouldnt depend on components either [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3581 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 06:11:17 +00:00
David Heinemeier Hansson
050c3964d8 Stopped the massive bleeding of concerns into ActionController::Base. Base no longer knows about flash, filters, or components. This may well have introduced some instability, please do test with apps, especially the ones using components. [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 05:51:02 +00:00
Sam Stephenson
838ec413eb Add JavaScriptGenerator#replace_element for replacing an element's "outer HTML". Closes #3246. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3579 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 01:30:13 +00:00
David Heinemeier Hansson
e90bbbdd83 Add caution and restyle components 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3577 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 01:06:45 +00:00
David Heinemeier Hansson
137794310b The components module should also contain the options that pertain to it, so collect it all with ClassMethods and InstanceMethods 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3576 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 00:46:01 +00:00
Nicholas Seckar
324e5eb571 Fix form_for brokenness due to a shortage of parenthesis 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3575 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 00:41:50 +00:00
David Heinemeier Hansson
a8a1d11d77 Expose object and object_name from the FormBuilder [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3574 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 00:28:45 +00:00
David Heinemeier Hansson
a04a849d15 Clean up style around form_for and friends a bit 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3573 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 00:22:24 +00:00
Nicholas Seckar
344ae8326a Remove over-engineered form_for code for a leaner implementation. 
Document form_for's :html option.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-11 23:29:53 +00:00
Jeremy Kemper
7654082260 Major components cleanup and speedup. Closes #3527. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 20:05:11 +00:00
Michael Koziarski
d49a5fcb4c * Fix pagination problems when using include 
* Introduce Unit Tests for pagination
* Allow count to work with :include by using count distinct.

[Kevin Clark & Jeremy Hopple]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 09:17:40 +00:00
Sam Stephenson
803b9a41af Add :html option for specifying form tag options in form_for 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3552 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 20:46:15 +00:00
Marcel Molina
73ed47ddec Replace dubious controller parent class in filter docs. Closes #3655, #3722. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 05:24:53 +00:00
Marcel Molina
ba2619f539 Don't interpret the :value option on text_area as an html attribute. Set the text_area's value. Closes #3752. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 05:13:21 +00:00
Nicholas Seckar
7139e2a0e1 Fix remote_form_for creates a non-ajax form. Closes #3741. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3545 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-06 05:06:36 +00:00
David Heinemeier Hansson
0633bb865b Update versions to match latest from stable 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-05 00:59:57 +00:00
Nicholas Seckar
5450538563 Don't let arbitrary classes match as controllers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:59:37 +00:00
Nicholas Seckar
b381d8511d Fix Routing tests. Fix routing where failing to match a controller would prevent the rest of routes from being attempted. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:09:26 +00:00
Tobias Lütke
28cee08fa4 fixed small bug in routing which caused the traverse_to_controller mechanism to drop out on 
Multi::Nested::Controllers


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3538 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 22:04:19 +00:00
Nicholas Seckar
9474fe72dd Add :builder => option to form_for and friends. Closes 3268. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3536 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 19:58:45 +00:00