Commit Graph

2361 Commits

Author SHA1 Message Date
Xavier Noria
94de5b8cb5 edit pass in #define_callbacks rdoc 2010-06-14 22:52:47 +02:00
Neeraj Singh
e4c8bc1b34 adding to the :kind documentation for ActiveSupport callbacks 2010-06-14 16:18:29 -04:00
Neeraj Singh
ed9a183ea4 clearer documentation of how scope applies to ActiveSupport callbacks 2010-06-14 15:48:09 -04:00
Xavier Noria
50df162a2b explains why AS::OrderedHash does not leverage inheritance 2010-06-13 22:02:29 +02:00
Santiago Pastorino
b514b4d696 removes spurious .rb in require
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-13 13:56:08 +02:00
Santiago Pastorino
6d19a4a664 Change implementation to do it without asking each time for block_given?
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-13 07:27:26 +02:00
Xavier Noria
36143d26cb revises implementation of AS::OrderedHash#merge! 2010-06-13 06:37:54 +02:00
Xavier Noria
3359af63a5 Revert "hash merging with a block ignores non-existing keys altogether"
This reverts commit 72f9fec607.

It is wrong, this feature is a little undocumented, doing some research.
2010-06-13 05:53:42 +02:00
Xavier Noria
72f9fec607 hash merging with a block ignores non-existing keys altogether 2010-06-13 05:09:31 +02:00
Paul Barry
9183eaebed re-organized test for merge into separate tests
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-13 04:19:35 +02:00
Paul Mucur
58e21a4a0d Support passing a block to ActiveSupport::OrderedHash's merge and merge! [#4838 state:committed]
For better consistency with Ruby's own Hash implementation.

Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-13 04:19:35 +02:00
Santiago Pastorino
f802eb2f00 require conversions to use String#ord 2010-06-12 18:47:37 -07:00
Xavier Noria
f28d5cfbe6 registers 4146a44 in CHANGELOG 2010-06-12 22:16:57 +02:00
José Valim
1eecd9483b No need to call convert_key before except. 2010-06-12 09:54:18 +02:00
José Valim
50ec0d9b2e Simplify and optimize callbacks superclass sync. 2010-06-12 09:54:18 +02:00
Geoff Buesing
4146a443b6 Date#since, #ago, #beginning_of_day, #end_of_day, #xmlschema return TimeWithZone when Time.zone_default is set
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-06-12 00:19:12 +02:00
Jeremy Kemper
ed61c3b640 Remove String#constantize deps 2010-06-11 10:33:43 -07:00
Jeremy Kemper
cfc9439454 Explicitly delegate Chars#<=> to work around Kernel#<=> possibly ignoring method_missing 2010-06-11 10:03:23 -07:00
David Heinemeier Hansson
32d4330b81 Get ready for beta 4 2010-06-08 14:47:02 -04:00
wycats
6b49a71ab7 Missing require restored 2010-06-08 14:24:35 -04:00
wycats
068f8d6e85 Require encoding.rb 2010-06-08 14:09:34 -04:00
wycats
8d576b51a1 Move the undef into the 1.9 only branch 2010-06-07 23:32:20 -04:00
wycats
b97a3f33a3 Merge remote branch 'rsim/oracle_enhanced_rails3' 2010-06-07 23:03:59 -04:00
wycats
0042f4166f If we undef <=>, it solves a problem involving comparison. Please figure out the root cause. 2010-06-07 22:31:42 -04:00
Rizwan Reza
3adb395da4 Fixed Load Error failures in 1.9.2-head 2010-06-07 14:53:37 -04:00
Xavier Noria
8c7730db02 oops, two cancelling errors made a previous test pass, fixing it 2010-06-07 07:27:51 +02:00
Xavier Noria
d96efe6368 the order in which we apply deltas in Date#advance matters, add test coverage for that 2010-06-07 06:59:09 +02:00
Jeremy Kemper
9d0d6f7d26 Clear const references all at once 2010-06-05 22:08:02 -07:00
Jeremy Kemper
fd1a504136 ActiveSupport::Dependencies.constantize shortcut for caching named constant lookups 2010-06-05 22:05:58 -07:00
wycats
a6b3942843 Optimize LookupContext 2010-06-04 20:11:06 -07:00
wycats
16ee4b4d1b Small optimization of 1.9 unescape. We should make sure that inbound ASCII always means UTF-8. It seems so based on a quick survey of common browsers, but let's be sure 2010-06-04 20:11:06 -07:00
wycats
8b05c5207d Improve performance of MessageVerifier while keeping it constant time 2010-06-04 20:11:05 -07:00
wycats
220603ee70 Eliminate the need to check for superclass changes to the callback stack each time through the callbacks 2010-06-04 20:11:05 -07:00
Xavier Noria
67a43554f1 removes Array#random_element and backports Array#sample from Ruby 1.9, thanks to Marc-Andre Lafortune 2010-06-05 01:15:17 +02:00
Raimonds Simanovskis
5fcaf91761 fix conditions when DateTime#to_date and DateTime#xmlschema methods are defined 2010-06-04 22:44:03 +03:00
David Heinemeier Hansson
942fe6514c Merge branch 'master' of github.com:rails/rails 2010-06-02 16:18:03 -05:00
David Heinemeier Hansson
02512914ae You need the ruby-debug available in your Gemfile for debugger to work 2010-06-02 16:17:05 -05:00
Xavier Noria
315e8952df revises the documentation of String#truncate and the truncate helper 2010-06-02 01:35:04 +02:00
David Heinemeier Hansson
cae2519900 Merge branch 'master' of github.com:rails/rails 2010-06-01 16:39:05 -05:00
David Heinemeier Hansson
d57397c4b6 Extracted String#truncate from TextHelper#truncate [DHH] 2010-06-01 16:38:42 -05:00
Santiago Pastorino
57144388f0 Unforce memcache from AS
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-01 10:46:05 +02:00
Santiago Pastorino
31e1445a81 Unforce builder from AS
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-01 10:45:51 +02:00
Santiago Pastorino
0bed93be25 Unforce tzinfo from AS
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-01 09:16:19 +02:00
Santiago Pastorino
1854209bb3 Unforce i18n from AS
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-31 12:56:25 +02:00
José Valim
f1ae0321fa Use I18n 0.4.0 2010-05-27 23:50:34 +02:00
Xavier Noria
ddec74fb3a Merge remote branch 'rails/master' 2010-05-27 10:57:05 +02:00
jacortinas
6602fb62a0 A small rdoc change made on lines 39 and 41 on activesupport/lib/active_support/core_ext/object/to_param.rb. It looks like the method name might have been changed, and the comments were never changed to coincide with the new method name. 2010-05-25 19:09:11 +10:00
Santiago Pastorino
78fffac668 Fix test incorrectly using a bare assert to use assert_kind_of
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-05-24 20:59:53 -07:00
José Valim
8d5939c096 Fix a bug where I18n fallbacks modules where not included in the proper backend if it was set through config.i18n.backend. 2010-05-23 13:22:19 +02:00
Norman Clarke
f3abc8ac36 Use multibyte proxy class on 1.9, refactor Unicode.
Makes String#mb_chars on Ruby 1.9 return an instance of ActiveSupport::Multibyte::Chars to work around 1.9's lack of Unicode case folding.

Refactors class methods from ActiveSupport::Multibyte::Chars into new Unicode module, adding other related functionality for consistency.

[#4594 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-05-21 12:24:54 -07:00