github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-29 08:18:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,701 Commits 34 Branches 105 Tags
96536bebaefccabcbfb5ce9e689dd40c4fb4e294
Commit Graph

569 Commits

Author SHA1 Message Date
Tobias Lütke
af60120d30 cosmetic change to assert_valid 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3341 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-23 19:47:10 +00:00
Tobias Lütke
373bc86d2d only log session_id if @session object responds to .session_id. 
In functional test cases you often pass in a hash as session object which doesn't have this method. 


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3339 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-22 21:16:11 +00:00
David Heinemeier Hansson
778d6704d4 Add session ID to default logging, but remove the verbose description of every step [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-22 04:04:56 +00:00
Marcel Molina
233208b8bb Don't try to strip out the controller name if default_action_name is nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-20 05:32:39 +00:00
Marcel Molina
39766a9b4c Don't include a layout when rendering an rjs template using render's :template option. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-17 06:38:06 +00:00
Jeremy Kemper
eecbd106a7 Don't used defined? on a scoped constant since it results in a const_missing call. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-13 18:05:31 +00:00
David Heinemeier Hansson
32b27f997b Remove insignificant classes from docs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-08 05:43:54 +00:00
Jeremy Kemper
c140e80fc4 More robust relative url root discovery for SCGI compatibility. This solves the 'SCGI routes problem' -- you no longer need to prefix all your routes with the name of the SCGI mountpoint. References #3070. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-08 04:40:24 +00:00
David Heinemeier Hansson
c7bdd00b86 Fixed RDoc warnings [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-08 03:23:31 +00:00
Jeremy Kemper
202e4208c4 Correct spelling of persistent [Stefan Kaes]. Document and eliminate warnings in clear_persistent_model_associations. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3166 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-23 00:35:37 +00:00
Nicholas Seckar
bd5ace88b2 Initialize @optional in routing code to avoid warnings 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-22 22:24:25 +00:00
Sam Stephenson
bea737eb5a Make ActionController's render honor the :locals option when rendering a :file. Closes #1665. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-22 08:37:04 +00:00
Jamis Buck
f783d50cf8 Allow assert_tag(:conditions) to match the empty string when a tag has no children. Closes #2959. [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 21:02:10 +00:00
Jamis Buck
f9b199040c Update html-scanner to handle CDATA sections better. Closes #2970. [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 20:43:35 +00:00
Jeremy Kemper
6580662254 Don't put flash in session if sessions are disabled. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 18:09:28 +00:00
David Heinemeier Hansson
d345b7a4f0 Back out of 3109 for now as it seems to interfere with the flash 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 16:59:25 +00:00
Sam Stephenson
ede2a222ee Strip out trailing &_= for raw post bodies #2868 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3137 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 08:04:28 +00:00
Jeremy Kemper
e9b26c52a2 Fix grammar error in [3115]. References #2966. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3117 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 02:14:31 +00:00
Jeremy Kemper
a0293c80f0 Improve expire_fragment documentation. Closes #2966. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 01:08:30 +00:00
Marcel Molina
55a3979a09 Correct docs for automatic layout assignment. Closes #2610. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 18:50:09 +00:00
Jeremy Kemper
da9f713d2c r3209@asus: jeremy | 2005-11-20 01:04:22 -0800 
If sessions are disabled, return a hash that raises an error when it's accessed.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 09:06:43 +00:00
Jeremy Kemper
63b792162b Make data writer private. Marshal/unmarshal handle nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 08:15:51 +00:00
Jeremy Kemper
c7bc10b2e4 Log ActiveRecordStore debugging. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3107 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 08:07:33 +00:00
Jeremy Kemper
991189b58d Document request.env and request.host. Strip trailing whitespace. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 05:31:33 +00:00
Jeremy Kemper
cd8686b456 r3173@asus: jeremy | 2005-11-18 23:34:41 -0800 
Ticket 2731 - sessions
 r3185@asus:  jeremy | 2005-11-19 18:02:51 -0800
 eliminate const redefinition warning
 r3186@asus:  jeremy | 2005-11-19 19:25:50 -0800
 Use :database option instead of :dbfile
 r3187@asus:  jeremy | 2005-11-19 19:34:31 -0800
 Data writer assigns to instance var.  Since nothing is calling write_attribute on the data column except for marshal_data, simplify data reader to lazy-unmarshal the data column (no worrying whether it's already unmarshaled)
 r3188@asus:  jeremy | 2005-11-19 19:35:40 -0800
 Explicitly create the session class so that subsequent requests for the session can find it in the database.  This is masking a problem with the controller losing its @session instance var and therefore requesting a new session.
 r3189@asus:  jeremy | 2005-11-19 19:36:40 -0800
 Using create unnecessarily  broadens the existing duck-typing so use new + save instead.
 r3194@asus:  jeremy | 2005-11-19 20:28:17 -0800
 Test creation of another instance while first instance is still active.  Should return same session_id.
 r3195@asus:  jeremy | 2005-11-19 20:39:45 -0800
 Always create new AR sessions rather than trying too hard to avoid database traffic.  References #2731.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 04:41:59 +00:00
Marcel Molina
62fe5bbfb1 Make rjs templates always implicitly skip out on layouts. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 08:32:17 +00:00
Jeremy Kemper
9de738aadc Remove the unused, slow response_dump and session_dump variables from error pages. References #1222. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 21:34:24 +00:00
Jeremy Kemper
ba942dfc45 fewer objects, no loop in convert_content_type. Closes #2883. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 09:05:04 +00:00
Jeremy Kemper
745ea39926 MemCache store may be given multiple addresses. Closes #2869. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 08:35:31 +00:00
Jeremy Kemper
08fd13d17c Handle cookie parsing irregularity for certain Nokia phones. Closes #2530. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-15 07:51:09 +00:00
Tobias Lütke
037f61c8e9 * Updated docs for in_place_editor, fixes a couple bugs and offers extended support for external controls [Justin Palmer] closes #2870 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3032 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-14 20:46:32 +00:00
Jeremy Kemper
5cd2f32697 Update documentation for render :file. References #2858. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3015 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-14 00:12:46 +00:00
Jeremy Kemper
da2d4d6d57 Note that the ruby-memcache bindings are required to use the memcache store. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-14 00:08:24 +00:00
Scott Barron
339fff7950 This does not need to be thread local (thanks skaes). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 12:59:22 +00:00
Jeremy Kemper
3661eacfbd Include all of session creation in stale_session_check 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 20:34:44 +00:00
Jamis Buck
b7ce9c5a87 assert_tag uses exact matches for string conditions, instead of partial matches. Use regex to do partial matches. #2799 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 13:42:05 +00:00
Jeremy Kemper
bb4c32e2b5 Delete existing sessions with the same session id before creating a new session. Prevents duplication and hijacking. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 06:00:46 +00:00
Jeremy Kemper
0abaf3a2d8 CGI::Session::ActiveRecordStore.data_column_name = 'foobar' to use a different session data column than the 'data' default. References #2731. Remove error-prone method_missing passthrough to session model. Cleanup. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 01:03:24 +00:00
Jeremy Kemper
85baf07be8 Controllers with acronyms in their names (e.g. PDFController) require the correct default helper (PDFHelper in file pdf_helper.rb). Closes #2262. Do not raise an exception when default helper is missing; log a debug message instead. It's nice to delete empty helpers. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 08:23:13 +00:00
David Heinemeier Hansson
01cfd2b00a Fix docs (closes #2725) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:36:43 +00:00
David Heinemeier Hansson
8dda7c5449 Fix conflict with assert_tag and Glue gem (closes #2255) [david.felstead@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:31:49 +00:00
Jamis Buck
0073a759f1 Add documentation to assert_tag indicating that it only works with well-formed XHTML 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 13:59:07 +00:00
Jeremy Kemper
ad4e611488 Update paginator docs. Closes #2744. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-05 02:10:29 +00:00
David Heinemeier Hansson
9d17e7cce4 Fix assert_no_tag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 21:37:34 +00:00
David Heinemeier Hansson
a6106e4ec6 Added skip_before_filter/skip_after_filter for easier control of the filter chain in inheritance hierachies [DHH] Added short-hand to assert_tag so assert_tag :tag => "span" can be written as assert_tag "span" [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2873 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 19:42:22 +00:00
David Heinemeier Hansson
4f754985d0 Added redirect_to :back as a short-hand for redirect_to(request.env["HTTP_REFERER"]) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-02 14:47:03 +00:00
Jeremy Kemper
ddf6910941 ensure close_session in AC::Base#process 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2842 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-02 01:23:34 +00:00
Scott Barron
025949102e Fix problem where redirecting components can cause an 
infinite loop [Rick Olson]

Closes #2654


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2829 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-30 13:13:02 +00:00
Jeremy Kemper
54a4e50662 Removed erroneous arg-size check in AC::Base.fragment_cache_store=. Closes #2650. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-29 23:12:13 +00:00
David Heinemeier Hansson
cb0e27cee9 Fix that render :text didn't interpolate instance variables (Closes #2629, #2626) [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 07:33:54 +00:00