Commit Graph

66 Commits

Author SHA1 Message Date
Nicholas Seckar
bd5ace88b2 Initialize @optional in routing code to avoid warnings
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-22 22:24:25 +00:00
David Heinemeier Hansson
620726f844 Add "#:nodoc:" for ActionController::Routing::PathComponent::Result #2209 [l.francke@gmx.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-17 06:37:50 +00:00
Nicholas Seckar
27962ead03 Add ability to specify Route Regexps for controllers. Closes #1917.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 13:56:43 +00:00
Nicholas Seckar
9e5d64b3bb Provide Named Route's hash methods as helper methods. Closes #1744.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 13:45:55 +00:00
Nicholas Seckar
1cbd1f9698 Fix routing to handle :some_param => nil better
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-26 10:57:43 +00:00
Nicholas Seckar
741316dc71 Fixed construction of get parameters for arrays
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-18 03:12:45 +00:00
Nicholas Seckar
bf0b7588ee Add RouteSet#named_route so that RouteSet instance methods do not shadow available route names
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1834 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 10:32:37 +00:00
Nicholas Seckar
6ed16ff602 Provide correct defaults for Named Routes which do not specify :action
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 09:09:39 +00:00
Nicholas Seckar
2bd4ff11f8 Generate URLs for :action => index when :action => nil is supplied.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 00:13:06 +00:00
Nicholas Seckar
9314793239 Named routes should not provide nil values to url_for. Includes factoring and extra testcases.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-13 23:13:15 +00:00
Nicholas Seckar
c18961f185 Routes now raise an exception if a path component is misconfigured.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:56:24 +00:00
Nicholas Seckar
4a3ec21b62 Fix routes to generate proper URLs when given Fixnum defaults
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:45:51 +00:00
Nicholas Seckar
3c4295c4e0 Allow RouteSet#recognition_failed to be used to handle unknown URL forwarding
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 21:20:59 +00:00
Nicholas Seckar
f4bfacb24f Enable routes to recognize uppercase controller names. Closes #1635
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:51:20 +00:00
Nicholas Seckar
5727dc2f42 Properly unescape recognized path components. Fixes #1651.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:43:03 +00:00
David Heinemeier Hansson
75157bbf64 Fixed that named routes didn't use the default values for action and possible other parameters #1534 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:16:05 +00:00
David Heinemeier Hansson
212cc3845a Fixed routing snafu
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 10:45:14 +00:00
David Heinemeier Hansson
853ea55674 Made documentation ready for release (AP)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 09:32:00 +00:00
David Heinemeier Hansson
4fe0248f57 Fixed routing regression on index exception
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 15:31:51 +00:00
Jamis Buck
3b1d271e02 Routing fix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1712 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 15:06:09 +00:00
David Heinemeier Hansson
74961dbbe9 Backed out of #1694 as it broke requests that hit the cache with wrong argument type nil (expected Module) on WEBrick
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 09:45:30 +00:00
David Heinemeier Hansson
26ccf4cb53 Fixed recognize bug introduced with #1694
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1704 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 09:38:20 +00:00
Jeremy Kemper
9933ec82b2 r2840@asus: jeremy | 2005-07-05 00:42:27 -0700
Ticket 1233 - Cache recognized routes
 r2842@asus:  jeremy | 2005-07-05 00:53:16 -0700
 update changelog
 r2843@asus:  jeremy | 2005-07-05 00:54:11 -0700
 cache recognized routes.  clear cache with clear_recognized_routes_cache\!


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 02:46:49 +00:00
David Heinemeier Hansson
5524dedc06 Fixed routing bug #1592
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1645 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 12:01:06 +00:00
David Heinemeier Hansson
8335fc610c A bit more routes refactoring and test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 10:40:26 +00:00
Jamis Buck
453ed15395 Routes fail with leading slash #1540 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1555 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 21:18:04 +00:00
David Heinemeier Hansson
5136c2a16b Badly applied patch fix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1554 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 17:54:19 +00:00
David Heinemeier Hansson
96e590ca3c This patch modifies RouteSet#write_generation and RouteSet#write_recognition so that they return the source code used to recognize or generate URLs. #1531 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 17:17:39 +00:00
David Heinemeier Hansson
b8689c77a4 Don't ignore :controller for urls made inside a controller module #1526 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 15:17:59 +00:00
David Heinemeier Hansson
a7116b6534 Make named routes work without hashes #1523 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 14:32:19 +00:00
David Heinemeier Hansson
ef8bd07f5e Fixed routing bug
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 10:38:51 +00:00
David Heinemeier Hansson
c19b74d9a6 Dont use evals in backtraces #1513
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 05:27:35 +00:00
David Heinemeier Hansson
ee4c834ed2 Added testing of named routes #1506 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 05:23:41 +00:00
Jamis Buck
c6ea1d360c RoutingError should show 404.html when in public #1503 [Ulysses]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1513 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 19:05:44 +00:00
Jeremy Kemper
28012e68fe Fix routes generation for unit tests. #1434
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 17:48:14 +00:00
David Heinemeier Hansson
8e56f5ea3e Improved performance of Routes generation by a factor of 5 #1434 [Nicholas Seckar] Added named routes (NEEDS BETTER DESCRIPTION) #1434 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1496 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 16:40:01 +00:00
David Heinemeier Hansson
7f558cbd05 Fixed that *rest parameter in map.connect couldn't accept an empty list #1037 [Dee.Zsombor@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:35:51 +00:00
David Heinemeier Hansson
87bed3af47 Fixed that in some circumstances controllers outside of modules may have hidden ones inside modules. For example, admin/content might have been hidden by /content. #1075 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:01:35 +00:00
David Heinemeier Hansson
3697df1dd2 Improved error reporting especially around never shallowing exceptions. Debugging helpers should be much easier now #980 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-23 11:48:10 +00:00
David Heinemeier Hansson
daaa5251c9 Fixed documentation and prepared for 0.11.0 release
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-22 13:09:44 +00:00
David Heinemeier Hansson
b88fa4d1df Routes: *path items should use arrays #883
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@954 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-21 00:40:51 +00:00
David Heinemeier Hansson
0919dbf6b6 Routes: Convert results of #to_param to strings #879
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 22:44:12 +00:00
David Heinemeier Hansson
7e745f3aa5 Added to_param call for parameters when composing an url using url_for from something else than strings #812 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 15:42:40 +00:00
David Heinemeier Hansson
37a46151ec Added path collection syntax for Routes that will gobble up the rest of the url and pass it on to the controller #830 [rayners]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@927 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 14:04:33 +00:00
David Heinemeier Hansson
620d3a3749 Fixed that the routes.rb file wouldn't be found on symlinked setups due to File.expand_path #793 [piotr@t-p-l.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@870 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 23:55:07 +00:00
David Heinemeier Hansson
688f0f6712 Fixed that map.connect should convert arguments to strings #780 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@855 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 14:16:25 +00:00
David Heinemeier Hansson
654370d9ad Fixed that RAILS_ROOT might not be defined when AP was loaded, so do a late initialization of the ROUTE_FILE #761 [Scott Barron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-02 00:03:11 +00:00
David Heinemeier Hansson
630638b00e Fixed that Routes would raise NameErrors if a controller component contains characters that are not valid constant names #733 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-27 17:12:35 +00:00
David Heinemeier Hansson
b7889524bf Fix empty url_for with nested modules #707
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 01:38:10 +00:00
David Heinemeier Hansson
74d5f6ec0c Fixed some docing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@781 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 01:37:12 +00:00