github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
19,730 Commits 34 Branches 105 Tags
96eec090dfd50326146b2f690408fefec50c5111
Commit Graph

3944 Commits

Author SHA1 Message Date
Michael Koziarski
96eec090df Work around a strange piece of Syck behaviour where it checks Model#respond_to? before initializing the object. 
Things like YAML.load(YAML.dump(@post)) won't work without this.
 2010-12-02 08:40:34 -08:00
Aaron Patterson
0afebd5b31 no need for self 2010-12-01 18:00:24 -08:00
Aaron Patterson
3ec212e3c9 rolling out migrated_at until I can fix the build 2010-12-01 17:08:01 -08:00
Josh Susser
a49de9811a tests mostly pass 
adjust to work with instance-based migations
migrated_at can't be null
why must people have last names? it's killing me!
 2010-12-01 12:01:56 -08:00
Josh Susser
b07c2c0fd3 clear schema_migrations in Schema.define 2010-12-01 11:01:15 -08:00
Josh Susser
7139aa878c name in schema_migrations, migrations in schema dump 2010-12-01 10:57:38 -08:00
Josh Susser
4e4e9ad48a record migration timestamp when migrations run 2010-12-01 10:46:29 -08:00
Josh Susser
c283cdd63c Add migrated_at column to schema_migrations table. 2010-12-01 10:46:29 -08:00
Aaron Patterson
542cb5c327 fix warnings, stop using global variables 2010-11-30 18:46:56 -08:00
Aaron Patterson
10b1887a71 JoinBase initialize can be deleted 2010-11-30 17:48:10 -08:00
Aaron Patterson
d51854a6be stop using splat args when we do not need them 2010-11-30 17:42:17 -08:00
Aaron Patterson
7408b6ec84 just grep the AST for OuterJoin nodes rather than converting the tree to SQL 2010-11-30 17:29:19 -08:00
Aaron Patterson
f1758525f9 reduce method calls on arel 2010-11-30 16:51:03 -08:00
Aaron Patterson
39f5fc06cb just call join_sql against the manager object 2010-11-30 16:42:21 -08:00
Aaron Patterson
fe522f79c7 we already know it is already an array, so we do not need to make really really sure it is an array 2010-11-30 15:53:04 -08:00
Aaron Patterson
ae6033331f shorten up scope_for_create 2010-11-30 15:48:15 -08:00
Aaron Patterson
7ff980031b scope_for_create always returns something 2010-11-30 15:39:49 -08:00
Aaron Patterson
dccf624b64 Ruby 1.8, how does it work? 2010-11-30 15:20:27 -08:00
Aaron Patterson
c856e25b32 removing arel 1.0 compatibility 2010-11-30 14:56:53 -08:00
Aaron Patterson
6c32290bac testing Relation#table_name 2010-11-30 14:29:35 -08:00
Aaron Patterson
8998aea4b7 making relationship merge cheaper 2010-11-30 13:31:00 -08:00
Aaron Patterson
b6848b6491 cleaning up where_values_hash 2010-11-30 12:05:02 -08:00
Aaron Patterson
aae3c35384 removing interpolate_sql from join associations 2010-11-29 10:58:21 -08:00
Aaron Patterson
439a7dc0e6 moving method to subclass that actually uses the method 2010-11-29 10:39:33 -08:00
José Valim
e444439fe2 Partialy revert f1c13b0dd7 2010-11-28 16:55:53 +01:00
Xavier Noria
9332cc582e removes a couple of redundant selfs 2010-11-26 00:35:23 +01:00
Santiago Pastorino
438c0188f8 nil check unneeded ht. exviva 2010-11-25 20:00:40 -02:00
Emilio Tagua
a3bd62e1ba Remove explicit return. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 17:35:24 -02:00
Emilio Tagua
c91a13f8f5 Use ternary instead explicit return. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 17:35:09 -02:00
Emilio Tagua
ac6e9447e5 Remove return, we are already returning self. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 17:33:38 -02:00
Emilio Tagua
1b6b80355c Remove explicit return. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 17:33:18 -02:00
Emilio Tagua
c4d31d0f13 Reuse lock_col variable instead calling locking_column class method. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 17:32:16 -02:00
raggi
d8692985fe Don't depend on rubygems loading thread (for Mutex) 2010-11-25 06:47:27 +08:00
Aaron Patterson
ee74f2c623 alias should be a SQL literal 2010-11-24 14:16:38 -08:00
Aaron Patterson
38eb01863c initialize instance variables in initialize... o_O 2010-11-24 14:11:12 -08:00
Aaron Patterson
34d21b87bb adding a factory method to the join part for generating a table alias 2010-11-24 13:55:56 -08:00
Aaron Patterson
cdf6cf01cb use ARel rather than generate SQL strings 2010-11-24 13:55:55 -08:00
Aaron Patterson
afe51afcc6 remove useless join 2010-11-24 13:55:55 -08:00
Aaron Patterson
d4b8d3bafa moving column_aliases to JoinDependency 2010-11-24 13:55:55 -08:00
Aaron Patterson
a3ba60fd81 reduce method calls 2010-11-24 13:54:08 -08:00
Neeraj Singh
66212f69ac If a nested_attribute is being marked for destruction and at the same time an attr_accessor value is being assigned then the value being assigned is being ignored. This patch is a fix for that issue. 
[#5939 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-24 22:08:36 +01:00
Franck Verrot
7f8ce38b0d Document the behavior of the dup method: does not preserve timestamps 2010-11-25 03:01:30 +08:00
Franck Verrot
7b77a1fc71 Typo in the comments of the clear_timestamp_attributes method 2010-11-25 03:01:30 +08:00
Franck Verrot
c17cb7326d Dup should reset the timestamps as it is considered a new record 2010-11-25 01:18:43 +08:00
Aaron Patterson
0687b21de8 removing ternary 2010-11-23 17:52:51 -08:00
Aaron Patterson
1aaa8edeb9 breaking classes up in to respective files 2010-11-23 17:42:49 -08:00
Aaron Patterson
8e8fb8a429 just wrap as a sql literal 2010-11-23 14:42:55 -08:00
Neeraj Singh
d33dcba72d Do not send id for quoting twice if the primary key is string. 
[#6022 state:resolved]
 2010-11-23 14:33:00 -08:00
Aaron Patterson
d717cb2913 clone and dup are working on 1.8 2010-11-23 14:29:05 -08:00
Aaron Patterson
064c28d6c2 fixing dup regressions 2010-11-23 14:29:05 -08:00