github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-01 01:34:57 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,343 Commits 34 Branches 105 Tags
9807b55c6b4bd1d366aa8a2ea5c4fdffbce800fa
Commit Graph

629 Commits

Author SHA1 Message Date
David Heinemeier Hansson
b611c685d9 Fixed that resource namespaces wouldnt stick to all nested resources (closes #9399) [pixeltrix] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7447 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-10 14:31:44 +00:00
David Heinemeier Hansson
46f217b298 Removed deprecated form of calling xml_http_request/xhr without the first argument being the http verb [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 23:00:17 +00:00
David Heinemeier Hansson
f7b0bc9ea3 Removed deprecated ActionController::Base.cookie (use ActionController#Base.cookies[]= instead) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 22:56:15 +00:00
David Heinemeier Hansson
4cfc60a6c8 Removed deprecated ActionController::Base.cookie (use ActionController#Base.cookies[]= instead) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 22:55:16 +00:00
David Heinemeier Hansson
6b0a647236 Removed ActionController::Base#keep_flash (use flash.keep instead) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7428 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 21:54:59 +00:00
David Heinemeier Hansson
89b7630627 Removed the deprecated ActionController#Base.template_root/= methods (use ActionController#Base.view_paths/= instead) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 18:00:55 +00:00
Michael Koziarski
80ff0b9f1c Optimise named route generation when using positional arguments. Closes #9450 [Koz] 
This change delivers significant performance benefits for the most
  common usage scenarios for modern rails applications by avoiding the
  costly trip through url_for.  Initial benchmarks indicate this is
  between 6 and 20 times as fast.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 00:18:55 +00:00
Jeremy Kemper
f1b12b62f4 Fix layout overriding response status. Closes #9476. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 03:12:03 +00:00
Michael Koziarski
32553a2d76 Fix assert_select for XML documents. Closes #8173. [dasil003] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 01:32:16 +00:00
Michael Koziarski
fe31f0e066 Add a user_agent to TestRequest 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-07 03:45:54 +00:00
Tobias Lütke
68d685056a Remove deprecated named routes [pixeltrix] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-06 14:28:32 +00:00
Michael Koziarski
a75d273ece Allow additional parameters to be passed to named route helpers when using positional arguments. Closes #8930 [ian.w.white@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7411 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-05 23:37:17 +00:00
Michael Koziarski
f81dae3fca Remove deprecated functionality from actionpack. Closes #8958 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-03 00:18:30 +00:00
Jeremy Kemper
33e5e41dda request.host works with IPv6 addresses. Closes #9458. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-31 19:03:42 +00:00
Rick Olson
0fc77b3928 correct the ActionCacheTest from [7346] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-20 13:48:13 +00:00
Rick Olson
1a459e8e7d Fix bug where action caching sets the content type to the ActionCachePath object. Closes #9282 [mindforge] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-20 01:12:43 +00:00
Rick Olson
0127e586d0 Find layouts even if they're not in the first view_paths directory. Closes #9258 [caio] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-15 18:59:37 +00:00
Michael Koziarski
55f444e694 Send freshness information when sending Etags. Without this internet explorer will not send conditional gets for a resource, but instead hold on to the responses for the current browser session. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-12 22:32:19 +00:00
David Heinemeier Hansson
bbbc45156b Added partial layouts (see example in action_view/lib/partials.rb) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-02 20:10:03 +00:00
Rick Olson
bdcbfa9944 Allow you to set custom :conditions on resource routes. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-25 02:47:21 +00:00
David Heinemeier Hansson
937a7abe45 Fixed that file.content_type for uploaded files would include a trailing \r #9053 [bgreenlee] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-24 01:20:18 +00:00
Tobias Lütke
9014bf3f26 * url_for now accepts a series of symbols representing the namespace of the record [Josh Knowles]. Closes #8640 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7197 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-19 13:42:11 +00:00
Michael Koziarski
b549366216 Introduce fake_models.rb to avoid platform-specific code. [mpalmer] Closes #8714 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-17 09:44:03 +00:00
Michael Koziarski
5476a6a6c7 Make :trailing_slash work with query parameters for url_for. Closes #4004 [nov] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7186 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-14 09:28:56 +00:00
Michael Koziarski
d4d4a08f6b Make sure missing template exceptions actually say which template they were looking for. Closes #8683 [dasil003] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-11 23:32:02 +00:00
Michael Koziarski
e80fabbbf4 Fix errors with around_filters which do not yield, restore 1.1 behaviour with after filters. Closes #8891 [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-11 02:29:25 +00:00
Michael Koziarski
fd65d89e07 Allow you to delete cookies with options. Closes #3685 [josh, Chris Wanstrath] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-01 23:27:59 +00:00
Rick Olson
a450e769f1 Allow you to render views with periods in the name. Closes #8076 [norbert] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-01 00:04:03 +00:00
David Heinemeier Hansson
20045df260 Temporary fix for formatted_polymorphic_urls and other polys that have additional options (need better testing!) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-28 22:27:59 +00:00
Jeremy Kemper
557e19346a Prefix nested resource named routes with their action name, e.g. new_group_user_path(@group) instead of group_new_user_path(@group). The old nested action named route is deprecated in Rails 1.2.4. Closes #8558. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7138 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-27 08:38:55 +00:00
Jeremy Kemper
a72fe4ea45 Give the legacy X-POST_DATA_FORMAT header greater precedence during params parsing for backward compatibility. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-26 01:19:18 +00:00
David Heinemeier Hansson
73fba4faf1 Fixed that HTTP authentication should work if the header is called REDIRECT_X_HTTP_AUTHORIZATION as well (closes #6754) [mislaw] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-23 16:43:08 +00:00
Jeremy Kemper
9159489872 Don't mistakenly interpret the request uri as the query string. Closes #8731. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-23 00:13:40 +00:00
Rick Olson
7f517348db Make ActionView#view_paths an attr_accessor for real this time. Also, don't perform an unnecessary #compact on the @view_paths array in #initialize. Closes #8582 [dasil003, julik, rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7034 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-15 23:52:37 +00:00
Jeremy Kemper
17927cbddc Improve UrlRewriter tests. Improve helper test coverage. Closes #7207, #7208, #7212. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-13 01:34:16 +00:00
Jeremy Kemper
c0c001839c Take advantage of Mocha support for sequenced returns. Closes #8639 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-13 00:55:11 +00:00
Jeremy Kemper
979c22444d Tolerate missing content type on multipart file uploads. Fix for Safari 3. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-12 07:44:23 +00:00
Jeremy Kemper
160af194e4 Routing: improve static segment test coverage. #7117 [Kevin Clark] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6979 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-09 04:39:01 +00:00
Jeremy Kemper
c9397e684c Action caching is limited to GET requests returning 200 OK status. Closes #3335. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-08 05:01:35 +00:00
Jeremy Kemper
c7df5bd6ac More nested polymorphic url helper fixes. Closes #6432, references #8601. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-07 21:35:01 +00:00
Rick Olson
b83efadb32 Assume html format when rendering partials in RJS. #8076 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6950 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 16:51:49 +00:00
Jeremy Kemper
8ce5479307 Routing: map.resource :logo routes to LogosController so the controller may be reused for multiple nestings or namespaces. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6922 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-01 04:40:30 +00:00
Jeremy Kemper
8139de2812 Routing: drop semicolon and comma as route separators. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-29 06:40:33 +00:00
Jeremy Kemper
e5b3d4b3b5 request.remote_ip understands X-Forwarded-For addresses with nonstandard whitespace. Closes #7386. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6877 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-28 00:10:13 +00:00
Jeremy Kemper
3f336ad5cc Don't prepare response when rendering a component. Closes #8493. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6875 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-27 23:48:28 +00:00
David Heinemeier Hansson
d3b5db8919 Added custom path cache_page/expire_page parameters in addition to the options hashes [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6868 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-27 16:38:02 +00:00
Rick Olson
cd599aad71 Action Caching speedup. #8231 [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6867 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-27 07:38:09 +00:00
Jeremy Kemper
dcaa074abf Routing: respond with 405 Method Not Allowed status when the route path matches but the HTTP method does not. Closes #6953. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 20:07:34 +00:00
Marcel Molina
42ebf559cc Add support for assert_select_rjs with :show and :hide. #7780 [dchelimsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 17:29:23 +00:00
Marcel Molina
dc4d23f2d7 Make assert_select's failure messages clearer about what failed. #7779 [dchelimsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6860 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 17:25:19 +00:00