github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-03 18:55:29 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,305 Commits 34 Branches 105 Tags
9b2ea172d72563c677e40156ba53aaaef6ed2294
Commit Graph

516 Commits

Author SHA1 Message Date
David Heinemeier Hansson
17816a11ee Proper CSS color definition (closes #2334) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:26:51 +00:00
David Heinemeier Hansson
82f1e19e4c Fixed docs (closes #2468) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:20:46 +00:00
David Heinemeier Hansson
07c494ae24 Added a reader for flash.now, so it's possible to do stuff like flash.now[:alert] ||= 'New if not set' (closes #2422) [Caio Chassot] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:14:10 +00:00
Nicholas Seckar
86a571090c Reset template variables after using render_to_string. Closes #2559 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2723 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 02:15:08 +00:00
Scott Barron
3a2943c54d Take a different approach to keeping flash around when using components. 
One that, you know, doesn't involve consuming every byte of free memory
on the system.

Closes #2589.

References #2291.



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2722 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 00:38:51 +00:00
Jeremy Kemper
22d9bad8a0 Expose the session model backing CGI::Session 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2696 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-20 21:59:48 +00:00
Jamis Buck
4da2d6c1ed Abbreviate RAILS_ROOT in traces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-19 15:56:21 +00:00
Nicholas Seckar
7d8ecad127 Update error trace templates 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 14:08:05 +00:00
Jamis Buck
e515ba9ecd Fix the html-scanner to count children correctly, playing nicely with :only, fixes #2181 [patrick@lenz.sh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 00:50:52 +00:00
Marcel Molina
ff8fe662ef Use the more appropriate columns_hash to get the session data column size limit. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2663 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-17 03:13:04 +00:00
Jamis Buck
1c057b7237 Update/clean up AP documentation (rdoc) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 15:42:03 +00:00
Nicholas Seckar
876e6607c9 Add missing file 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 13:10:32 +00:00
Tobias Lütke
0279949b05 added assert_valid to AP 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2635 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 02:20:53 +00:00
Nicholas Seckar
df9efebd94 Add line and file information to test process' get, post, etc methods 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 00:14:51 +00:00
Jamis Buck
bfbf6bba1f Allow ARStore::Session to indicate that it should not be reloaded in dev mode 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2627 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 20:49:04 +00:00
Nicholas Seckar
3625dfaad5 Clean up error pages by providing better backtraces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 19:05:15 +00:00
Michael Koziarski
3b8fce7b52 reasoning behind the seemingly duplicated method 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 18:39:19 +00:00
Michael Koziarski
518540a067 Add code and message to test response as per #2460 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2621 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 18:36:41 +00:00
Marcel Molina
48fd667bda Raise an exception if an attempt is made to insert more session data into the ActiveRecordStore data column than the column can hold. Closes #2234. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2612 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 14:39:29 +00:00
Tobias Lütke
6a8b9484a7 action pack asserts don't spam you with unnecissary backtraces anymore 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 13:58:22 +00:00
Scott Barron
f8f4eccd9a If a component redirects when called with render_component_as_string, render the 
redirected to action.

Fixes #2327


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2604 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 02:53:21 +00:00
David Heinemeier Hansson
04f4ae255f Take retry with breakpoint out until we fix it 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 01:09:34 +00:00
Nicholas Seckar
e0e8f0a302 Fix Request#host_with_port to use the standard port when Rails is behind a proxy. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 01:00:25 +00:00
David Heinemeier Hansson
43b6a74fb1 Added :locals support for render :inline #2463 [mdabney@cavoksolutions.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2567 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 20:26:39 +00:00
Sam Stephenson
4b72a4b12f Unset the X-Requested-With header when using the xhr wrapper in functional tests. Closes #2352. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 18:09:27 +00:00
Marcel Molina
d4576673c0 Unescape paths before writing cache to file system. Closes #1877. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 22:57:04 +00:00
Jamis Buck
0efeeba780 Speed improvement for session_options. #2287. [skaes@web.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 01:53:31 +00:00
Marcel Molina
9025e5d47f Make cacheing binary files friendly with Windows. Closes #1975. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 01:06:05 +00:00
Marcel Molina
a9de9c48c2 Make assert_tag :children count appropriately. Closes #2181. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 01:45:21 +00:00
David Heinemeier Hansson
f510b09c28 Made the documentation about render template/file sane 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2446 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-03 21:20:52 +00:00
David Heinemeier Hansson
c6d8a1f975 Use a nicer date format 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-01 19:00:28 +00:00
David Heinemeier Hansson
438db964ad Testing should also use a default REQUEST_METHOD 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 08:43:17 +00:00
David Heinemeier Hansson
ba91f9feaf Dont log size of request, doesnt work well with procs, not that interesting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 20:03:31 +00:00
David Heinemeier Hansson
d87618d20d Log request method and response size / status code 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2391 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:43:17 +00:00
Nicholas Seckar
0b1abc3360 Undo condition change made in [2345] to prevent normal parameters arriving as StringIO. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 23:39:56 +00:00
Jeremy Kemper
17d2732b1c Ticket #2295 - Tolerate consecutive delimiters in query parameters 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:23:37 +00:00
Scott Barron
a111e1a271 Keep flash after component is rendered. Closes #2291. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 11:02:11 +00:00
Jeremy Kemper
9852197f83 r3573@asus: jeremy | 2005-09-26 11:38:44 -0700 
Ticket 1507 - IE file uploads give the filename as a full Windows path, but Ruby on UNIX doesn't know how to File.basename('C:\\blah\blah.foo').
 r3574@asus:  jeremy | 2005-09-26 14:32:11 -0700
 Get rid of constant redefine warning.
 r3575@asus:  jeremy | 2005-09-26 14:33:07 -0700
 Override the file upload's original_filename singleton method in CGIMethods.get_typed_value.
 r3576@asus:  jeremy | 2005-09-26 14:33:49 -0700
 Unit test overridden original_filename against normal filenames and full Windows paths.
 r3577@asus:  jeremy | 2005-09-26 14:33:57 -0700
 Update change log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 17:59:46 +00:00
Thomas Fuchs
2346f5716f Fix open/save dialog in IE not opening files send with send_file/send_data, #2279 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-25 06:53:42 +00:00
David Heinemeier Hansson
d616b86025 Asserts now need html/document so it should require it 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-21 09:04:05 +00:00
David Heinemeier Hansson
8a35865b74 Added small note about how longtext might be needed for large session data 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 10:54:11 +00:00
David Heinemeier Hansson
3754822f43 Fixed problem with send_file and WEBrick using stdout #1812 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 10:53:33 +00:00
David Heinemeier Hansson
7f26415d3c Optimized tag_options to not sort keys, which is no longer necessary when assert_dom_equal and friend is available #1995 [skae]. Added assert_dom_equal and assert_dom_not_equal to compare tags generated by the helpers in an order-indifferent manner #1995 [skae] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 07:54:55 +00:00
David Heinemeier Hansson
47292cdef7 Fixed that Request#domain caused an exception if the domain header wasn't set in the original http request #1795 [Michael Koziarski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 06:44:53 +00:00
David Heinemeier Hansson
620726f844 Add "#:nodoc:" for ActionController::Routing::PathComponent::Result #2209 [l.francke@gmx.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-17 06:37:50 +00:00
David Heinemeier Hansson
e9504bb6f7 Cache relative_url_root for all webservers, not just Apache #2193 [skae] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-15 05:32:16 +00:00
David Heinemeier Hansson
b37d7a70f9 Speed up cookie use by decreasing string copying #2194 [skae] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-15 05:30:56 +00:00
David Heinemeier Hansson
7c042e09b4 Fixed access to "Host" header with requests made by crappy old HTTP/1.0 clients #2124 [Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-14 18:35:31 +00:00
David Heinemeier Hansson
ebb7bd7835 Added easy assignment of fragment cache store through use of symbols for included stores (old way still works too) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-13 08:31:32 +00:00
David Heinemeier Hansson
48018bf4b5 Moved session options to SessionManagement 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-13 07:48:12 +00:00