github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
22,664 Commits 34 Branches 105 Tags
9d8e2fb5e21da725755366ae2b7affe83ce1b6b0
Commit Graph

51 Commits

Author SHA1 Message Date
Prem Sichanugrist
733bfa63f5 Remove #among? from Active Support 
After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now.

It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
 2011-04-13 20:25:28 +08:00
David Heinemeier Hansson
d1575ae1b9 Change Object#either? to Object#among? -- thanks to @jamesarosen for the suggestion! 2011-04-12 00:23:07 +02:00
Prem Sichanugrist
a9f3c9da01 Using Object#in? and Object#either? in various places 
There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
 2011-04-11 03:17:09 +08:00
Santiago Pastorino
0e4748cd41 Make process reuse the env var passed as argument 2011-04-06 16:37:55 -03:00
John Firebaugh
07054fe369 Fix grammar, formatting, and cross references 2011-03-28 22:17:20 -07:00
Aaron Patterson
831a2342c6 just use alias 2010-11-30 20:04:31 -08:00
José Valim
da583df50c Remove bazillion warnings from AP suite. 2010-11-23 10:09:24 +01:00
Sven Fuchs
5c86286dd6 add respond_to? to ActionDispatch::Integration::Runner 
since Runner uses method_missing to delegate to the integration session it also should define respond_to? accordingly
 2010-11-22 15:42:28 -08:00
José Valim
b1ae796284 Fix an error on 1.8.7. 2010-09-29 11:28:38 +02:00
José Valim
14f9904e0f Avoid (@_var ||= nil) pattern by using initialize methods and ensuring everyone calls super as expected. 2010-09-29 11:18:31 +02:00
Emilio Tagua
b8c565fbd6 Initialize @app if it doesn't exists. 2010-09-28 15:10:15 -03:00
Emilio Tagua
53b91b11cc Avoid uninitialized variable warning, reuse @integration_session. 2010-09-27 11:19:21 -03:00
Santiago Pastorino
56de4e9a80 Fix the precedence issue here 2010-09-26 17:54:00 -03:00
Santiago Pastorino
db23e32141 Not need to do this double ternary 2010-09-26 17:43:26 -03:00
Santiago Pastorino
29f13beda3 port is appended twice to HTTP_HOST when host already has the port 2010-09-26 12:06:19 -03:00
Carlos Antonio da Silva
7fc1edd790 Remove deprecated stuff in ActionController 
This removes all deprecated classes in ActionController related to
Routing, Abstract Request/Response and Integration/IntegrationTest.
All tests and docs were changed to ActionDispatch instead of ActionController.
 2010-09-26 02:13:45 +08:00
Aaron Patterson
de9b3385fc fixing bug with rails use of rack-test 2010-09-22 17:09:06 -07:00
Joost Baaij
591e87fe7b Expanded routing documentation with current best practices 2010-08-29 00:04:14 +02:00
Xavier Noria
4f7565c4de adds missing requires for Object#try 2010-08-09 15:25:21 +02:00
Santiago Pastorino
b1cfcedc8f Change returning with tap 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 16:33:04 +02:00
Joshua Peek
570c54c39a Fix cookie access in integration tests with other host names 2010-04-05 15:22:09 -07:00
Xavier Noria
89978f10af moves Object#singleton_class to Kernel#singleton_class to match Ruby also there, same for #class_eval to simplify, and adds coverage for class_eval 2010-04-05 12:15:08 -07:00
wycats
ab8bf9e152 * Change the object used in routing constraints to be an instance of 
ActionDispatch::Request rather than Rack::Request.

* Changed ActionDispatch::Request#method to return a String, to be
  compatible with the Rack::Request superclass.

* Changed ActionDispatch::Request#method to return the original
  method in the case of methodoverride and #request_method not to,
  to be compatible with Rack::Request
 2010-04-03 20:24:30 -07:00
José Valim
997e22c275 Add a test which ensures action_dispatch.show_exceptions is properly disabled. 2010-04-02 20:54:10 +02:00
wycats
15c31c7639 open_session can just return the a dup of the current context. 
At this point, its entire purpose in the open_session {} case was to
delegate back to the IntegrationTest anyway.
 2010-03-22 17:14:28 -07:00
Carlhuda
0e15f07b75 Get modules back into integration tests 2010-03-17 17:52:21 -07:00
Mathias Biilmann Christensen
6c0c0f41a3 Fix for missing dependency in ActionDispatch::Integration 
When running cucumber features from a new rails 3 app requiring
'cucumber/rails/world' would raise:

uninitialized constant ActionDispatch::Integration::Session::Test (NameError)

Fixed by requiring 'test/unit/assertions' in action_dispatch/integration

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-17 16:53:42 -07:00
Jeremy Kemper
2a50eabf45 Integration test url options should account for :protocol not just https? 2010-03-15 19:52:41 -07:00
Carlhuda
050831803a If IntegrationSession is initialized with an objects that responds to #routes, automatically extend the URL helpers from the RouteSet onto it 2010-02-26 17:18:45 -08:00
Carlhuda
3bad24c85d Remove traces of SharedTestRoutes from user code; leave it as a standin for Rails.application.routes in Rails internal tests 2010-02-26 15:44:22 -08:00
Carlhuda
bae691f61a Change the API for setting global options for #url_for to self.url_options = { ... } 
This attr_accessor can be set in a before filter or in the action itself.
    Overwriting default_url_options still works but will output a deprecation notice.
 2010-02-26 15:20:41 -08:00
Carlhuda
8760add31a Get URL helpers working again in integration tests. 2010-02-25 17:53:30 -08:00
Carlhuda
fc4582fb66 Final pass at removing the router from a global constant 2010-02-25 17:53:29 -08:00
Carlhuda
226dfc2681 WIP: Remove the global router 2010-02-25 17:53:00 -08:00
Jeremy Kemper
f7b0a857e9 Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice. 2010-02-25 09:32:29 -08:00
Martin Schürrer
6bc24d40d5 Use ActionDispatch::Routing everywhere 2010-02-21 13:43:51 -08:00
Carlhuda
a3c6ad7d5e Fix a bunch of pending tests by providing an introspection mode for the Response object that does up-front parsing of the headers to populate things like @etag 2010-02-19 19:19:20 -08:00
Joshua Peek
909443eab6 Expose last controller in rack env["action_controller.instance"] 2010-01-20 09:00:23 -06:00
Joshua Peek
88ffba2329 Disable ShowExceptions during integration tests 2010-01-19 09:06:21 -06:00
Joshua Peek
2601a16ede Autoload AS test case 2010-01-04 16:22:46 -06:00
David Heinemeier Hansson
fe5f660413 Dont encourage __FILE__ bullshit 2009-12-22 17:25:34 -08:00
Joshua Peek
018dafe574 Allow autoloads to opt out of eager loading 2009-12-12 18:41:26 -06:00
Joshua Peek
ee395fe626 TestProcess belongs in AD 2009-12-12 18:09:44 -06:00
Joshua Peek
c1261b5484 Use Rails.application where we want a valid rack app 2009-10-16 19:04:28 -05:00
George Ogata
3de8b44b26 Make IntegrationTest::Runner propagate method_missing to ancestors. 
Fixes RSpec integration example groups, which mixes its Matchers
module into ActiveSupport::TestCase.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-10-15 11:01:42 +13:00
Carl Lerche
420004e030 Initialize a new instance of Rails.application during integration tests 
This is to fix the AWDWR tests until the application object is refactored to be a singleton.
 2009-09-30 12:39:26 -07:00
Joshua Peek
a6757a02e1 Move middleware and route configuration from AC::Dispatcher to Rails application object 2009-09-26 21:59:28 -05:00
Joshua Peek
14866fa3d8 Allow setting a default application for all integration tests 2009-09-26 21:38:48 -05:00
Joshua Peek
acfeec5151 Allow integration test rack app to be set with "@app" ivar instead of using open_session 2009-09-26 20:51:05 -05:00
Joshua Peek
088ce2904d Fix generic url rewriter in integration tests 2009-09-25 11:10:39 -05:00