Commit Graph

128 Commits

Author SHA1 Message Date
Xavier Noria
90de26703e removes ActionView::Helpers::PrototypeHelper 2011-04-13 13:24:32 +02:00
Xavier Noria
06bdaae071 removes ActionView::Helpers::ScriptaculousHelper 2011-04-13 13:24:31 +02:00
Xavier Noria
25181cafee let the default function in button_to_function be nil
I don't know which is the use case for button_to_function(name)
but there's a test for it. I am focused now on RJS extraction
and do not want to introduce a backwards incompatible change
at this moment. Perhaps worth revisiting when the whole thing
is done.
2011-04-13 13:23:16 +02:00
Xavier Noria
f9472f064f applies API guidelines to example 2011-04-13 13:23:16 +02:00
Xavier Noria
3223e04a21 removes support for RJS in button_to_function 2011-04-13 13:23:16 +02:00
Xavier Noria
8449da929e removes support for RJS in link_to_function 2011-04-13 13:23:16 +02:00
David Heinemeier Hansson
cc6fa2f4d7 Fix alias_method, add test 2011-03-27 11:20:54 -07:00
David Heinemeier Hansson
cb3e96a447 Make JavaScriptHelper#j() an alias for JavaScriptHelper#escape_javascript() -- note this then supersedes the Object#j() method that the JSON gem adds within templates using the JavaScriptHelper [DHH] 2011-03-26 10:28:39 -07:00
Alexey Mahotkin
dfebdb1b03 Tiny fixes to rdoc 2010-09-16 17:10:36 +04:00
David Trasbo
cfc8c7ab54 Wrap all occurences of <script> in a <tt> tag in docs [#5537 state:committed] 2010-09-06 18:22:33 +02:00
Rizwan Reza
5a0bc2c7bc Adds title and description where needed. 2010-06-16 22:47:49 +04:30
wycats
197904341f Merge branch 'master' into docrails 2010-03-26 15:10:24 -07:00
wycats
a5587efc19 Remove some 1.9 warnings (resulting in some fixed bugs). Remaining AM warnings are in dependencies. 2010-03-17 00:20:09 -07:00
Joshua Peek
d69e5616e8 link_to_function is here to stay 2010-03-16 22:06:16 -05:00
Pratik Naik
e68bfaf1fe Merge remote branch 'mainstream/master'
Conflicts:
	activerecord/lib/active_record/base.rb
	railties/lib/rails/configuration.rb
	railties/lib/rails/log_subscriber.rb
2010-03-12 16:00:01 +00:00
Jeroen van Dijk
a098720719 Updated documentation for block helpers in javascript_helper.rb 2010-03-12 16:50:14 +01:00
Carlhuda
4464b8e87b Deprecate block_called_from_erb? pending a solution for getting it into apps 2010-03-09 23:44:12 -08:00
Bruno Michel
f86421fb28 content_tag should escape its input
Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
2010-02-14 12:03:28 -08:00
Santiago Pastorino and José Ignacio Costa
e115eb097e More html_safe strings now use the safe_concat method
[#3856 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-02-05 13:28:43 -08:00
Joshua Peek
657d85580e Reorg options_for_javascript and array_or_string_for_javascript 2010-01-30 16:13:49 -06:00
Joshua Peek
570e02c96a Move button_to_function to prototype helper 2010-01-30 16:08:56 -06:00
Joshua Peek
ff3f779629 Unused JAVASCRIPT_PATH const 2010-01-30 16:04:58 -06:00
Joshua Peek
b3787643ec Move link_to_function and link_to_remote into prototype_legacy_helper
plugin
2010-01-30 15:20:00 -06:00
Joshua Peek
4f7a85d2c6 Revert "Merge branch 'rails/master' into ujs"
This reverts commit 3aa1ea1ae4, reversing
changes made to 2c12a71378.

Conflicts:

	actionpack/lib/action_view/helpers/javascript_helper.rb
	actionpack/lib/action_view/helpers/url_helper.rb
	actionpack/test/template/url_helper_test.rb
2010-01-30 14:39:59 -06:00
Joshua Peek
bddd1bb626 Deprecate link_to :popup 2010-01-29 20:00:55 -06:00
Erik St. Martin
9e3e1b3f24 fixing last merge breakage 2010-01-27 12:44:33 -06:00
Erik St. Martin
426a6b2e00 making non remote versions of link_to, button_to, submit_tag and image_submit_tag output data attributes for things like :confirm, :method, :popup, and :disable_with 2010-01-27 12:44:33 -06:00
Erik St. Martin
d769897171 modified helper that adds attributes for :method to include rel='nofollow' if :method => :delete, same as its remote_ equivalent 2010-01-27 12:44:33 -06:00
Erik St. Martin
463fc71107 making non remote versions of link_to, button_to, submit_tag and image_submit_tag output data attributes for things like :confirm, :method, :popup, and :disable_with 2010-01-27 12:44:33 -06:00
Stephen St. Martin
d8343a6ad7 restructure compatibility module so it is no longer a child 2010-01-27 12:44:32 -06:00
Erik St. Martin
1cd8b98d01 javascript_helper now correctly pulls in ajax_helper instead of prototype_helper. prototype_helper is pulled in by ajax_helper for reverse compatibility 2010-01-27 12:44:32 -06:00
Michael Koziarski
b579184819 Remove mention of long-dead define_javascript_functions 2008-11-18 20:11:55 +01:00
Pratik Naik
0432d15164 Merge with docrails. 2008-07-16 13:01:23 +01:00
Michael Koziarski
e358b1fce8 Remove old method of including javascripts define_javascript_functions.
javascript_include_tag and friends do a much better job.
2008-07-03 19:21:04 +03:00
Michael Koziarski
5501166dec Remove strange alias for JavaScriptHelper 2008-07-03 19:20:47 +03:00
Jeremy Kemper
b409474325 link_to_function and button_to_function shouldn't modify their options hashes 2008-06-23 23:41:21 -07:00
Jeremy Kemper
f4ccc17953 Performance: javascript helper tweaks to speed up escaping and reduce object allocations when building options strings 2008-06-21 14:54:10 -07:00
Jeremy Kemper
ff5f155f8d Use output_buffer reader and writer methods exclusively instead of hitting the instance variable so others can override the methods. 2008-06-08 20:05:39 -07:00
Jeremy Kemper
e732a405ab javascript_tag should only concat when block_given? 2008-06-06 17:59:41 -07:00
Jeremy Kemper
4d4c8e298f Don't pass block binding to concat 2008-06-02 21:32:50 -07:00
Jeremy Kemper
933697a5fc Try replacing _erbout with @output_buffer 2008-06-02 21:32:50 -07:00
David Heinemeier Hansson
e3b49c052b Fixed spelling errors (closes #9706) [tarmo/rmm5t]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7666 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 14:18:47 +00:00
David Heinemeier Hansson
da5d8fa6ad Fixed JavaScriptHelper#escape_javascript to also escape closing tags (closes #8023) [rubyruy]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7567 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 18:31:44 +00:00
David Heinemeier Hansson
0b0931e150 Added block-acceptance to JavaScriptHelper#javascript_tag (closes #7527) [BobSilva/tarmo/rmm5t]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7485 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-15 21:34:25 +00:00
David Heinemeier Hansson
edd68a587f Refactored in use of extract_options! (closes #9079) [josh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7220 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-24 16:48:57 +00:00
Jeremy Kemper
dbf42e379b Prefer MIME constants to strings. Closes #7707.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-06 09:46:04 +00:00
Jeremy Kemper
0eacdcf9a3 Use a consistent load path to avoid double requires. Fix some scattered Ruby warnings.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-28 07:16:55 +00:00
David Heinemeier Hansson
8ff92e2435 Added an html_options hash parameter to javascript_tag() and update_page_tag() helpers #6311 [tzaharia]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-09 00:50:11 +00:00
David Heinemeier Hansson
4b3e964a1a Fixed escaping of backslashes in JavaScriptHelper#escape_javascript (closes #6302) [sven@c3d2.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-09 00:34:43 +00:00
David Heinemeier Hansson
3ba5e39b54 Docfix (closes #6356)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-09 00:15:28 +00:00