github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
22,664 Commits 34 Branches 105 Tags
9d8e2fb5e21da725755366ae2b7affe83ce1b6b0
Commit Graph

57 Commits

Author SHA1 Message Date
Prem Sichanugrist
733bfa63f5 Remove #among? from Active Support 
After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now.

It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
 2011-04-13 20:25:28 +08:00
David Heinemeier Hansson
d1575ae1b9 Change Object#either? to Object#among? -- thanks to @jamesarosen for the suggestion! 2011-04-12 00:23:07 +02:00
Prem Sichanugrist
a9f3c9da01 Using Object#in? and Object#either? in various places 
There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
 2011-04-11 03:17:09 +08:00
Emilio Tagua
71acc2737a Move uri parser to AS as URI.parser method to reuse it in AP and ARes. 2010-09-28 11:38:35 +08:00
Jacques Crocker
51f1f550da Allow per Resource format settings 
Previously, ActiveResource was using the connection level formatter for get requests. This made it impossible to use custom formatters per resource.

Additionally this commit makes the Connection request methods more consistent. It always returns a Response. The base will then decode it each the response using its format setting.

Merging this commit will allow users to add custom formatters on a per Resource basis. This enables handling pagination responses from the server side, a very common use case that was previously impossible without monkeypatching XmlFormat.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-25 13:54:09 +02:00
José Valim
599e46bf24 Revert "Setup explicit requires for files with exceptions. Removed them from autoloading." 
Booting a new Rails application does not work after this commit [#5359 state:open]

This reverts commit 38a421b34d.
 2010-09-02 21:11:03 +02:00
Łukasz Strzałkowski
38a421b34d Setup explicit requires for files with exceptions. Removed them from autoloading. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-02 11:54:04 +02:00
Justin George
731d4392e4 Change event namespace ordering to most-significant first [#4504 state:resolved] 
More work still needs to be done on some of these names
(render_template.action_view and render_template!.action_view particularly)
but this allows (for example) /^sql/ to subscribe to all
the various ORMs without further modification

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-02 22:45:54 +02:00
José Valim
e5a2a9fced Remove URI object from ActiveResource notification, send the :mailer class in AM (like in AP#process_action) and remove locale instrumentation. 2010-01-15 15:57:33 +01:00
José Valim
7f4d8e3fbd Yield the payload notifications for further modification (like adding the result). 2010-01-15 12:24:31 +01:00
José Valim
116df09c3e Add notifications to ActiveResource. 2010-01-14 01:07:03 +01:00
Jeremy Kemper
76b2d3e337 Ruby 1.9.2: URI.parse and .decode are deprecated 2009-11-09 05:07:58 -08:00
pivotal
945d999aad Digest auth option for ActiveResource. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-10-15 10:37:04 +13:00
Jordan Brough
916b18adeb Active Resource recognizes 410 as Resource Gone now [#2316 state:resolved] [Jordan Brough, Jatinder Singh] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-09 22:56:32 +01:00
Jatinder Singh
1fc1986d6d Make ActiveResource#exists? work [#3020 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-09 22:24:57 +01:00
Roy Nicholson
3e0951632c Add ability to set SSL options on ARes connections. 
[#2370 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 13:24:05 -07:00
Jeremy Kemper
a0caad5255 Setting connection timeout also affects Net::HTTP open_timeout. 
[#2947 state:resolved]
 2009-08-09 02:28:00 -07:00
Marshall Huss
4d1552810f HTTP proxy support 
[#2133 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-08 15:33:55 -07:00
Brendan Schwartz
201387496e Ruby 1.9 compat: fix for SSL in Active Resource 
[#1272 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-07 12:24:02 -07:00
Joshua Peek
0b694a4ff4 Setup ActiveResource autoloads 2009-06-08 20:48:14 -05:00
Jeremy Kemper
6d4a4fabbb Cherry pick Active Support dependencies. Autoload. 2009-05-06 00:14:55 -07:00
Pratik Naik
f97832b1e4 Merge docrails 2009-03-24 12:15:43 +00:00
Jeremy Kemper
e8c4939fb3 Benchmark.ms 2008-12-09 11:17:11 -08:00
Edgar J. Suarez
790ebf8eab HTTP Accept header 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-09-18 11:15:48 +02:00
Rasik Pandey
16b9a554db Format related patches to support serializing data out in the correct format with correct http request headers per http method type [#450 state:resolved] 
Signed-off-by: Tarmo Tänav <tarmo@itech.ee>
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2008-08-29 18:45:39 -07:00
Joshua Peek
c1a8690d58 Consistently use the framework's configured logger and avoid reverting to RAILS_DEFAULT_LOGGER unless necessary. 2008-08-18 23:36:13 -05:00
David Heinemeier Hansson
aad7cac6ad Fixed problems with the logger used if the logging string included %'s [#840 state:resolved] (Jamis Buck) 2008-08-15 09:27:07 -05:00
Xavier Noria
64092de257 Improve documentation coverage and markup 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-02 14:45:23 +01:00
David Heinemeier Hansson
869d731cca Fixed response logging to use length instead of the entire thing (seangeo) [#27 state:resolved] 2008-04-29 17:16:36 -05:00
Cheah Chu Yeow
cf32baf915 Rescue from Timeout::Error in ActiveResource::Connection. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-04-22 09:30:56 +12:00
Cheah Chu Yeow
105910429d Introduce ActiveResource::Base.timeout. This allows a timeout to be set on the internal Net::HTTP instance ARes uses (default is 60 seconds). Setting a low timeout allows ARes clients to fail-fast in the event of a unresponsive/crashed server, rather than cause cascading failures in your application. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-04-22 09:30:41 +12:00
Jeremy Kemper
ab45bd487a URI.decode site username/password. Closes #11169 [Ernesto Jimenez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8900 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-19 23:06:09 +00:00
Michael Koziarski
8bbabd43a9 Add user and password configuration options to ActiveResource::Base, not all credentials can be specified inline. Closes #11112 [ernesto.jimenez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-18 00:21:18 +00:00
Michael Koziarski
5396b0f3b0 Use HEAD instead of GET inside exists? Closes #11062 [bscofield] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8827 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-09 22:21:55 +00:00
David Heinemeier Hansson
1ceccdeb7f Added more specific exceptions for 400, 401, and 403 (all descending from ClientError so existing rescues will work) (closes #10326) [trek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8390 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-14 23:09:46 +00:00
Jeremy Kemper
c81fff2468 Correct empty response handling. Closes #10445. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8364 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 05:53:56 +00:00
Rick Olson
24e6cbc724 Don't cache net/http object so that ActiveResource is more thread-safe. Closes #10142 [kou] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-19 00:06:23 +00:00
David Heinemeier Hansson
dc399b96c8 Added ActiveResource.format= which defaults to :xml but can also be set to :json [DHH]. Added one-off declarations of mock behavior [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-20 23:18:05 +00:00
Tobias Lütke
18a4cc1bd2 Raise ActiveResource::Redirection on 301,302 http code 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7297 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-09 19:22:04 +00:00
David Heinemeier Hansson
ae4838fff2 Big documentation upgrade for ARes (closes #8694) [jeremymcanally] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-23 17:29:54 +00:00
Rick Olson
9e4461438f Added proper handling of arrays. Closes #8537 [hasmanyjosh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-21 15:07:15 +00:00
Tobias Lütke
bf280157d9 Ensure that post and put requests pass in Content-Length to the server. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-19 18:40:28 +00:00
Jeremy Kemper
849038ee51 Recognize and raise an exception on 405 Method Not Allowed responses. Closes #7692. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6864 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 20:57:08 +00:00
Rick Olson
bd50d82f70 Add support for setting custom headers per ActiveResource model [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-29 03:14:36 +00:00
David Heinemeier Hansson
c97f329b2a Disregard namespaces from the default element name, so Highrise::Person will just try to fetch from "/people", not "/highrise/people" [DHH] Added that saves which get a body response (and not just a 201) will use that response to update themselves [DHH] Fixed constant warning when fetching the same object multiple times [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-19 22:18:03 +00:00
Jeremy Kemper
e00e6a2941 Interpret 422 Unprocessable Entity as ResourceInvalid. Closes #7097. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-17 00:46:32 +00:00
Rick Olson
932e7b003c Mega documentation patches. #7025, #7069 [rwdaigle] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5962 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-16 06:34:10 +00:00
Rick Olson
55d4dbb8df Fix issues with ActiveResource collection handling. Closes #6291. [bmilekic] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-12 15:29:54 +00:00
Jeremy Kemper
7370e54cc4 *_path instance methods. Check for missing/invalid site uri. http_mock response takes message arg, extracts numeric code. Tests log to test/debug.log 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5680 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-05 19:12:51 +00:00
Jamis Buck
9c9443812f Add basic logging support for logging outgoing requests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-23 22:21:09 +00:00