github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
22,664 Commits 34 Branches 105 Tags
9d8e2fb5e21da725755366ae2b7affe83ce1b6b0
Commit Graph

2609 Commits

Author SHA1 Message Date
Xavier Noria
9d8e2fb5e2 set log encoding to BINARY, but still use text mode to output portable newlines 2011-05-18 12:43:29 +02:00
Jeremy Kemper
b77e032ccf Merge pull request #247 from goncalossilva/performance_test 
Performance tests improved
 2011-05-17 14:28:40 -07:00
Michael Koziarski
fbab6f959b Don't print deprecation warnings every time the user reads or writes an inheritable attribute. The warnings on declaration is enough. 2011-05-17 12:03:58 -04:00
David Lee
94617d7da1 Optimize parts of HashWithIndifferentAccess 2011-05-17 03:01:31 -07:00
José Valim
6733721520 Deprecate attr_accessor_with_default. 2011-05-16 11:31:34 -04:00
Xavier Noria
d491130236 Merge branch 'master' of git://github.com/lifo/docrails 
Conflicts:
	actionpack/lib/action_view/helpers/date_helper.rb
	railties/lib/rails/generators/rails/app/templates/config/initializers/wrap_parameters.rb.tt
 2011-05-14 11:21:27 +02:00
Aaron Patterson
1fac9c74ab securerandom ships with 1.8.7+, so just use it 2011-05-13 23:22:13 -07:00
Xavier Noria
bdbb15e5a5 new reporting method Kernel#quietly 2011-05-13 01:41:52 +02:00
Josh Kalderimis
3d03c79829 Remove a circular require in AS deprecations. This is safe as AS deprecations is autoloaded as needed. 2011-05-12 15:24:10 +02:00
Santiago Pastorino
8cf4725f64 Merge pull request #227 from farski/master 
Unnecessary redundancy in Time/Date calculations
 2011-05-11 17:10:44 -07:00
Corin Langosch
295bf413e5 add missing require for ordered_hash dependency 2011-05-11 16:22:35 +02:00
Sebastian Martinez
ab880b9eb0 Follow code conventions on docs 2011-05-10 20:55:31 -03:00
Aaron Patterson
8f999a3f80 make sure log file is written in binary mode. fixes #497 2011-05-10 13:23:05 -07:00
Gonçalo Silva
7fcf0ca69e removed redundant metric support check (and print when it isn't) 2011-05-10 03:40:44 +01:00
Gonçalo Silva
aaa85cde60 remove forgotten puts 2011-05-10 02:52:10 +01:00
Gonçalo Silva
0304d8076a ruby-prof's awesome call stack printer is now used by default 2011-05-10 02:49:32 +01:00
Gonçalo Silva
810fb2b527 benchmarker and profiler now use the new performance testing tools (support for Rubinius and JRuby and high configurability) 2011-05-10 01:38:21 +01:00
Vijay Dev
3f36441e90 Update copyright year in Active Resource and Active Support 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-05-09 20:17:23 -03:00
Gonçalo Silva
0d1f7584ba contemplate unsupported metrics 2011-05-09 23:29:00 +01:00
José Valim
2750f2ee00 Fix failing test. 2011-05-09 17:08:59 +02:00
Mike Howard
372d72445b xml_mini.rb:_dasherize() replacement 20 to 25% faster 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-05-09 17:06:56 +02:00
Vijay Dev
91c18554f6 adds code examples for negative ordinalize 2011-05-08 23:48:15 +05:30
Vijay Dev
eef2060879 included examples for negative ordinalize 2011-05-08 23:43:46 +05:30
José Valim
9727dd1e38 Merge pull request #388 from smartinez87/remove_method 
Better use #remove_possible_method here
 2011-05-08 07:42:02 -07:00
Sebastian Martinez
b94d94a1ae Better use #remove_possible_method here 2011-05-08 11:31:56 -03:00
David Lee
099eb2b3fd indifferent access should recurse Hash subclasses 
This commit makes Hash subclasses convert to HWIA by default for nested
objects of subclasses of Hash, but allows certain subclasses to prevent nested
conversion by introducing Hash#nested_under_indifferent_access that subclasses
can overwrite.

ActiveSupport::OrderedHash is one such subclass that overwrites
+nested_under_indifferent_access+, since implicitly converting it to HWIA would
remove the ordering of keys and values in Ruby 1.8.

This change is necessary because commit ce9456e broke nested indifferent access
conversion for all subclasses of Hash.
 2011-05-08 03:40:51 -07:00
José Valim
30db3a82f6 Merge pull request #430 from dlee/methodoverride 
Logs should show overridden method; Issue 426
 2011-05-08 03:33:22 -07:00
José Valim
ad129639c7 Fix failing xml mini test. 2011-05-08 12:25:02 +02:00
Gonçalo Silva
181c8422d7 explicitly return from run() under minitest (metrics were printed with the previous solution) 2011-05-08 04:20:14 +01:00
Gonçalo Silva
aec7456f81 Merge branch 'master' of https://github.com/rails/rails into performance_test 
Conflicts:
	activesupport/lib/active_support/testing/performance.rb
 2011-05-08 03:54:55 +01:00
José Valim
0ef978d1d2 Revert "Merge pull request #275 from pk-amooma/master" 
Several AP tests fail after this change.

This reverts commit aaf01cd537, reversing
changes made to 9cc18c52fa.
 2011-05-07 23:45:15 +02:00
José Valim
803548c46b xml_mini_test.rb now runs. 2011-05-07 22:45:06 +02:00
Jason
3880ab0d7c ordinalize negative numbers patch 
Applied patch by Amir Manji
  https://github.com/rails/rails/issues/437#issuecomment-1116045

Signed-off-by: Jason <jasonmichaelroth@gmail.com>
 2011-05-07 13:21:00 -06:00
Vijay Dev
448845cd0d replaced eg using old router api with the one in the guides. Add info on nesting with_options 2011-05-07 21:18:03 +05:30
Vijay Dev
ffb70cf256 minor fixes 2011-05-07 20:20:28 +05:30
Vijay Dev
6e83330590 fixes incorrect error message for sample method 2011-05-07 18:09:20 +05:30
Vijay Dev
3056b3379b use new AR calls in examples 2011-05-07 18:08:13 +05:30
Vijay Dev
7194b393a6 fix comment alignment 2011-05-07 18:07:42 +05:30
José Valim
f77cd7c7b6 Merge pull request #286 from jasoncodes/marshal_subsec 
Fix marshal round-tripping of fractional seconds (Time#subsec).
 2011-05-07 04:39:50 -07:00
José Valim
aaf01cd537 Merge pull request #275 from pk-amooma/master 
properly escape "'" to "'" for XML
 2011-05-07 03:41:26 -07:00
José Valim
b011a7a938 Merge remote branch 'rolftimmermans/desc_tracker' 2011-05-07 12:26:45 +02:00
José Valim
a761d77902 Merge pull request #248 from bigfix/enumerable_as_json 
Enumerable should pass encoding options to children in #as_json/#to_json
 2011-05-07 03:19:56 -07:00
David Lee
17a91a6ef9 Logs should show overridden method; Issue 426 2011-05-07 03:04:26 -07:00
José Valim
a6ef255ff5 Merge pull request #349 from bradley178/master 
Hash.from_xml chokes on empty CDATA
 2011-05-07 02:58:16 -07:00
Vijay Dev
162bf8ffb1 revises comment for blank? method 2011-05-07 12:13:38 +05:30
Xavier Noria
ef2738472d Revert "Small edit to the if statement simplification for blank? on the Object class. An Object doesn't need to be nil and empty to be blank? just one or the other." 
Reason: the original code is correct, see

    !nil && !empty -> !(nil || empty) -> !blank

That said, this example has too many negations
for my linking. Think should be revised to be
more positive and straightforward to read.

This reverts commit a4b6e3d9be.
 2011-05-06 17:30:00 +02:00
Caley Woods
a4b6e3d9be Small edit to the if statement simplification for blank? on the Object class. An Object doesn't need to be nil and empty to be blank? just one or the other. 2011-05-06 08:23:12 -07:00
José Valim
894bdbd53d Move variables to underscore format, update protected instance variables list. 2011-05-06 14:57:25 +02:00
Jan Xie
25288c137c minitest/ruby19 compatible performance test 2011-05-05 16:11:49 +08:00
David Heinemeier Hansson
169ae75e09 Prepare for beta1 2011-05-04 20:21:05 -05:00