Oge Nnadi
d5634b2287
Added missing </tt>
2011-04-11 13:08:58 -07:00
Santiago Pastorino
cc58fe79ac
Implicit actions named not_implemented can be rendered
2011-04-02 23:47:50 -03:00
José Valim
ba51aa0b1b
Make action_method? public and change implicit rendering to override it instead.
2011-03-30 17:22:05 +02:00
José Valim
94907035b6
Pass the proper method_name instead of hardcoding to action_name.
...
Conflicts:
actionpack/lib/action_controller/metal/implicit_render.rb
2011-03-29 19:30:59 +02:00
Andrew White
9772de8d45
Fix filter :only and :except with implicit actions
...
The method_name argument is "default_render" for implicit actions
so use the action_name attribute to determine which callbacks to run.
[#5673 state:resolved]
2011-03-23 23:32:44 +00:00
Manuel Meurer
deae670e9a
Change ActionView::ViewPathSet to ActionView::PathSet
2011-03-13 15:14:51 +07:00
Neeraj Singh
806e6f80dc
render_to_string must ensure that response_body
...
is nil
[ #5875 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2011-01-25 20:14:03 +01:00
José Valim
262b2ea8cd
Solve SystemStackError when changing locale inside ActionMailer [ #5329 state:resolved]
2011-01-19 23:42:10 +01:00
Nick Sutterer
db24701abe
process_action accepts multiple args, even with Callbacks.
2010-12-29 16:37:10 -08:00
wycats
e03e1fdbc8
Speed up template inheritance and remove template inheritance option
2010-12-26 23:56:09 -08:00
artemave
ce21ea7832
#948 make template inheritance optional
2010-12-26 22:32:15 -08:00
artemave
ddd85ef9c6
#948 template_inheritance
2010-12-26 22:32:15 -08:00
Neeraj Singh
3c7a33c051
Rewording existing comment
2010-11-30 10:00:47 -05:00
Neeraj Singh
aa9a3227a0
Rewording existing comment
2010-11-29 21:38:59 -05:00
Santiago Pastorino
d3f8765482
Avoid range object creation
2010-11-20 02:29:57 -02:00
Santiago Pastorino
bb7b705b0c
Fix indentation
2010-11-19 14:26:44 -02:00
Santiago Pastorino
555b7cd04a
Don't merge just directly add to the action to the :partial key
2010-11-19 14:26:42 -02:00
Santiago Pastorino
b1ffd65b8f
Useless assignation
2010-11-19 14:26:39 -02:00
José Valim
a897402863
Remove inline comment.
2010-11-11 17:07:06 +01:00
Marcelo Giorgi
2bb1c202b4
Make after_filter halt when before_filter renders or redirects [ #5648 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-11-11 17:05:07 +01:00
Andrew White
4ba24ba043
Allow generated url helpers to be overriden [ #5243 state:resolved]
2010-10-26 14:27:18 +01:00
José Valim
940b57789f
Add support to render :once.
...
This will be used internally by sprockets to ensure requires are executed just once.
2010-10-10 12:43:26 +02:00
wycats
8cb2cfbf71
Fix a few bugs when trying to use Head standalone
2010-10-10 00:54:11 -07:00
José Valim
c563f10f3e
render :template => 'foo/bar.json' now works as it should.
2010-10-07 21:31:31 +02:00
José Valim
8f9e9118e4
Make collection rendering faster.
2010-10-07 21:31:31 +02:00
Aaron Patterson
1d9a219307
oops, missed a uniq
2010-09-29 11:53:34 -07:00
Aaron Patterson
a5f8f59081
dry up action_methods
2010-09-29 11:47:54 -07:00
Aaron Patterson
c57f5d58ea
no need to call e.class
2010-09-29 10:39:17 -07:00
José Valim
258f7b586e
Fix a small typo (ht: masterkain)
2010-09-29 10:34:37 -07:00
José Valim
14f9904e0f
Avoid (@_var ||= nil) pattern by using initialize methods and ensuring everyone calls super as expected.
2010-09-29 11:18:31 +02:00
Emilio Tagua
0fa9c5392e
Define @_layout if it is not defined.
2010-09-28 18:25:24 -03:00
Emilio Tagua
059d609a1a
Avoid more uninitialized variable warnings.
2010-09-28 15:46:30 -03:00
Piotr Sarnacki
79bd92b783
Refactor ActionMailer to not use hide_actions
2010-09-03 22:59:11 +02:00
Piotr Sarnacki
4131a2d804
Move ActionController::Railties::RoutesHelpers and ActionMailer::Railties::RoutesHelper to AbstractController::Railties::RoutesHelpers
2010-09-03 22:59:11 +02:00
Piotr Sarnacki
6c95e0f879
Add mounted_helpers to routes
...
mounted_helpers are a bit similar to url_helpers. They're automatically
included in controllers for Rails.application and each of mounted
Engines. Mounted helper allows to call url_for and named helpers for
given application.
Given Blog::Engine mounted as blog_engine, there are 2 helpers defined:
app and blog_engine. You can call routes for app and engine using those
helpers:
app.root_url
app.url_for(:controller => "foo")
blog_engine.posts_path
blog_engine.url_for(@post)
2010-09-03 22:59:07 +02:00
Jesse Storimer
730af48963
Ensure that inherited helper_methods are available after calling clear_helpers [ #5348 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-28 18:07:01 -03:00
José Valim
66ef92272c
Add clear_helpers as a way to clean up all helpers added to this controller, maintaing just the helper with the same name as the controller.
2010-08-26 16:07:54 -03:00
Joost Baaij
e9eaae1a05
fixed capitalization
2010-08-25 19:51:20 +02:00
Joost Baaij
eaeda503e8
change rdoc to conform to api guidelines
2010-08-25 18:57:27 +02:00
Santiago Pastorino
b451de0d6d
Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;)
2010-08-14 04:12:33 -03:00
Piotr Sarnacki
84f0a0bc30
Reload action_methods in AbstractController after defining new method.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-04 14:44:34 -03:00
José Valim
2af8fd2829
Also move asset_path to AbstractController.
2010-07-24 00:47:48 +02:00
Jeroen van Dijk and Josh Kalderimis
affeb51569
Move config_accessor :asset_host from ActionController::Base to AbstractController which fixes issues with asset_host in ActionMailer
...
Including:
- Moved mailer objects in separate directory
- Added two tests for asset_host configuration option
2010-07-24 00:27:25 +02:00
Piotr Sarnacki
f7ba614c2d
Unify routes naming by renaming router to routes
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-02 01:51:03 +02:00
José Valim
033e0a041f
ActiveRecord and ActionPack now use the new descendants implementation.
2010-06-19 17:15:21 +02:00
Alan Harper
566967eaf3
Missing method error doesn't specify which controller it is missing from [ #4436 state:resolved]
...
The error page shown when the method you are requesting on a controller
doesn't specify which controller the method is missing from
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-10 20:04:37 +02:00
José Valim
b67ec8ba20
class_attribute is not a direct replacement of class_inheritable_*.
...
If you are setting a hash or an array in class_attribute or you need
to freeze it, to ensure people won't modify it in place or you need
to dup it on inheritance.
2010-06-10 19:39:09 +02:00
David Heinemeier Hansson
4a6290bb38
Missed the extraction
2010-06-03 23:32:12 +10:00
wycats
e57dbfe6af
Changes made while working on upgrading cells to Rails 3
2010-06-03 23:32:12 +10:00
Rohit Arondekar
e3b04f3ce9
Minor typo fix in callbacks.rb of abstract_controller
2010-06-03 23:32:08 +10:00
