Commit Graph

2742 Commits

Author SHA1 Message Date
David Heinemeier Hansson
d1575ae1b9 Change Object#either? to Object#among? -- thanks to @jamesarosen for the suggestion! 2011-04-12 00:23:07 +02:00
Aaron Patterson
622f23b604 wrap the pg_get_serial_sequence function and reuse it for the default sequence name 2011-04-11 14:38:42 -07:00
Aaron Patterson
58259bbf29 adding exec_insert for postgresql 2011-04-11 10:10:01 -07:00
Aaron Patterson
b1ba04b32b fixing variable name in mysql test 2011-04-11 10:10:01 -07:00
Aaron Patterson
3d96e6217b adding mysql adapter test case 2011-04-11 10:10:00 -07:00
Aaron Patterson
32dbf00d99 adding exec_insert to sqlite3 2011-04-11 10:10:00 -07:00
Prem Sichanugrist
a9f3c9da01 Using Object#in? and Object#either? in various places
There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
2011-04-11 03:17:09 +08:00
Aaron Patterson
508c679f11 moving sqlite_adapter_tests to sqlite3_adapter_test so that the tests are actually run. 💣 2011-04-08 11:22:21 -07:00
Emilio Tagua
18dde7bf4f Disable IdentityMap in log tests, it's not important and when running tests rake task it logs more messages in the tested buffer.
Signed-off-by: José Valim <jose.valim@gmail.com>
2011-04-05 22:08:00 +02:00
Durran Jordan
a9b4b5da7c Destroying records via nested attributes works independent of reject_if:
- When a :_destroy truthiness is provided in the attributes hash, the
  record should get destroyed regardless of the result of the proc or
    method supplied to :reject_if. (If :allow_destroy is true)

[#6006 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-04-05 10:38:54 -03:00
Emilio Tagua
454ec93ff7 Add log message when loading records from Identity Map.
Signed-off-by: José Valim <jose.valim@gmail.com>
2011-04-04 10:48:17 +02:00
Emilio Tagua
b35617235d Use IM when trying to load records using ID.
Signed-off-by: José Valim <jose.valim@gmail.com>
2011-04-04 10:48:12 +02:00
Aaron Patterson
2be383b946 test against AR class rather than the relation (thanks Andrew White!) 2011-03-29 17:50:39 -07:00
Aaron Patterson
0471fc9f1c Merge branch 'master' into zomg
* master: (51 commits)
  order is not guaranteed by this select, so add an order and call first!
  oracle stores this with microseconds, so convert to seconds before comparing
  make sure that active connections are not cleared during test when an exception happens
  clearing active connections in the ConnectionManagement middleware if an exception happens
  proxy body responses so we close database connections after body is flushed
  Pass the proper method_name instead of hardcoding to action_name.
  Quote find_in_batches ORDER BY clause [#6620 state:resolved]
  Delegate first!, last!, any? and many? to scoped
  Dont call authenticate_or_request_with_http_basic twice
  Remove 'warning: ambiguous first argument' when running ActionPack tests
  Change exists? so that it doesn't instantiate records [#6127 state:resolved]
  Move mapper_test to the appropriate location
  Update the wildcard route to be non-greedy by default, therefore be able to match the (.:format) segment [#6605 state:resolved]
  Fix examples
  Added Base.http_basic_authenticate_with to do simple http basic authentication with a single class method call [DHH]
  make sure we have an active database connection before running each connection management test
  adding active_connections? to the connection pool for finding open connections
  adding active_connection? to the connection pool
  testing app delegation from the ConnectionManagement middleware
  namespacing connection management tests. ❤️
  ...
2011-03-29 17:38:43 -07:00
Aaron Patterson
58becf1165 order is not guaranteed by this select, so add an order and call first! 2011-03-29 17:27:32 -07:00
Aaron Patterson
6067d29a1f oracle stores this with microseconds, so convert to seconds before comparing 2011-03-29 17:09:22 -07:00
Aaron Patterson
c7b7c6ad1c make sure that active connections are not cleared during test when an exception happens 2011-03-29 15:47:16 -07:00
Aaron Patterson
3b2a032677 clearing active connections in the ConnectionManagement middleware if an exception happens 2011-03-29 15:42:32 -07:00
Aaron Patterson
e5246092d1 proxy body responses so we close database connections after body is flushed 2011-03-29 15:37:07 -07:00
Andrew White
555d016389 Quote find_in_batches ORDER BY clause [#6620 state:resolved] 2011-03-29 17:24:55 +01:00
Andrew White
a9dafbb28d Delegate first!, last!, any? and many? to scoped 2011-03-29 17:21:21 +01:00
Andrew White
b155fdadf3 Change exists? so that it doesn't instantiate records [#6127 state:resolved] 2011-03-29 12:51:58 +01:00
Aaron Patterson
aea1477362 make sure we have an active database connection before running each connection management test 2011-03-28 17:47:46 -07:00
Aaron Patterson
25f94971ab adding active_connections? to the connection pool for finding open connections 2011-03-28 17:29:37 -07:00
Aaron Patterson
4211866b7a adding active_connection? to the connection pool 2011-03-28 16:43:34 -07:00
Aaron Patterson
ec0cacc293 testing app delegation from the ConnectionManagement middleware 2011-03-28 16:22:37 -07:00
Aaron Patterson
7b4866e0ae namespacing connection management tests. ❤️ 2011-03-28 16:08:42 -07:00
Aaron Patterson
e1a5007207 sql logger ignores schema statements 2011-03-28 15:27:37 -07:00
Sebastian Martinez
fb21511040 Bring #reorder back
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-28 10:24:08 -03:00
Sebastian Martinez
245542ea29 Added new #update_column method.
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-27 21:47:38 -03:00
Sebastian Martinez
0e1fed537a Revert "Removed #update_attribute method. New #update_column method."
This reverts commit 45c233ef81.

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-27 18:55:30 -03:00
Aaron Patterson
a9d27c04ab cleaning up typecast test a little 2011-03-26 17:16:33 -07:00
Aaron Patterson
5013fe3a1d refactoring tz to a variable rather than repeating it 2011-03-26 17:04:54 -07:00
Aaron Patterson
dea3d2dd20 adding a test for attributes after type cast. thanks nragaz. ❤️ 2011-03-26 11:50:31 -07:00
Sebastian Martinez
45c233ef81 Removed #update_attribute method. New #update_column method.
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-26 12:09:04 -03:00
Aaron Patterson
7333f50abc fixing whitespace errors. 💣 2011-03-25 12:10:11 -07:00
John Mileham
28c73f0123 Use Arel to build subquery. Adapt tests to changed fixtures. 2011-03-24 15:09:24 -04:00
John Mileham
b44a0ec153 Merge branch 'master' of github.com:rails/rails into count_behavior 2011-03-24 15:03:08 -04:00
Josh Susser
5214e73850 add #first! and #last! to models & relations 2011-03-24 09:55:51 -07:00
Adam Meehan
c5908a8649 Fix before_type_cast for timezone aware attributes by caching converted value on write. Also remove read method reload arg on timezone attributes. 2011-03-23 15:38:51 -07:00
Murray Steele
8ee81d21fb Failing test case to show that habtm join table contents are removed when a model is destroyed but the destruction is blocked by a before_destroy. 2011-03-23 14:45:21 -07:00
Santiago Pastorino
baa237c974 Allow to read and write AR attributes with non valid identifiers 2011-03-22 20:02:32 -03:00
Aaron Patterson
ed97c39517 adding missing require 2011-03-22 10:10:33 -07:00
Aaron Patterson
2ef6270f8f Merge branch 'master' into fuuu
* master:
  Do not show optional (.:format) block for wildcard route [#6605 state:resolved]
  pushing id insertion and prefetch primary keys down to Relation#insert
  use prepared statements to fetch the last insert id
  escaping binary data encoding when inserting to sqlite3. Thanks Naruse! [#6559 state:resolved]
  schemas set by set_table_name are respected by the mysql adapter. [#5322 state:resolved]
  Reapply extensions when using except and only
  SJIS is an alias to Windows-31J in ruby trunk. Use SHIFT_JIS for this test
  Improved resolver docs a bit
  [action_view] docs for FileSystemResolver
  [action_view] added custom patterns to template resolver
2011-03-22 09:34:33 -07:00
Aaron Patterson
88636f7195 escaping binary data encoding when inserting to sqlite3. Thanks Naruse! [#6559 state:resolved] 2011-03-21 14:49:07 -07:00
Aaron Patterson
ea8fcfb729 schemas set by set_table_name are respected by the mysql adapter. [#5322 state:resolved] 2011-03-21 11:20:45 -07:00
Iain Hecker
96b9fc4400 Reapply extensions when using except and only 2011-03-21 10:29:45 -07:00
Jon Leighton
5b84aebd14 Add order clauses to fix some tests which were failing under 1.8 on oracle and postgres 2011-03-18 23:14:45 +00:00
Jon Leighton
8aaf3c1e55 Merge branch 'master' into nested_has_many_through 2011-03-16 18:54:51 +00:00
Jon Leighton
9abc94c445 oracle, y u defy me 2011-03-16 18:54:34 +00:00