Arun Agrawal
5bc87cc2ee
We need [] method here. previously it's an array.
2011-08-13 13:13:05 +05:30
Aaron Patterson
943a37348a
moving test_generate to an integration test with one assert per test
2011-08-12 15:55:00 -07:00
Arun Agrawal
8196c842b6
We actually don't need a reverse_merge! here. dup removed was giving error with nil class.
2011-08-12 16:56:29 +05:30
Andrew Kaspick
61579b7661
when calling url_for with a hash, additional (likely unwanted) values (such as :host) would be returned in the hash... calling #dup on the hash prevents this
2011-08-11 13:28:31 -05:00
Gonzalo Rodriguez and Leonardo Capillera
9e81bfd8fc
Remove 'parameters_for_url' parameter from 'form_tag' method signature
...
If you use that parameter it will end calling to url_for with two
arguments, which fails because url_for expects only one
2011-08-10 23:14:56 -03:00
José Valim
bb4f687bc6
Remove lame comment.
2011-08-09 16:49:38 -07:00
Santiago Pastorino
d9b690f71f
rake assets:precompile defaults to production env
2011-08-09 20:40:52 -03:00
Aaron Patterson
5f56db4454
adding missing require to fist railties tests
2011-08-09 14:54:56 -07:00
Aaron Patterson
f9f423fa18
deprecating process_view_paths
2011-08-09 12:10:25 -07:00
Aaron Patterson
3ad26c8e48
avoid object creation via useless duping and freezing
2011-08-09 11:41:06 -07:00
Aaron Patterson
26e53a16c4
just use map and case / when rather than modifying the iterating array
2011-08-09 11:30:43 -07:00
Aaron Patterson
7cd3772fe6
only typecast what we need to typecast
2011-08-09 11:26:44 -07:00
Aaron Patterson
b14f1c3ad7
Favor composition over inheritance.
2011-08-09 11:23:02 -07:00
Aaron Patterson
88de343ef4
Array#+ automatically dups, no double duping
2011-08-09 10:54:05 -07:00
Aaron Patterson
14a8fd146a
Just remove the sort_locals method
2011-08-09 10:13:02 -07:00
Aaron Patterson
1fbc4704df
the freeze trick does nothing on arrays used as hash keys.
2011-08-09 10:09:46 -07:00
Aaron Patterson
233696a027
use functional style to build a list of template objects
2011-08-09 09:32:16 -07:00
Aaron Patterson
37b77c6ae7
refactor the optimized build_query a bit
2011-08-08 22:16:52 -07:00
Aaron Patterson
128467e927
reduce file stats by improving our dir glob pattern
2011-08-08 21:42:45 -07:00
Aaron Patterson
295a7fd1bb
hash on the template directory in order to improve cache hits
2011-08-08 21:03:40 -07:00
Aaron Patterson
940404096f
use meaningful names with our variables
2011-08-08 21:01:19 -07:00
Aaron Patterson
0155bf4021
use binread to read the files
2011-08-08 19:51:41 -07:00
Aaron Patterson
0b212117e6
be explicit about arguments passed around
2011-08-08 19:29:12 -07:00
Santiago Pastorino
8360d71965
Initialize config.assets.version the same way it's done in Sprockets
2011-08-08 12:49:10 -03:00
Joshua Peek
eabc036496
Merge pull request #2448 from igrigorik/master
...
Asset pipeline fixes: clear out tmp cache and use environment in digest generation
2011-08-08 07:42:49 -07:00
Vijay Dev
4cf94979c9
edit changelog to mention about x_sendfile_header default change
-
Santiago Pastorino
8845ae683e
x_sendfile_header now defaults to nil and production.rb env file doesn't
...
set a particular value for it. This allows servers to set it through
X-Sendfile-Type, read
https://github.com/rack/rack/blob/master/lib/rack/sendfile.rb for more
info. Anyways you can force this value in your production.rb
2011-08-07 13:11:50 -03:00
Ilya Grigorik
c0bfb5a63c
use assets.version in asset checksum to allow user to easily override
2011-08-05 22:55:56 -07:00
Ilya Grigorik
ed5c6d254c
generate environment dependent asset digests
...
If two different environments are configured to use the pipeline, but
one has an extra step (such as compression) then without taking the
environment into account you may end up serving wrong assets
2011-08-04 23:53:32 -04:00
Ilya Grigorik
e44efac086
Clear out tmp/cache when assets:clean is invoked.
...
Otherwise, if bad data is cached in tmp/clear then the next invocation
of assets:precompile (or a regular incoming request) will pickup files from
tmp without regenerating them from source.
2011-08-04 23:53:32 -04:00
Rashmi Yadav
681d919e48
The trailing '/' isn't being picked up by Github anyway, and the link works as is.
2011-08-04 16:41:31 -07:00
Vijay Dev
d8c77fa16c
document meta method
2011-08-04 16:40:25 -07:00
Santiago Pastorino
d7e55c3429
Merge pull request #2421 from pivotal-casebook/master
...
Simple_format should not edit it in place. (Fixes https://github.com/rails/rails/issues/1980 )
2011-08-04 11:49:43 -07:00
Casebook Developer
f0034c75d5
ActionView::Helpers::TextHelper#simple_format should not change the text in place. Now it duplicates it.
2011-08-04 13:34:47 -04:00
Santiago Pastorino
cf96649bb7
Merge pull request #2356 from waynn/fix_symbol
...
fix stringify_keys destructive behavior for most FormTagHelper functions
2011-08-04 09:29:18 -07:00
Waynn Lue
54b83566cc
fix stringify_keys destructive behavior for most FormTagHelper functions
...
add four new tests to verify that the other three methods that called stringify_keys! are fixed. verified that the tests break in master without the code patch. Closes #2355
2011-08-03 20:53:55 -07:00
thoefer
860202e8b2
Fix the issue where default_url_options is being cached on test cases. Closes #1872 . Closes #2031 .
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2011-08-01 11:49:24 +02:00
José Valim
dc8773b19f
Rename new method to_path to to_partial_path to avoid conflicts with File#to_path and similar.
2011-08-01 11:42:00 +02:00
Santiago Pastorino
d701b3fa47
Merge pull request #2379 from arunagw/extra_require_removal
...
Removing extra requires from the test. Already loaded in abstract_unit.
2011-07-31 11:50:52 -07:00
Arun Agrawal
ec7457ed2a
Removing extra requires from the test. Already loaded in abstract_unit.
2011-07-31 23:36:21 +05:30
Vishnu Atrai
070513016f
remove extra require for 'active_support/dependencies' as it is required in abstract_unit.rb
2011-07-31 23:12:28 +05:30
Waynn Lue
1f270e80e6
remove redundant calls to stringify_keys
2011-07-29 17:07:27 -07:00
Brian Cardarella
1c94ba0332
Instead of removing the instance variable just set it to nil, resolves the warnings because of a missing instance variable
2011-07-29 12:08:35 -04:00
José Valim
caacf85673
Merge pull request #2327 from cesario/patch-1
...
We don't need to require erb here.
2011-07-28 11:24:08 -07:00
José Valim
b295ea1362
Merge pull request #2330 from thedarkone/resources-router-fix
...
Inline resources router fix
2011-07-28 11:10:23 -07:00
thedarkone
a5f57a7ef2
Make use of the inherited initializer.
2011-07-28 20:02:21 +02:00
thedarkone
4d4d2179f6
There is no need to be destructive with the passed-in options.
...
This fixes a bug that is caused by Resource/SingletonResource mangling resource options when using inline "multi"-resource declarations.
2011-07-28 20:00:48 +02:00
Franck Verrot
ad0772f268
We don't need to require erb here.
2011-07-28 18:45:43 +03:00
José Valim
d5eeacc95f
Move the cache to a nested hash which performs better than a hash with array as keys.
2011-07-28 10:01:55 +02:00
José Valim
dee8115539
Rename class method to_path to _to_path and make it explicit that it is an internal method.
2011-07-28 09:56:42 +02:00
