github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
13,255 Commits 34 Branches 105 Tags
a5da48d231bf1e4041e149a8d052d8450e41a4e9
Commit Graph

318 Commits

Author SHA1 Message Date
Joshua Peek
fef7a77386 Request#subdomain returns a string version of Request#subdomains 2010-02-28 17:16:34 -06:00
Joshua Peek
7317d9ef4c Remove implicit controller namespacing from new dsl 2010-02-28 16:39:01 -06:00
Yehuda Katz
8247bd9d3e The instance_reader of default_url_options needs to not exist. 2010-02-27 00:18:16 -08:00
Yehuda Katz
3f0ed205e7 Remind us that RoutingAssertions should work in an integration context 2010-02-26 22:47:36 -08:00
Carlhuda
faf3c2f827 Set the body using the accessor for AD::Response introspection mode so it gets wrapped in a [] 2010-02-26 18:24:55 -08:00
Carlhuda
050831803a If IntegrationSession is initialized with an objects that responds to #routes, automatically extend the URL helpers from the RouteSet onto it 2010-02-26 17:18:45 -08:00
Carlhuda
ab0cc7286f Setting UrlFor in with_routing is no longer needed now that it's not global 2010-02-26 15:56:38 -08:00
Carlhuda
3bad24c85d Remove traces of SharedTestRoutes from user code; leave it as a standin for Rails.application.routes in Rails internal tests 2010-02-26 15:44:22 -08:00
Carlhuda
bae691f61a Change the API for setting global options for #url_for to self.url_options = { ... } 
This attr_accessor can be set in a before filter or in the action itself.
    Overwriting default_url_options still works but will output a deprecation notice.
 2010-02-26 15:20:41 -08:00
Carlhuda
224c0318bd Remove the :use_defaults check in UrlFor#merge options 2010-02-26 15:04:51 -08:00
Carlhuda
98f77e0827 Rename named_url_helpers to url_helpers and url_helpers to url_for 2010-02-26 15:04:50 -08:00
Carlhuda
f863045c45 Rename metaclass to singleton_class 2010-02-25 17:56:58 -08:00
Carlhuda
8760add31a Get URL helpers working again in integration tests. 2010-02-25 17:53:30 -08:00
Carlhuda
fc4582fb66 Final pass at removing the router from a global constant 2010-02-25 17:53:29 -08:00
Carlhuda
36fd9efb5e Continued effort to deglobalize the router 2010-02-25 17:53:01 -08:00
Carlhuda
226dfc2681 WIP: Remove the global router 2010-02-25 17:53:00 -08:00
Jeremy Kemper
f7b0a857e9 Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice. 2010-02-25 09:32:29 -08:00
Carl Lerche
6a061187e2 Remove ActionController::Base.resources_path_names 2010-02-24 10:52:16 -08:00
Carlhuda
5e2bd08023 Makes send_file work again by deferring to Rack::Sendfile. 
* Add the Rack::Sendfile middleware
  * Make the header to use configurable via config.action_dispatch.x_sendfile_header (default to "X-Sendfile"). 
  * Add Railties tests to confirm that these work
  * Remove the :stream, :buffer_size, and :x_senfile default options to send_file
  * Change the log subscriber to always say "Sent file"
  * Add deprecation warnings for options that are now no-ops

Note that servers can configure this by setting X-Sendfile-Type. Hosting companies and those creating packages of servers specially designed for Rails applications are encouraged to specify this header so that this can work transparently.
 2010-02-23 17:06:35 -08:00
Carlhuda
a73f682e43 Make AD::Response correctly handle bodies that respond_to?(:to_path) as per the Rack spec 2010-02-23 16:29:29 -08:00
Martin Schürrer
6bc24d40d5 Use ActionDispatch::Routing everywhere 2010-02-21 13:43:51 -08:00
José Valim
55ae903c3f Store compiled parameter filters so we don't have to compile them in each request. 2010-02-21 14:29:40 +01:00
Carlhuda
a3c6ad7d5e Fix a bunch of pending tests by providing an introspection mode for the Response object that does up-front parsing of the headers to populate things like @etag 2010-02-19 19:19:20 -08:00
José Valim
e49f94d71c Revert behavior from a5684dfa3c and ensure after_initializer is executed after to_prepare callbacks. 2010-02-19 08:15:49 +01:00
José Valim
7189e3c881 Rename router internal option :namespace to :controller_namespace which is its real purpose. 2010-02-17 18:43:42 +01:00
José Valim
3f948a0e29 Merge master. 2010-02-17 00:48:04 +01:00
José Valim
e8ef12e39d Make Railties tests green again. 2010-02-17 00:14:49 +01:00
José Valim
47a236e291 AD::TestProcess relies on request.flash, so let's load it. 2010-02-16 22:54:56 +01:00
José Valim
19787e6259 Should allow symbols in :only and :except in routes. 2010-02-16 22:39:08 +01:00
José Valim
72cb0bf414 Do not swallow controller loading errors unless required. 2010-02-16 22:39:07 +01:00
Joshua Peek
3cecc44cb9 rack-mount 0.5 support 2010-02-15 11:16:56 -06:00
José Valim
4d177d46d9 Routes should not swallow all NameErrors [#3862 status:resolved]. 2010-02-06 11:39:51 +01:00
Santiago Pastorino and José Ignacio Costa
afdf52402e Routing Mapper with % interpolation on Ruby 1.9.1 fixed [#3837 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-02 11:58:38 +01:00
Sam Ruby
df8852d04d Make rdoc match current API 
Signed-off-by: Mikel Lindsaar <raasdnil@gmail.com>
 2010-02-02 12:06:50 +11:00
Joshua Peek
1bd8a50a99 Deprecation notice for TestResponse#redirected_to 2010-01-30 12:26:49 -06:00
José Valim
8974dac92e Ensure root routes inside optional scopes works as expected. 2010-01-26 00:55:26 +01:00
José Valim
02908e1142 As first step setup the load path and lazy compare middlewares. 2010-01-25 22:59:08 +01:00
José Valim
84ebfa4550 Ensure metals and initializers in plugins are loaded. 2010-01-24 14:48:00 +01:00
José Valim
e548f96b1d Rename plugin_name to railtie_name and engine_name. 2010-01-24 12:23:21 +01:00
José Valim
e0bdc4f446 Ensure namespaced controllers in engines work. 2010-01-24 11:06:06 +01:00
José Valim
2fde9d774b Solve some pendencies. 2010-01-24 09:32:54 +01:00
José Valim
80130d1201 Extract routes reloading responsibilities from application and load them just upon a request. 2010-01-23 16:06:33 +01:00
José Valim
fc4f237864 Make filter parameters based on request, so they can be modified for anything in the middleware stack. 2010-01-21 16:52:49 +01:00
José Valim
378464a2e4 Default to sync instrumentation. 2010-01-21 13:09:12 +01:00
José Valim
31fddf2ace Tidy up new filter_parameters implementation. 2010-01-21 11:57:24 +01:00
Prem Sichanugrist
bd4f21fbac Move filter_parameter_logging logic out of the controller and create ActionDispatch::ParametersFilter to handle parameter filteration instead. This will make filteration not depending on controller anymore. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-01-21 10:08:26 +01:00
Sam Ruby
c8cba7db76 Add AD::Route#to_s 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2010-01-20 10:56:27 -06:00
Joshua Peek
93956a18e4 Only send filtered_env for notifications 2010-01-20 10:07:23 -06:00
Joshua Peek
87bcf1aa15 Request#filter_parameters and filter_env 2010-01-20 09:55:58 -06:00
Joshua Peek
909443eab6 Expose last controller in rack env["action_controller.instance"] 2010-01-20 09:00:23 -06:00