github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
23,386 Commits 34 Branches 105 Tags
a6467802ff2be35c6665635f1cdfdcea07aeaa12
Commit Graph

7109 Commits

Author SHA1 Message Date
Andrew White
1fa059cd01 Define ActiveSupport#to_param as to_str - closes #1663 2011-06-12 15:32:46 +01:00
Piotr Sarnacki
e591d14b9c Update changelog with #1552 feature: add hidden field before select[multiple=true] 2011-06-11 18:24:05 +02:00
Piotr Sarnacki
f5e1548c1b Merge pull request #1552 from bogdan/select 
Fixing select[multiple] html specification problem.
 2011-06-11 08:21:22 -07:00
José Valim
e294009b07 No need for a configuration option here. 2011-06-11 17:10:16 +02:00
José Valim
28f2b981fc Merge pull request #549 from dlee/utf8_enforcer 
Utf8 enforcer param customization
 2011-06-11 08:04:06 -07:00
David Lee
9b305983e3 Remove utf8_enforcer_param config option 2011-06-11 01:58:26 -07:00
David Lee
91e3046b71 Make utf8_enforcer_tag an overrideable method 2011-06-11 01:58:26 -07:00
David Lee
fa3fc52069 Make utf8 enforcer param customizeable 2011-06-11 01:58:26 -07:00
David Lee
1cbe917237 There are no snowmen here 2011-06-11 01:58:26 -07:00
Neeraj Singh
f3c9f32664 remove meaningless assert true 2011-06-11 03:11:06 -04:00
Neeraj Singh
6688b6393a expected message should come first 2011-06-11 03:11:06 -04:00
Neeraj Singh
5da89af6f6 try not to use assert_blank when nil will would 
be considered as failure

Test for specific value to the extent possible
 2011-06-11 03:11:05 -04:00
Santiago Pastorino and José Ignacio Costa
94df84a8a4 Revert "Make sure that we don't perform in-place mutation on SafeBuffer string" 
This reverts commit 115e80dccc.
 2011-06-10 23:08:00 -03:00
Santiago Pastorino
adef9764ae Merge pull request #1644 from smartinez87/warns 
Remove unused variable causing warning in 1.9.3
 2011-06-10 18:35:14 -07:00
Sebastian Martinez
c4ddc6f693 Remove unused variable causing warning in 1.9.3 2011-06-10 21:10:06 -03:00
Aaron Patterson
a4ee5038c1 Merge pull request #1642 from sikachu/master-render-inline 
Render inline fix for master
 2011-06-10 16:29:58 -07:00
Xavier Noria
4699c93301 Merge branch 'master' of git://github.com/lifo/docrails 2011-06-11 00:59:46 +02:00
Prem Sichanugrist
115e80dccc Make sure that we don't perform in-place mutation on SafeBuffer string 
This will make sure `render :inline` is working.

Closes #1633
 2011-06-10 18:51:48 -04:00
Prem Sichanugrist
3757798856 Update CHANGELOG to mention the json_escape change, and rearrange stuff a bit. 2011-06-10 18:50:57 -04:00
Andrew White
0bcbcdfdad Ensure number helpers can handle HTML safe strings - closes #1597. 2011-06-10 11:32:28 +01:00
Xavier Noria
90c4885766 Merge pull request #1523 from raghunadhd/refactor_regex 
rafactored the regex related code in the mapper class
 2011-06-10 03:27:45 -07:00
ganesh
262a42b12e shallow_path example updated 2011-06-10 15:53:55 +05:30
Raghunadh
46ecb53fc2 removed the unnecessary back slashes from the regular expression 2011-06-10 13:39:24 +05:30
Neeraj Singh
06d772c0ce add missing ensure 2011-06-10 02:48:44 -04:00
Neeraj Singh
fdbe8eb08c replaced and with && as per coding guidelines 2011-06-10 02:27:57 -04:00
Neeraj Singh
49d032929b The test name is misleading. It says 
test_should_cache_with_trailing_slash_on_url

A trailing slash is removed when a page is cached.

What the test meant to say was : a url with trailing slash
should be cached and the cached page should not have any
trailing slash.

This patch clarifies the name a bit.
 2011-06-10 02:24:37 -04:00
Aaron Patterson
0b02284545 ensuring that json_escape returns html safe strings when passed an html safe string 2011-06-09 15:29:17 -07:00
Prem Sichanugrist
8c8652c37f Make sure escape_javascript return SafeBuffer if the incoming argument is already html_safe 2011-06-09 14:30:02 -04:00
José Valim
834bebf9cc Merge pull request #1606 from neerajdotname/remove_users_controller_from_test 
remove unused UserController from test
 2011-06-09 08:30:45 -07:00
Neeraj Singh
fa5b34ed22 remove unused user_controller from test 2011-06-08 22:49:38 -04:00
Neeraj Singh
277eb05733 class WithSymbolReturningString is not used anywhere in the test. 
Secondly it seemed from the method that the intent was to test a case
where layout was declared in a symbol and the method named mention in
layout returns nil.

That case is already covered with class     class WithSymbolReturningNil .

Also the case of SymbolReturningString is covered with the class
WithSymbol.
 2011-06-08 20:22:13 -04:00
David Heinemeier Hansson
54b0aeba64 Indention style + whitespace for readability 2011-06-09 01:31:06 +02:00
David Heinemeier Hansson
93f30f0536 If you set a js_compressor, it means that you want shit compressed -- we dont need a second option to turn that on 2011-06-09 01:30:58 +02:00
Prem Sichanugrist
7ab06004da Update CHANGELOG to mention the new SafeBuffer change 2011-06-08 11:47:27 -04:00
José Valim
8bc4771291 Merge pull request #1560 from sikachu/master-escapejs 
Make escape_javascript happy to handle SafeBuffers
 2011-06-08 08:08:59 -07:00
Paul Gallagher
bf2f039a93 Make escape_javascript happy to handle SafeBuffers 
* see GH#1553
* allow for the fact that gsub on SafeBuffer does not pass match variables $1, $2 etc to a block
 2011-06-08 11:05:15 -04:00
Neeraj Singh
7fff2f9fe3 Make test meaningful 
If before_filter list was being called mistakenly then
the test should fail. However test will not fail because
second filter is assigning new values to @list. To truly
test that first before_filter is not called when it should
not be called then @list should not assigned value unconditionally.

This patch will make the test fail if first filter is called.
 2011-06-08 10:51:10 -04:00
Bogdan Gusiev
faba406fa1 Fixing select[multiple] html specification problem. 
Generating hidden input with same name before each multiple select
 2011-06-08 12:59:54 +03:00
José Valim
47ac896936 Merge pull request #1549 from neerajdotname/rename_to_method_for_action 
test name should reflect the name of the method
 2011-06-08 00:41:55 -07:00
José Valim
2bf686f4db Merge pull request #1548 from neerajdotname/remove_class_me5 
remove unused class from test
 2011-06-08 00:30:11 -07:00
Neeraj Singh
8f3c9e87d9 test name should reflect the name of the method 
that is actually being called
 2011-06-08 03:17:27 -04:00
Neeraj Singh
cbfdd0df33 remove unused class from test 2011-06-08 02:54:19 -04:00
José Valim
c6503f48bd Merge pull request #1547 from sikachu/safebuffer 
Fix ActionPack tests on `master`
 2011-06-07 23:39:49 -07:00
José Valim
185235333c Merge pull request #1542 from cmeiklejohn/dont_gsub_on_safebuffer 
Don't operate on the safebuffer, operate on a string and convert.
 2011-06-07 23:32:03 -07:00
Prem Sichanugrist
1bbc51e5a7 Fix failing test on uninitialized Rails.config.assets.prefix 
This was introduced in [2684f17a17] 💣
 2011-06-08 02:30:50 -04:00
Prem Sichanugrist
9e2e242655 Add proper fix to mail_to helper. 
* Fix the problem on manipulating on the `ActiveSupport::SafeBuffer`
* Make sure that we run `escape_javascript` on the `String`, to avoid unexpected behavior.
 2011-06-08 02:30:50 -04:00
Prem Sichanugrist
07f2481e15 Adapt [823aa223ef] to make sure we perform cloning before manipulation only on OutputBuffer. 
After the fragment rendering, `Builder` returns the `String` object instead of `ActionView::OutputBuffer`. Somehow the same procedure which was in [823aa223ef] does not play nice with the String, and result in the fragment got lost.
 2011-06-08 02:30:50 -04:00
Santiago Pastorino
1d3618a9b4 remove warning: assigned but unused variable 2011-06-08 00:26:09 -03:00
Christopher Meiklejohn
ef8b12a29e Don't operate on the safebuffer, operate on a string and convert. 2011-06-07 23:07:07 -04:00
Christopher Meiklejohn
823aa223ef Fragment caching needs to operate on the pure output, not the 
safebuffer.
 2011-06-07 22:36:51 -04:00