Andrew White
5d655aabcb
Pass mass-assignment options to nested models - closes #1673 .
2011-06-13 13:02:51 +01:00
Jon Leighton
c52520166b
Make assert_no_queries literally enforce that there are no queries. As in, not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries.
2011-06-12 18:50:24 +01:00
Jon Leighton
232c66a1ba
If we're going to use a global variable, let's at least namespace it
2011-06-12 18:38:39 +01:00
Jon Leighton
b09bbdb8bf
Replace inline lambdas with named methods
2011-06-12 18:19:22 +01:00
Jon Leighton
de01a64102
Move BEGIN and COMMIT into IGNORED_SQL rather than having them as a special case in assert_queries
2011-06-12 18:19:21 +01:00
benedikt
fa8dfad765
Don't wrap operations on collection associations in transactions when they are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database.
2011-06-12 18:19:21 +01:00
Brian Quinn
9f2e91414f
Ensure engine migrations are copied in the same sequence that they are required.
2011-06-10 12:11:45 +01:00
Damien Mathieu
84f71e42b7
don't reinitialize the arel_table unless the table_name changes
2011-06-09 14:56:07 -07:00
José Valim
af3f0b6204
Merge pull request #1591 from smartinez87/unused
...
Fix "warning: assigned but unused variable" on AR tests
2011-06-08 23:36:49 -07:00
Sebastian Martinez
0b86ac244c
Remove unused 'quoted_column_names' variable.
2011-06-08 23:13:43 -03:00
Rodrigo Navarro
8166e4b0c3
No need to create a new Arel::Table, as the arel_table method already creates a new one
2011-06-08 16:56:01 -03:00
Santiago Pastorino
1d3618a9b4
remove warning: assigned but unused variable
2011-06-08 00:26:09 -03:00
Jon Leighton
7d1782a2c1
Allow polymorphic has_one to work when the association is set before the owner has been saved. Fixes #1524 .
2011-06-08 00:32:49 +01:00
Jon Leighton
4f5f6a3257
When you add a record to a polymorphic has_one, you should be able to access the owner from the associated record
2011-06-08 00:32:49 +01:00
Dmitriy Kiriyenko
7c1f73c843
Do not use default_scope in ActiveRecord::Persistence#touch.
2011-06-07 18:42:40 +01:00
Xavier Noria
5e21247131
Merge branch 'master' of git://github.com/lifo/docrails
...
Conflicts:
activerecord/RUNNING_UNIT_TESTS
2011-06-06 22:23:30 +02:00
Vijay Dev
5d8df14d6d
comment the recorder methods
2011-06-07 01:38:03 +05:30
Vijay Dev
428883b579
up and down are no longer class methods in a migration
2011-06-07 01:23:08 +05:30
Guillermo Iguaran
c2c8ef57d6
Remove trailing white-spaces
2011-06-05 10:34:40 -05:00
Andrew White
54883682de
Don't double assign attributes - closes #1467 .
2011-06-03 13:57:00 +01:00
Vijay Dev
6e02164e02
styling changes
2011-06-02 01:08:14 +05:30
Ayose
196c8f13bf
Edited activerecord/lib/active_record/transactions.rb via GitHub
2011-06-01 12:36:16 -07:00
Brian Mathiyakom
1e43bd9f35
Fix issue #1272
...
Set reverse_order_value when asked to reverse_order().
Do the actual reversal in build_arel.
2011-06-01 18:29:29 +01:00
Ayose
3523144ea4
The URL http://dev.mysql.com/doc/refman/5.0/en/savepoints.html is no longer available
2011-06-01 08:47:06 -07:00
Andrew White
cf3364a03c
Raise NameError instead of ArgumentError in ActiveSupport::Dependencies
...
ActiveSupport::Dependencies now raises NameError if it finds an existing
constant in load_missing_constant. This better reflects the nature of
the error which is usually caused by calling constantize on a nested constant.
Closes #1423
2011-06-01 01:16:20 +01:00
Josh Kalderimis
eb7ef2ccd6
added an alias for new to build to the AR collection proxy, this corrects an issue where the collection proxies were not consistent
2011-06-01 00:01:35 +01:00
Jon Leighton
4067d88df5
Revert "[activerecord][postgresql] verify if table has a schema(not public)". This caused a test breakage. See #1410 for details.
...
This reverts commit c44418ea4e
2011-05-31 22:46:13 +01:00
Jon Leighton
fbe012e92d
Ensure that calculations properly override the select value even if it's set in the default scope. Fixes #1395 .
2011-05-31 21:12:20 +01:00
Jon Leighton
dfaad4f5a7
Only save the record once when calling create! on a collection association. Fixes #1360 .
2011-05-31 20:32:09 +01:00
Jon Leighton
60cb96abea
Implementing @dmathieu's cleaner fix from #1425 . Unfortunately he deleted the branch so I cannot just merge it.
2011-05-31 18:34:27 +01:00
Arun Agrawal
2e57b66931
Adding comment to work with 1.8.7. Nested Attribute fix.
2011-05-31 12:12:19 +05:30
Arun Agrawal
cfb5f1b608
Fix nested attribute for memory record.
2011-05-31 11:31:10 +05:30
Aaron Patterson
7278547a5d
Merge pull request #1410 from lucasts/pg_schema
...
a little step to better postgresql schema support in rails
2011-05-30 13:30:07 -07:00
Lee Reilly
4f234bfd79
Corrected some typos and American vs. Queen's English issues
2011-05-29 12:40:24 -07:00
Aaron Patterson
18b153d15d
Merge pull request #1384 from amatsuda/simplify_drop_table
...
Remove unused options from drop_table
2011-05-28 13:36:40 -07:00
Akira Matsuda
bcb466c543
No need to pass options which is never used
2011-05-29 04:30:22 +09:00
Akira Matsuda
d8f4988867
No need to override for just calling super
2011-05-29 04:29:19 +09:00
Vijay Dev
995ea00328
Use change in place of up and down in sessions table migration
2011-05-28 21:59:54 +05:30
Aaron Patterson
c122c7b271
stop using boolean expressions because of the side effects
2011-05-27 14:53:20 -07:00
Aaron Patterson
4b536f7591
Merge pull request #1365 from gnufied/sqlite3
...
close statment only if its not closed
2011-05-27 14:40:32 -07:00
Aaron Patterson
2a9b3abe19
Merge pull request #1229 from workmad3/master
...
Fix for Issue #1205
2011-05-27 14:34:05 -07:00
Hemant Kumar
ed1a0672ab
delegate connection and column_hash calls directly to model
2011-05-28 03:00:11 +05:30
Hemant Kumar
d48add714d
close statment only if its not closed
2011-05-28 02:57:36 +05:30
Aaron Patterson
985ace4d7f
work around bug in the sqlite3 bindings. fixes #1289
2011-05-27 14:12:28 -07:00
Lucas Stephanou
c44418ea4e
[activerecord][postgresql] verify if table has a schema(not public)
2011-05-27 17:48:34 -03:00
Lucas Stephanou
055c6fb010
find sequences with pg schemas properly
2011-05-27 16:39:19 -03:00
Sebastian Martinez
dfba8f544b
Fix font styling on associations.rb
2011-05-26 17:51:20 -03:00
Jon Leighton
602fff1f58
Merge pull request #1323 from fx/association_primary_key
...
use association_primary_key in AssociationScope#add_constraints
2011-05-26 13:08:10 -07:00
Jon Leighton
09e431aa89
Merge pull request #1318 from TheEmpty/master
...
Resolve issue #534
2011-05-26 12:54:38 -07:00
John Mileham
043b624390
Don't merge base opts into includes when serializing ARs
...
Conflicts:
activerecord/lib/active_record/serialization.rb
2011-05-26 11:40:57 -04:00
