github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-08 13:15:23 -05:00
Code Issues Packages Projects Releases Wiki Activity
6,891 Commits 34 Branches 105 Tags
a7ea06b4ebe252e258f83e7de945b4baa30ec3bc
Commit Graph

85 Commits

Author SHA1 Message Date
Pratik Naik
e520fd5db7 Delegate action_name to controller inside views. 2008-05-06 12:02:24 +01:00
Pratik Naik
a04f022877 Delegate ivars to controller instead of copying 
Reduce number of instance variables being copied from controller to
view. Instead, delegate them to controller instance.
 2008-04-21 11:53:14 +01:00
Pratik Naik
2b69840e5e Remove ActionController::Base#view_controller_internals 
Get rid of ActionController::Base#view_controller_internals flag and
use @@protected_view_variables for storing the list of controller
specific instance variables which should be inaccessible inside views.
 2008-04-21 03:45:38 +01:00
Pratik Naik
ef4c65088f Move missing template logic to ActionView 2008-04-19 18:59:13 +01:00
Jeremy Kemper
9cc478a254 Support render :partial => collection of heterogeneous elements. Closes #11491. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-04-01 00:50:09 +00:00
Michael Koziarski
51b6619d4e Refactor partial rendering into a PartialTemplate class. [Pratik] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-03-03 04:01:35 +00:00
David Heinemeier Hansson
7dcd0d7d96 Added that requests with JavaScript as the priority mime type in the accept header and no format extension in the parameters will be treated as though their format was :js when it comes to determining which template to render. This makes it possible for JS requests to automatically render action.js.rjs files without an explicit respond_to block [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8956 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-29 18:09:23 +00:00
Marcel Molina
c848c4c621 Fix problem with render :partial collections, records, and locals. #11057 [lotswholetime] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-08 22:04:06 +00:00
Jeremy Kemper
0da2aa6d11 Introduce the :index option for form_for and fields_for to simplify multi-model forms (see http://railscasts.com/episodes/75). Closes #9883. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 06:16:04 +00:00
Michael Koziarski
61c90a4ad6 Reapply the TemplateFinder first applied in [8669] then reverted in [8676]. Closes #10800 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8683 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-21 20:45:04 +00:00
Jeremy Kemper
88bc014acc Revert r8669 for now, breaks Action Mailer. Reopens #10800. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8676 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 06:01:57 +00:00
Jeremy Kemper
84b0f9c739 Introduce TemplateFinder to handle view paths and lookups. Closes #10800. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 03:20:39 +00:00
Michael Koziarski
b812b23687 Make render :partial recognise form builders and use the _form partial. Closes #10814 [djanowski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-16 02:01:57 +00:00
Jeremy Kemper
9d755f1983 require abstract_unit directly since test is in load path 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-05 13:32:06 +00:00
David Heinemeier Hansson
d5645fd4a0 Fixed rendering of partials with layout when done from site layout (closes #9209) [antramm] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-03 15:28:36 +00:00
Jeremy Kemper
7555073803 Ruby 1.9 compat: introduce instance_variable_names. Closes #10630 [Frederick Cheung] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-28 05:42:12 +00:00
Jeremy Kemper
93ec552e9b Fix up template handler tests. Closes #10437. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 20:41:59 +00:00
Jeremy Kemper
4d2ae8a699 Partials also set 'object' to the default partial variable. Closes #8823. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8018 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 21:32:01 +00:00
Michael Koziarski
f81dae3fca Remove deprecated functionality from actionpack. Closes #8958 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-03 00:18:30 +00:00
David Heinemeier Hansson
bbbc45156b Added partial layouts (see example in action_view/lib/partials.rb) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-02 20:10:03 +00:00
Michael Koziarski
b549366216 Introduce fake_models.rb to avoid platform-specific code. [mpalmer] Closes #8714 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-17 09:44:03 +00:00
Rick Olson
4b9e67c5b9 catch possible WSOD when trying to render a missing partial. Closes #8454 [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 16:42:10 +00:00
Jeremy Kemper
f7bb3ddce8 Fix render :location => ... test. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 05:25:17 +00:00
David Heinemeier Hansson
ebee0a742d Added url_for usage on render :location, which allows for record identification [DHH] (still need to figure out why that test doesnt pass, seems like a test issue) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-17 20:48:47 +00:00
David Heinemeier Hansson
82d70d1d16 Added that render :xml will try to call to_xml if it can [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6574 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-24 18:29:37 +00:00
Jeremy Kemper
83c8db9818 Deprecation: remove deprecated instance variables. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 03:49:52 +00:00
David Heinemeier Hansson
e105653066 Added .erb and .builder as preferred aliases to the now deprecated .rhtml and .rxml extensions [Chad Fowler]. This is done to separate the renderer from the mime type. .erb templates are often used to render emails, atom, csv, whatever. So labeling them .rhtml doesn't make too much sense. The same goes for .rxml, which can be used to build everything from HTML to Atom to whatever. .rhtml and .rxml will continue to work until Rails 3.0, though. So this is a slow phasing out. All generators and examples will start using the new aliases, though. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-20 22:09:12 +00:00
David Heinemeier Hansson
9e4c8b8858 Fix tests depending too deep 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-19 02:25:01 +00:00
Rick Olson
69b0e5c44a Allow Controllers to have multiple view_paths instead of a single template_root. Closes #2754 [John Long] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 20:47:05 +00:00
Jeremy Kemper
89b472aa0c Test proving render_to_string result passed to partial works. Closes #2541. [smeade] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 06:10:06 +00:00
Jeremy Kemper
6fc8e143c6 Ensure render_to_string cleans up after itself when an exception is raised. Closes #6658. Great tests! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-20 11:03:21 +00:00
Jeremy Kemper
57313c54bf assert_response supports symbolic status codes. Closes #6569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5466 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-07 21:45:10 +00:00
Jeremy Kemper
d7674637f9 Deprecation: @request will be removed after 1.2. Use the request method instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 07:34:02 +00:00
Jamis Buck
c0eccc9aef modify head so that you can specify a bare status code as the first parameter 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-28 19:32:40 +00:00
Jamis Buck
b2ede64a89 Add ActionController::Base#head for rendering empty responses. Add support for symbolic status codes, as well as for having raw integer statuses expand with their default messages. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5199 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-28 19:13:55 +00:00
Sam Stephenson
236cf90bf1 Update RJS render tests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-20 20:14:12 +00:00
David Heinemeier Hansson
2caf4d5a93 Added proper getters and setters for content type and charset [DHH] Added utf-8 as the default charset for all renders. You can change this default using ActionController::Base.default_charset=(encoding) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-17 16:20:32 +00:00
Jeremy Kemper
ea831469a9 new render deprecations test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 05:09:18 +00:00
David Heinemeier Hansson
7d06259be9 Dots in template path should not trip up rendering (closes #4244) [lmarlow@yahoo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3884 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-16 02:51:19 +00:00
Sam Stephenson
3589871de8 Added simple alert() notifications for RJS exceptions when config.action_view.debug_rjs = true. Set debug_rjs = true for the default development environment. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3856 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-13 02:11:59 +00:00
David Heinemeier Hansson
de660957a5 Added defaults to respond_to [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3842 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-12 03:39:58 +00:00
David Heinemeier Hansson
1c16649b48 Added better support for using the same actions to output for different sources depending on the Accept header [DHH] Added Base#render(:xml => xml) that works just like Base#render(:text => text), but sets the content-type to text/xml and the charset to UTF-8 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-11 01:23:29 +00:00
Rick Olson
043bee3338 Re-added mixed-in helper methods for the JavascriptGenerator. Moved JavascriptGenerators methods to a module that is mixed in after the helpers are added. Also fixed that variables set in the enumeration methods like #collect are set correctly. Documentation added for the enumeration methods [Rick Olson]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-08 05:21:27 +00:00
David Heinemeier Hansson
5f724b516c Fixed tests (closes #4087) [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 16:35:27 +00:00
David Heinemeier Hansson
16b9409a9c allow RJS enum values to be passed to visual_effect() and other scriptaculous helpers #4080 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3772 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 06:42:58 +00:00
David Heinemeier Hansson
1812dbbfde Make RJS treat symbolic action names nicely #3861 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-17 18:32:21 +00:00
Nicholas Seckar
d2adec438e Ensure assigns are copied to the template when using render :update. Closes #3620. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-30 04:49:17 +00:00
Sam Stephenson
9c52a41241 Add the ability to call JavaScriptGenerator methods from helpers called in update blocks 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3476 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-23 17:09:15 +00:00
Sam Stephenson
4d49f2ca09 Fix render(:update) to not render layouts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3472 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-23 16:29:37 +00:00
Sam Stephenson
06dd1f2ca3 Add render :update for inline RJS 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-20 22:04:07 +00:00