Commit Graph

7128 Commits

Author SHA1 Message Date
Xavier Noria
146ec2d1df Merge branch 'master' of git://github.com/lifo/docrails 2011-06-18 10:11:47 +02:00
Bogdan Gusiev
69fdfab487 Select tag helpers: remove some code dups 2011-06-17 16:54:35 +03:00
R.T. Lechow
6ca18f9037 Typo. 2011-06-16 15:44:21 -04:00
wycats
1844572fd1 Make the API for compression consistent between JS and CSS. By default, users just need to say whether they want compression or not, and a default will be chosen by a Railtie. In the case of CSS, this default is already chosen by the sass-rails gem.
Users can still explicitly choose a compressor in their application.rb if they have a preference, but will usually want to let plugins choose defaults in their Railties.
2011-06-16 12:09:36 -07:00
Santiago Pastorino
eedbe1c827 Use html_safe 2011-06-16 12:46:11 -03:00
José Valim
f2c0fb32c0 Remove usage of memoizable from ActionPack. 2011-06-16 08:01:35 -03:00
Wen-Tien Chang
d7aac1f1e4 Also change the default route comment 2011-06-16 14:03:41 +08:00
Vijay Dev
77c8cd7516 form => form_for 2011-06-15 18:56:22 +05:30
Christine Yen
0a67b745be Tweak linebreak in ActionController::Redirecting doc 2011-06-15 03:18:28 -07:00
Christine Yen
c6381657b7 Clarify importance of *_attributes= writer methods for nested fields 2011-06-15 03:15:58 -07:00
Lukáš Konarovský
c0d82ba030 Use assert_equal instead of assert in uploaded file test. 2011-06-15 03:09:27 -07:00
Christine Yen
8da91036c0 Improve documentation around status code argument of redirect_to 2011-06-15 01:55:57 -07:00
Damien Mathieu
0438e92ae7 simplify to only one condition
Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
2011-06-15 09:51:36 +01:00
Andrew White
0ac0d7a0f0 Make MissingTranslation exception handler respect :rescue_format 2011-06-15 01:21:04 +01:00
Joshua Peek
56b301fa7a Fix appending sprockets paths 2011-06-14 14:39:34 -05:00
bagwanpankaj
c424fb29ab Removed warning while running test with ruby 1.9.2 2011-06-14 21:56:27 +05:30
Damien Mathieu
383fd143bf all requests are utf-8. Don't use the external encoding. 2011-06-14 17:01:33 +02:00
Damien Mathieu
383d56b5ee encode the uploaded file's name in the default external encoding - Closes #869 2011-06-14 14:34:30 +02:00
Robert Massaioli
d7a2431408 cycle: make an odd number be marked as odd.
Just a minor issue that was annoying me so I thought that I would jump in and fix it.
2011-06-13 14:58:56 +10:00
Andrew White
1fa059cd01 Define ActiveSupport#to_param as to_str - closes #1663 2011-06-12 15:32:46 +01:00
Piotr Sarnacki
e591d14b9c Update changelog with #1552 feature: add hidden field before select[multiple=true] 2011-06-11 18:24:05 +02:00
Piotr Sarnacki
f5e1548c1b Merge pull request #1552 from bogdan/select
Fixing select[multiple] html specification problem.
2011-06-11 08:21:22 -07:00
José Valim
e294009b07 No need for a configuration option here. 2011-06-11 17:10:16 +02:00
José Valim
28f2b981fc Merge pull request #549 from dlee/utf8_enforcer
Utf8 enforcer param customization
2011-06-11 08:04:06 -07:00
David Lee
9b305983e3 Remove utf8_enforcer_param config option 2011-06-11 01:58:26 -07:00
David Lee
91e3046b71 Make utf8_enforcer_tag an overrideable method 2011-06-11 01:58:26 -07:00
David Lee
fa3fc52069 Make utf8 enforcer param customizeable 2011-06-11 01:58:26 -07:00
David Lee
1cbe917237 There are no snowmen here 2011-06-11 01:58:26 -07:00
Neeraj Singh
f3c9f32664 remove meaningless assert true 2011-06-11 03:11:06 -04:00
Neeraj Singh
6688b6393a expected message should come first 2011-06-11 03:11:06 -04:00
Neeraj Singh
5da89af6f6 try not to use assert_blank when nil will would
be considered as failure

Test for specific value to the extent possible
2011-06-11 03:11:05 -04:00
Santiago Pastorino and José Ignacio Costa
94df84a8a4 Revert "Make sure that we don't perform in-place mutation on SafeBuffer string"
This reverts commit 115e80dccc.
2011-06-10 23:08:00 -03:00
Santiago Pastorino
adef9764ae Merge pull request #1644 from smartinez87/warns
Remove unused variable causing warning in 1.9.3
2011-06-10 18:35:14 -07:00
Sebastian Martinez
c4ddc6f693 Remove unused variable causing warning in 1.9.3 2011-06-10 21:10:06 -03:00
Aaron Patterson
a4ee5038c1 Merge pull request #1642 from sikachu/master-render-inline
Render inline fix for master
2011-06-10 16:29:58 -07:00
Xavier Noria
4699c93301 Merge branch 'master' of git://github.com/lifo/docrails 2011-06-11 00:59:46 +02:00
Prem Sichanugrist
115e80dccc Make sure that we don't perform in-place mutation on SafeBuffer string
This will make sure `render :inline` is working.

Closes #1633
2011-06-10 18:51:48 -04:00
Prem Sichanugrist
3757798856 Update CHANGELOG to mention the json_escape change, and rearrange stuff a bit. 2011-06-10 18:50:57 -04:00
Andrew White
0bcbcdfdad Ensure number helpers can handle HTML safe strings - closes #1597. 2011-06-10 11:32:28 +01:00
Xavier Noria
90c4885766 Merge pull request #1523 from raghunadhd/refactor_regex
rafactored the regex related code in the mapper class
2011-06-10 03:27:45 -07:00
ganesh
262a42b12e shallow_path example updated 2011-06-10 15:53:55 +05:30
Raghunadh
46ecb53fc2 removed the unnecessary back slashes from the regular expression 2011-06-10 13:39:24 +05:30
Neeraj Singh
06d772c0ce add missing ensure 2011-06-10 02:48:44 -04:00
Neeraj Singh
fdbe8eb08c replaced and with && as per coding guidelines 2011-06-10 02:27:57 -04:00
Neeraj Singh
49d032929b The test name is misleading. It says
test_should_cache_with_trailing_slash_on_url

A trailing slash is removed when a page is cached.

What the test meant to say was : a url with trailing slash
should be cached and the cached page should not have any
trailing slash.

This patch clarifies the name a bit.
2011-06-10 02:24:37 -04:00
Aaron Patterson
0b02284545 ensuring that json_escape returns html safe strings when passed an html safe string 2011-06-09 15:29:17 -07:00
Prem Sichanugrist
8c8652c37f Make sure escape_javascript return SafeBuffer if the incoming argument is already html_safe 2011-06-09 14:30:02 -04:00
José Valim
834bebf9cc Merge pull request #1606 from neerajdotname/remove_users_controller_from_test
remove unused UserController from test
2011-06-09 08:30:45 -07:00
Neeraj Singh
fa5b34ed22 remove unused user_controller from test 2011-06-08 22:49:38 -04:00
Neeraj Singh
277eb05733 class WithSymbolReturningString is not used anywhere in the test.
Secondly it seemed from the method that the intent was to test a case
where layout was declared in a symbol and the method named mention in
layout returns nil.

That case is already covered with class     class WithSymbolReturningNil .

Also the case of SymbolReturningString is covered with the class
WithSymbol.
2011-06-08 20:22:13 -04:00