github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-28 07:48:00 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,133 Commits 34 Branches 105 Tags
af0df03fd3bd020edbdeb00a18d11129fef1a60b
Commit Graph

644 Commits

Author SHA1 Message Date
Marcel Molina
af0df03fd3 Update DB2 adapter. Closes #2206. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2546 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 23:42:54 +00:00
Marcel Molina
f175547e58 Corrections to SQLServer native data types. Closes #2267. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2545 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 23:13:07 +00:00
Marcel Molina
b840e4ed50 Deprecated ActiveRecord::Base.threaded_connection in favor of ActiveRecord::Base.allow_concurrency. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 22:37:28 +00:00
Marcel Molina
0e0e774085 Protect id attribute from mass assigment even when the primary key is set to something else. Closes #2438. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 19:59:13 +00:00
Marcel Molina
f0b2b637ea Add test coverage for customized primary keys including a failing test for #2444. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2540 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 19:55:46 +00:00
Marcel Molina
2948910b56 Misc doc fixes (typos/grammar/etc.). Closes #2430. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 03:55:49 +00:00
Marcel Molina
31219f009c Add test coverage for content_columns. Closes #2432. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2532 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 03:51:58 +00:00
Marcel Molina
cb8c807085 Fix typo in CHANGELOG. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 03:42:10 +00:00
Marcel Molina
dcc2263b3a Speed up for unthreaded environments. Closes #2431. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2530 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 03:40:11 +00:00
Marcel Molina
31ae8121e4 Optimization for Mysql selects using mysql-ruby extension greater than 2.6.3. Closes #2426. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2529 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 03:10:07 +00:00
Marcel Molina
d736568f41 Speed up the setting of table_name. Closes #2428. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2520 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 18:59:56 +00:00
Jamis Buck
08fbdc1d43 move lib/version.rb to lib/active_record/version.rb 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2513 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 14:28:41 +00:00
Marcel Molina
eb2fbf05c6 Optimize instantiation of STI subclass records. In partial fullfilment of #1236. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2511 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 22:26:54 +00:00
Marcel Molina
f4d1af3085 Fix typo of 'constrains' to 'contraints'. Closes #2069. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 22:08:16 +00:00
Marcel Molina
89733eaecf Optimization refactoring for add_limit_offset!. In partial fullfilment of #1236. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 21:42:40 +00:00
Marcel Molina
68a322005d Add versioning convention from SwitchTower to all Rails components. Add --version, -v option to the 'rails' command. Closes #1840. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 21:15:45 +00:00
Marcel Molina
c8e364a93f Add ability to get all siblings, including the current child, with acts_as_tree. Recloses #2140. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2507 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 18:51:30 +00:00
Marcel Molina
64cd4e4170 PostgreSQL returns the path type wrapped in quotes. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 01:22:47 +00:00
Marcel Molina
e30699f660 Add geometric type for postgresql adapter. Closes #2233. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2498 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 00:52:25 +00:00
Marcel Molina
80cd2f6645 Move require_library_or_gem out of AR's abstract_adapter and into ActiveSupport. closes #1992 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2490 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-08 07:48:37 +00:00
Jeremy Kemper
60a60f9798 Don't tell me about defined reader methods, even at debug level. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2489 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-07 18:22:40 +00:00
Marcel Molina
f218771d3e Add option (true by default) to generate reader methods for each attribute of a record to avoid the overhead of calling method missing. In partial fullfilment of #1236. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2483 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-07 00:53:05 +00:00
Marcel Molina
c0899bca10 Add convenience predicate methods on Column class. In partial fullfilment of #1236. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2482 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 23:19:55 +00:00
Marcel Molina
e8b427cdef Raise an exception when invalid options are passed to ActiveRecord::Base.find. Closes #2363. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2481 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 22:21:10 +00:00
Jeremy Kemper
bcb50f3c89 sqlite topics.approved should default to true like the other dbs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 21:52:47 +00:00
Jeremy Kemper
c2da5e57cd Remove straggling symbolize_strings_in_hash from [2427]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2479 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 17:16:47 +00:00
Jeremy Kemper
164625ca1f Fixup tests for [2474]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2478 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 17:13:24 +00:00
Tobias Lütke
ebfddf35b9 Add rename_table to mysql, sqlite and postgres adapters for use in migrations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2477 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 14:10:45 +00:00
Michael Koziarski
7e70fc1e9d Allow in memory sqlite DBs when RAILS_ROOT is defined [blair@orcaware.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2476 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 04:56:00 +00:00
Jeremy Kemper
78d6cc085a smallint -> boolean in pg sql 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2475 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 04:52:32 +00:00
Michael Koziarski
656fb866f9 Quote booleans according the rules defined by the adapter 
* SQLite schema has been updated
* Postgresql schema needs to be fixed too
Simplify AR::Base#toggle to store the boolean, not the quoted value
* expand the tests


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 04:15:14 +00:00
David Heinemeier Hansson
0639e1ca7c Added :force option to create_table that'll try to drop the table if it already exists before creating 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 03:20:28 +00:00
Jamis Buck
d364164763 Schema dumper should emit ":default => false" if the default for a column is false 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2464 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-05 13:37:00 +00:00
David Heinemeier Hansson
810ebf7c6a Forced newer versions of RedCloth to use hard breaks [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-02 20:21:43 +00:00
Jeremy Kemper
e19bd169fa Association validation does not belong in a before_save callback: move it into a validation method. Restores the expected model.valid? == model.save. Add tests for cancelling save by returning false from a before_save callback. Remove assumption that before_destroy's return value indicates whether the record was destroyed. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-02 02:00:50 +00:00
Jeremy Kemper
f98ec352b6 Get rid of old symbolize_strings_in_hash. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 12:10:04 +00:00
Jeremy Kemper
ee5fe97ac4 Ticket #2282 - fix parsing of timestamps with time zone 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 12:09:13 +00:00
Jeremy Kemper
3f1aad8ac9 No need to string.to_s right after checking that string.is_a?(String) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 04:34:07 +00:00
Jeremy Kemper
e828657973 Move transaction thread-safety test to transactions_test. Check that simultaneous transactions don't step on each others' toes. Check that simultaneous transactions don't give dirty reads (read-committed txn isolation or greater.) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 03:39:15 +00:00
Jeremy Kemper
4ce9b4c557 Use transactional fixtures by default for AR tests. Set ENV['AR_NO_TX_FIXTURES'] to yes to disable. Tidy up abstract_unit. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 01:00:04 +00:00
Jeremy Kemper
093a87d1a3 Require topic model rather than assume another test has already. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 00:58:26 +00:00
Jeremy Kemper
110360f858 Disable transactional fixtures for ar_schema_test and schema_test_postgresql 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2414 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 00:57:27 +00:00
Nicholas Seckar
6f38041133 Fix broken testcase for transactions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 11:16:51 +00:00
Jeremy Kemper
67d1e0cd3d Clean up and extend test coverage for validates_numericality_of 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 02:35:41 +00:00
Nicholas Seckar
fc83920383 Fix transactions so that calling return while inside a transaction will not leave an open transaction on the connection. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 18:53:22 +00:00
Marcel Molina
0d07152aab Make schema definition column lookups agnostic w/r/t/ whether a key or symbol is passed. Fixes failing test in [2396]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 18:07:18 +00:00
Marcel Molina
f43d97a860 Add failing test that shows that AR::Migration.remove_column fails silently with SQLite when passed arguments as symbols. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2396 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 17:50:28 +00:00
Jeremy Kemper
db8f727229 Ticket #2156 - Use foreign_key inflection uniformly 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 09:14:33 +00:00
Jeremy Kemper
dd21e9ae39 r3657@asus: jeremy | 2005-09-28 00:32:33 -0700 
Also test that client.firm_id.nil? after firm.clients.clear when clients is not :dependent


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2385 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 04:00:59 +00:00
Jeremy Kemper
efaf2af07c r3653@asus: jeremy | 2005-09-28 00:23:49 -0700 
Ticket 2221 - model.association.clear should destroy associated objects if :dependent => true instead of nullifying their foreign keys


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2384 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 03:52:57 +00:00