github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
25,842 Commits 34 Branches 105 Tags
b454601be403bd58af4a93b459f98ff4e2d211ea
Commit Graph

3721 Commits

Author SHA1 Message Date
Jon Leighton
7776055e2d Revert "Skip test_default_external_works on the CI for Ruby 1.9.3." 
This reverts commit 10773f94ea.
 2011-11-06 10:39:59 +00:00
Jon Leighton
10773f94ea Skip test_default_external_works on the CI for Ruby 1.9.3. 
This test is affected by a bug in Ruby 1.9.3p0 and trunk:
http://redmine.ruby-lang.org/issues/5564

Given we cannot fix it for ourselves, it is better to skip for now so
that we will easily see if further failures are introduced.

Jon Leighton is monitoring the bug report and will revert this when a
suitable solution is found (either a new Ruby release or a generic
workaround).

If you are using 1.9.3 in your app and have templates that are not in
UTF-8, you should add a workaround early on in the boot process. For
example, if your templates are Shift_JIS encoded, then add the
following in an initializer:

Encoding::Converter.new('Shift_JIS', 'UTF-8')
 2011-11-05 16:42:53 +00:00
Vijay Dev
cb06727b6c add tests for the case where size is explicitly passed to number_field helper 2011-11-04 22:32:40 +05:30
Waseem Ahmad
56207a3f01 Remove 'size' attribute from number_field form helper fixes #3454 
f.number_field generates <input type="number", size="30"../> which is
invalid HTML5. See: http://dev.w3.org/html5/spec/Overview.html#number-state
 2011-11-04 15:03:02 +05:30
Jon Leighton
b5f908a7ad Stub find_template so that when handle_render_error is called in ActionView::Template, we get to see the actual underlying error rather than a NoMethodError. 
This shows an encoding bug on Ruby 1.9.3.
 2011-11-03 19:08:09 +00:00
Christopher Meiklejohn
6cbe4223a7 Ensure that the format isn't applied twice to the cache key, else it becomes impossible to target with expire_action. 2011-10-31 15:10:07 -04:00
Santiago Pastorino
408bbfe6bd Merge pull request #3435 from MDaubs/action_pack_deprecations 
Fix deprecation warnings in action pack render tests
 2011-10-26 00:36:36 -07:00
José Valim
80768b739e Responders now return 204 No Content for API requests without a response body (as in the new scaffold) 2011-10-26 09:31:56 +02:00
Aaron Patterson
450257c95b properly handle lists of lists. Thanks @adrianpike for reporting! 2011-10-25 17:44:17 -07:00
Matthew Daubert
f7e56a3ab6 Fix deprecation warnings in action pack test suite due to passing template formats in the template name. 2011-10-25 15:11:45 -04:00
Arun Agrawal
244dcfea47 ActionPack test fix for RBX 2011-10-24 14:11:20 +05:30
Arun Agrawal
50dfd58fdb Warnings removed from RequestIdTest 2011-10-22 16:30:48 +05:30
Brian Durand
2b04c2f66e Add ActionDispatch::Session::CacheStore as a generic way of storing sessions in a cache. 2011-10-21 13:13:29 -05:00
José Valim
f1fecd9b4e Make tests run on 1.8.x, add integration setup. 2011-10-19 22:09:36 +02:00
David Heinemeier Hansson
ada78066fd Blah, SecureRandom#uuid is not supported in 1.8.7 -- cant wait for Rails 4.0 to drop compatibility with 1.8.x 2011-10-19 14:45:42 -05:00
David Heinemeier Hansson
afde6fdd5e Added X-Request-Id tracking and TaggedLogging to easily log that and other production concerns 2011-10-19 12:59:33 -05:00
Jeremy Kemper
401d00d296 Symbol captures may generate multiple path segments, so don't escape / -> %2F. Test splat escaping. 2011-10-13 21:42:15 -07:00
Jeremy Kemper
bceec4c3c3 / is allowed in URI fragments 2011-10-13 21:41:30 -07:00
Jeremy Kemper
45ced7e1be Failing tests for path parameter escaping 2011-10-13 19:02:58 -07:00
Santiago Pastorino
a5b0f914f1 Merge pull request #3314 from macmartine/master 
Remove user-specified delimiter from start when no area code is present (in number_to_phone)
 2011-10-13 16:26:55 -07:00
Santiago Pastorino
8f11d53506 Merge pull request #2219 from kommen/fix_fragment_caching_squashed 
Fix fragment caching (squashed commits)
 2011-10-13 13:36:20 -07:00
Mac Martine
20728f551c remove user-specified delimiter from start when no area code is present (in number_to_phone) 2011-10-12 17:06:44 -07:00
Alexey Vakhov
50d262f52a Support symbol and string actions in AC#respond_to options 2011-10-11 12:48:03 +04:00
Diego Carrion
8f863742e3 allow shorthand routes with nested optional parameters 2011-10-10 19:53:42 -03:00
Denis Odorcic
a0a68ecbb2 JSON responder should return errors with :error root 2011-10-10 01:42:12 -04:00
José Valim
2ed66feae0 Merge pull request #3262 from subdigital/master 
Add optional host option to force_ssl
 2011-10-09 02:52:42 -07:00
José Valim
501e5b0d7f Merge pull request #3196 from avakhov/patch-am-av-tests-2 
Improve tests method for ActionView::TestCase and ActionMailer::TestCase
 2011-10-09 02:15:19 -07:00
Liborio Cannici
114218e4da Fixes an issue when creating a date select with too many options. 
Inspired by dlt 9e61563474

Closes #239.

Conflicts:

	actionpack/CHANGELOG
 2011-10-08 18:02:15 -07:00
Ben Scheirman
d68f27e9b1 accept optional :host parameter to force_ssl 2011-10-08 18:38:02 -05:00
Aaron Patterson
7f64e47277 just check to see that the first item in the list is an array 2011-10-07 16:56:18 -07:00
Santiago Pastorino
fd8f0b2978 stylesheet_link_tag('/stylesheets/application') and similar helpers doesn't throw Sprockets::FileOutsidePaths exception anymore 2011-10-05 15:41:28 -02:00
José Valim
c495bfc127 Do not require railtie as it messes up Rails.application setup. 2011-10-05 15:31:38 +02:00
José Valim
87c57bb88f Fix the lame config.action_controller.present? check scattered throughout assets_path. 
Conflicts:

	actionpack/test/template/sprockets_helper_test.rb
 2011-10-05 02:35:43 +02:00
José Valim
5711a35ad8 Ensure default_asset_host_protocol is respected, closes #2980. 2011-10-05 02:08:02 +02:00
Kamil Sobieraj
de942e5534 :subdomain can now be specified with a value of false in url_for, allowing for subdomain(s) removal from the host during link generation. Closes #2025 2011-10-04 09:16:34 +01:00
Alexey Vakhov
8df7fe3f63 normalize arg for ActionView::TestCase tests method 2011-10-03 14:27:42 +04:00
Alexey Vakhov
8e946daf69 normalize arg for AC::TestCase tests class method 2011-10-03 12:12:07 +04:00
José Valim
6e8fe1bf02 TestCase should respect the view_assigns API instead of pulling variables on its own. 2011-10-02 11:29:13 +02:00
Santiago Pastorino
64b0c8888b javascript_path and stylesheet_path should honor the asset pipelining 2011-09-28 20:13:24 -03:00
Wen-Tien Chang
3058d13a06 Make button_to helper support "form" option which is the form attributes. 2011-09-29 01:40:15 +08:00
Christos Zisopoulos
b8ea31540a Correctly override image_path in sprockets rails_helper 2011-09-26 18:45:49 +02:00
Santiago Pastorino
d6cff93152 Just assert_equal here 2011-09-26 12:20:52 -03:00
Santiago Pastorino
2c3a5075b6 Merge pull request #3135 from christos/respect_assets_digest_value 
Give precedence to `config.digest = false` over the existence of manifest.yml asset digests
 2011-09-26 08:16:02 -07:00
Santiago Pastorino
b855327443 image_tag should use /assets if asset pipelining is turned on. Closes #3126 2011-09-26 11:20:30 -03:00
Christos Zisopoulos
793e9da63d Give precedence to config.digest = false over manifest.yml asset digests 2011-09-26 14:27:04 +02:00
Vijay Dev
541018a07b fix deprecation warning in cookie_store_test 
The options argument to MessageVerifier#initialize should be a hash.
 2011-09-25 23:21:37 +05:30
Evgeniy Dolzhenko
86cf3fb5fa Implement Mime::Type#respond_to? (consistently with #method_missing) 2011-09-25 13:03:01 +01:00
José Valim
933ba0cf6e Merge pull request #3124 from avakhov/patch-6-stylesheet-link 
escape options for the stylesheet_link_tag method
 2011-09-25 04:03:13 -07:00
Alexey Vakhov
5ffa69793f escape options for the stylesheet_link_tag method 2011-09-25 09:40:49 +04:00
Guillermo Iguaran
038808ba1a Add public API for register new js and css compressors for Sprockets 2011-09-24 19:22:13 -05:00