raggi
d8692985fe
Don't depend on rubygems loading thread (for Mutex)
2010-11-25 06:47:27 +08:00
Neeraj Singh
66212f69ac
If a nested_attribute is being marked for destruction and at the same time an attr_accessor value is being assigned then the value being assigned is being ignored. This patch is a fix for that issue.
...
[#5939 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-11-24 22:08:36 +01:00
Franck Verrot
47f39d26a7
Testing that dup is resetting the timestamps
2010-11-25 01:18:43 +08:00
Aaron Patterson
a551d2ec62
fixing variable names. oops!
2010-11-23 17:42:49 -08:00
Neeraj Singh
d33dcba72d
Do not send id for quoting twice if the primary key is string.
...
[#6022 state:resolved]
2010-11-23 14:33:00 -08:00
Aaron Patterson
d717cb2913
clone and dup are working on 1.8
2010-11-23 14:29:05 -08:00
Aaron Patterson
fe4388eb15
converting clone test to dup test
2010-11-23 14:29:05 -08:00
Aaron Patterson
064c28d6c2
fixing dup regressions
2010-11-23 14:29:05 -08:00
Aaron Patterson
93d78b8318
fixing more dup tests
2010-11-23 14:29:05 -08:00
Aaron Patterson
6a8f1b8b40
renaming duplication test to dup test
2010-11-23 14:29:04 -08:00
Aaron Patterson
c5858a6df3
adding a specific case for clone testing
2010-11-23 14:29:04 -08:00
Aaron Patterson
28f4df0908
testing duped attributes are independent
2010-11-23 14:29:04 -08:00
Aaron Patterson
035d00b665
making sure changes to dup will not touch original
2010-11-23 14:29:04 -08:00
Aaron Patterson
5badf60d12
dup keeps changes
2010-11-23 14:29:04 -08:00
Aaron Patterson
ca7b0a0d1a
dup is working better
2010-11-23 14:29:03 -08:00
Aaron Patterson
4d31ee1e0e
removing unused variables
2010-11-22 16:14:37 -08:00
Alex Rothenberg
66c09372f3
Removed ids_in_list_limit in favor of in_clause_length defined in database_limits.rb
2010-11-23 06:43:18 +08:00
Josh Kalderimis
d7db6a8873
class inheritable attributes is used no more! all internal use of class inheritable has been changed to class_attribute. class inheritable attributes has been deprecated.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-11-20 19:40:29 +01:00
Aaron Patterson
938243feb9
do not require ruby-debug automatically. please require it if you have declared it as a dependency
2010-11-19 16:26:09 -08:00
Aaron Patterson
598fc85f9e
fisting typeo, thanks @vinibaggio
2010-11-19 11:42:58 -08:00
Aaron Patterson
87124457e5
fisting my spelling errors
2010-11-19 10:55:57 -08:00
Aaron Patterson
0cc6c46fe9
testing a non-invertible migration case
2010-11-19 10:50:24 -08:00
Aaron Patterson
47017bd169
invertable migrations are working
2010-11-19 10:31:03 -08:00
Aaron Patterson
6519df4157
command recorder will record commands sent to a delegate object
2010-11-19 10:24:16 -08:00
Aaron Patterson
6dbbfae563
adding invertable migration test
2010-11-19 10:24:16 -08:00
Aaron Patterson
96b50a0392
IrreversibleMigration is raised if we cannot invert the command
2010-11-19 10:24:15 -08:00
Aaron Patterson
b29a24bb6f
commands are reversed
2010-11-19 10:24:15 -08:00
Aaron Patterson
843e319f78
partial implementation of the command recorder
2010-11-19 10:24:15 -08:00
Aaron Patterson
e107dcca6b
testing multiple ORd queries
2010-11-18 13:39:57 -08:00
Aaron Patterson
26923756fb
removing space errors
2010-11-18 10:01:29 -08:00
Alex Rothenberg
c5a284f8eb
Adapters can specify maximum number of ids they support in a list of expressions
...
(default is nil meaning unlimited but Oracle imposes a limit of 1000)
Limit is used to make multiple queries when preloading associated has_many or habtm records
2010-11-18 09:59:52 -08:00
Santiago Pastorino
c6bfd6802a
When use where more than once on the same column, relation doesn't do an 'or' or 'in' with the values
2010-11-17 17:15:25 -08:00
Jon Leighton
fe42c00ac3
Fix bug with 0bb85ed9ff which missed out a fixtures declaration in cascaded_eager_loading_test.rb
2010-11-17 15:52:18 -08:00
Aaron Patterson
68b66ef308
testing instance based migrations
2010-11-17 14:26:35 -08:00
Aaron Patterson
0bea9fd6be
schema migrations work as instances
2010-11-17 14:26:34 -08:00
Aaron Patterson
8b2f801ed8
converted migrations to support instance methods
2010-11-17 14:26:34 -08:00
Aaron Patterson
77440ec51a
fixing assertions so error messages will be more helpful
2010-11-17 13:02:03 -08:00
Aaron Patterson
2738ec891b
removing many unused variables
2010-11-16 17:06:50 -08:00
Aaron Patterson
c801f233df
reloading an association will properly set attributes of instantiated objects. Thanks Brian Palmer [ #5802 state:resolved]
2010-11-16 14:28:19 -08:00
Alexandru Catighera
a5cdf0b9eb
Fix ActiveRecord calculations when grouped by multiple fields
2010-11-16 10:38:47 -08:00
Piotr Sarnacki
437ceab139
Create directory before copying migrations if it does not exist
2010-11-16 17:00:01 +01:00
Santiago Pastorino
4718d097ff
Models should be equals even after destroyed
...
[#5978 state:committed]
2010-11-16 12:40:40 -02:00
Aaron Patterson
ace84a003c
support finding by a ruby class [ #5979 state:resolved]
2010-11-15 20:25:43 -08:00
Aaron Patterson
7bf9cbb766
adding more test coverage around finding with active record objects
2010-11-15 15:30:58 -08:00
Aaron Patterson
dcdfc84f55
use quoted id of single AR::Base objects in predicates
2010-11-15 14:35:38 -08:00
Neeraj Singh
7c5c1a07c0
if association is already loaded and if a find operation is performed on the already loaded association list with an empty hash then do not perform another sql
...
[#5972 state:resolved]
2010-11-15 10:12:23 -08:00
Aaron Patterson
022519a032
fisting a bunch of unused variable warnings
2010-11-15 10:12:09 -08:00
Jason Cheow
93c9f4a942
Fix bug where size of through association is not correct after adding a has_many association (occurs only before main object has been reloaded).
...
[#5968 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-11-14 15:32:52 -02:00
Franck Verrot
983976ec54
Finder gives a little bit more info on the lookup column (primary key)
2010-11-13 06:32:08 +08:00
Franck Verrot
de2933e1a0
STI type is now updated when calling AR::Base.becomes on subclasses [ #5953 state:resolved]
2010-11-12 02:17:34 +08:00