github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-31 01:08:19 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,243 Commits 34 Branches 105 Tags
b9ffbd3166fae25fe3b18c60ce2de2bdde166fb5
Commit Graph

1335 Commits

Author SHA1 Message Date
Jamis Buck
e411b545a5 a few more deprecation improvements 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5360 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-24 17:27:16 +00:00
Jamis Buck
e5684a2877 update deprecations to include alternative methods (where available) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5359 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-24 17:25:30 +00:00
Michael Koziarski
53a97e9d61 Make add_column use the options hash with the Sqlite Adapter. Closes #6464 [obrie] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-24 07:32:18 +00:00
Marcel Molina
fb7807e244 Document other options available to migration's add_column. #6419 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5333 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-22 02:55:21 +00:00
Jeremy Kemper
8949ce0982 MySQL: all_hashes compatibility with old MysqlRes class. Closes #6429. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5330 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 20:30:59 +00:00
Rick Olson
c5536f9f00 Fix has_many :through to add the appropriate conditions when going through an association using STI. Closes #5783. [Jonathan Viney] (sorry, forgot to commit the actual files) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5310 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 15:42:55 +00:00
Rick Olson
cdb5132c41 Fix has_many :through to add the appropriate conditions when going through an association using STI. Closes #5783. [Jonathan Viney] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5305 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-15 16:37:11 +00:00
Rick Olson
2c6b6e2866 automatically add primary key to #select_limited_ids_list order by clause for databases that require order columns in the distinct statements (postgresql) [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5292 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 08:52:33 +00:00
Rick Olson
e789b26e65 fix select_limited_ids_list issues in postgresql, retain current behavior in other adapters [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5291 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 08:29:00 +00:00
Rick Olson
ce1d14430f add test for select_limited_ids_list that passes in mysql/sqlite and fails in postgresql 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5290 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 07:46:38 +00:00
Rick Olson
7870494673 Restore eager condition interpolation, document it's differences [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-11 14:02:24 +00:00
Jeremy Kemper
1117387376 Compare to 0 rather than call zero? to handle nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5282 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-11 00:29:59 +00:00
Jeremy Kemper
629b8af2b0 Wrap save! in a transaction. Closes #6324. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-10 19:34:25 +00:00
Jeremy Kemper
f65ab3b233 improve example in migrations docs, closes #6370 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 22:05:50 +00:00
Jeremy Kemper
2c3ca4c4e6 Don't rollback in teardown unless a transaction was started. Don't start a transaction in create_fixtures if a transaction is started. Closes #6282. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 07:48:27 +00:00
Rick Olson
850087f0bd Add #delete support to has_many :through associations. Closes #6049 [Martin Landers] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 03:21:52 +00:00
Rick Olson
4e66f5bfe7 learn to clean up after myself 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5266 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 03:13:06 +00:00
Rick Olson
c98b471ca4 Reverted old select_limited_ids_list postgresql fix that caused issues in mysql. Closes #5851 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 03:12:32 +00:00
Rick Olson
8e3bf70bcd Removes the ability for eager loaded conditions to be interpolated, since there is no model instance to use as a context for interpolation. #5553 [turnip@turnipspatch.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5264 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:46:57 +00:00
David Heinemeier Hansson
fe4d5ea786 Fixed rename_table on SQLite tables with indexes defined (closes #5942) [brandon@opensoul.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:14:36 +00:00
David Heinemeier Hansson
fc7fd4c5ce Docfix (closes #6040) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:05:50 +00:00
David Heinemeier Hansson
943be923f0 Added timeout option to SQLite3 configurations to deal more gracefully with SQLite3::BusyException, now the connection can instead retry for x seconds to see if the db clears up before throwing that exception (closes #6126) [wreese@gmail.com] Added default timeout setting of 5 seconds to SQLite3 database.yml configurations [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:02:27 +00:00
David Heinemeier Hansson
8f93516168 Docfix (closes #5143) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:53:51 +00:00
David Heinemeier Hansson
55aab5b8ac Added update_attributes! which uses save! to raise an exception if a validation error prevents saving (closes #6192) [jonathan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:52:24 +00:00
David Heinemeier Hansson
9fd88d7939 Deprecated add_on_boundary_breaking (use validates_length_of instead) (closes #6292) [BobSilva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:42:09 +00:00
David Heinemeier Hansson
cb0837a2b7 Doc fixes (closes #6325) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:32:11 +00:00
Jeremy Kemper
0c3c131f3b The has_many create method works with polymorphic associations. Closes #6361. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-08 06:45:32 +00:00
Jeremy Kemper
54e86cccd5 Update RUNNING_UNIT_TESTS for current Rake tasks. Closes #6349. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-05 18:19:24 +00:00
Jamis Buck
b8ff69fcdd callbacks that return false should cause save to return false 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-04 15:43:31 +00:00
Jamis Buck
53737eadd6 add a failing test so we can make it happy again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5225 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-04 15:38:59 +00:00
Jeremy Kemper
48d4d43f92 MySQL: introduce Mysql::Result#all_hashes to support further optimization. Closes #5581. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5219 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 20:43:13 +00:00
Jeremy Kemper
ef4fb3dee2 save! shouldn't validate twice. Closes #6324. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 03:21:32 +00:00
Jeremy Kemper
0092d0ac6d Association collections have an _ids reader method to match the existing writer for collection_select convenience (e.g. employee.task_ids). The writer method skips blank ids so you can safely do @employee.task_ids = params[:tasks] without checking every time for an empty list or blank values. References #1887, Closes #5780. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5214 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-01 19:15:51 +00:00
Rick Olson
52547f5331 Add an attribute reader method for ActiveRecord::Base.observers [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-30 01:37:07 +00:00
Jeremy Kemper
25cce68013 Use class name as XML_TYPE_NAMES key. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5210 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 22:45:58 +00:00
Jeremy Kemper
f0152fb610 Include caller of deprecated count method. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 07:48:16 +00:00
Jeremy Kemper
a0bf0195a5 Deprecation: count class method should be called with an options hash rather than two args for conditions and joins. Closes #6287. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5192 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-26 17:02:45 +00:00
Jeremy Kemper
1caa76304b has_one associations with a nil target may be safely marshaled. Closes #6279. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5188 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-26 06:56:17 +00:00
Jeremy Kemper
148261a9ef organize associations tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-25 06:38:55 +00:00
Jeremy Kemper
9898a62bf7 use a real test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5180 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-25 05:58:38 +00:00
Michael Koziarski
83d972e365 Duplicate the hash provided to AR::Base#to_xml to prevent unexpected side effects [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-24 01:37:45 +00:00
Michael Koziarski
98a412aa38 Add a :namespace option to AR::Base#to_xml [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-17 16:31:30 +00:00
David Heinemeier Hansson
5d50dee71f Version updates and missing licenses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-15 10:13:27 +00:00
Jeremy Kemper
760f6ae3f4 Stray code. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5117 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-15 07:11:38 +00:00
Jeremy Kemper
3f1acf49bd Deprecation tests. Remove warnings for dynamic finders and for the foo_count ethod if it's also an attribute. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5116 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-15 07:02:05 +00:00
Jeremy Kemper
3ab1cb6a6a Mock Time.now for more accurate Touch mixin tests. Closes #6213. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-14 00:50:42 +00:00
Jeremy Kemper
5589c734a8 Improve yaml fixtures error reporting. Closes #6205. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 23:31:54 +00:00
David Heinemeier Hansson
e2d8451024 We cant make MySQL 5 happy if it means making SQLite and PostgreSQL cry. So currently MySQL 5 is not fully supported for Rails when youre using eager loading (closes #6133, #6135). I have contacted MySQL to make them fix http://bugs.mysql.com/bug.php?id=13551 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 22:01:00 +00:00
David Heinemeier Hansson
84bfdafa08 Added parentheses around FROM clauses generated by Base and associations since MySQL 5 claim that to be the standard (and will screw up joins if its not there), see http://bugs.mysql.com/bug.php?id=13551 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5073 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 18:14:02 +00:00
Jeremy Kemper
7c4b6a55b6 Rollback [4917]. Closes #785. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5067 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 21:34:35 +00:00