Commit Graph

875 Commits

Author SHA1 Message Date
Jeremy Kemper
b0d01921d8 Rewind request body after reading it, if possible. Closes #8438.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6815 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-23 05:43:00 +00:00
Tobias Lütke
19fbd84e12 Rescuing in around_filters works as expected again [codahale, Stephan Kaes]. Closes #8341
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-22 19:17:43 +00:00
Jeremy Kemper
def8f101b8 Strip junk whitespace from [6806].
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-22 09:38:54 +00:00
Jeremy Kemper
5a3b4cf0bc Resource namespaces are inherited by their has_many subresources. Closes #8280.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6806 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-22 09:37:07 +00:00
Jeremy Kemper
8ba22a690c Fix filtered parameter logging with nil parameter values. Closes #8422.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-21 23:01:17 +00:00
Jeremy Kemper
d1c957d067 Integration tests: alias xhr to xml_http_request and add a request_method argument instead of always using POST. Closes #7124.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6796 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-21 09:15:16 +00:00
Jeremy Kemper
055ff9f418 Fix incorrent content type lookup in request parsing. Closes #8407.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-19 21:34:36 +00:00
Tobias Lütke
1008535905 Allow routes to be declared off namespaces
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6783 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-19 16:26:44 +00:00
Jeremy Kemper
4221494348 observe_form always sends the serialized form. Closes #5271.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-18 21:27:05 +00:00
Jeremy Kemper
c597e7d9ac Include location header in args.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-18 21:23:07 +00:00
Jeremy Kemper
d2ed32d592 Parse url-encoded and multipart requests ourselves instead of delegating to CGI.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-18 06:24:50 +00:00
Jeremy Kemper
b6541b8dcc select :include_blank option can be set to a string instead of true, which just uses an empty string. Closes #7664.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-18 05:29:22 +00:00
Jeremy Kemper
f7bb3ddce8 Fix render :location => ... test.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-18 05:25:17 +00:00
Jeremy Kemper
1ac7cd56fe Clean up the simply_helpful merge.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-18 00:36:14 +00:00
David Heinemeier Hansson
ebee0a742d Added url_for usage on render :location, which allows for record identification [DHH] (still need to figure out why that test doesnt pass, seems like a test issue)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-17 20:48:47 +00:00
Tobias Lütke
04823ff48f Allow nested namespaces in routing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-17 01:27:54 +00:00
Jeremy Kemper
73fbf7771b Add multipart and url-encoded form mime types.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-15 23:57:16 +00:00
Jeremy Kemper
f73e1c2ec0 Move request parameter parsing from CGI to AbstractRequest.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6742 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-15 22:10:03 +00:00
Jeremy Kemper
32d03af341 Introduce the request.body stream. Lazy-read to parse parameters rather than always setting RAW_POST_DATA. Reduces the memory footprint of large binary PUT requests.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-15 21:36:21 +00:00
Rick Olson
ebf9b3737b Add some performance enhancements to ActionView.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-15 06:36:34 +00:00
Rick Olson
fa3618d375 add test case for js.erb partials on *.js formatted requests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6735 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-15 03:15:36 +00:00
Rick Olson
80074cb4de Assume that rendered partials go by the HTML format by default
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6734 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-15 03:13:32 +00:00
Jeremy Kemper
f8273e4309 Shine some sunlight on the CGI extensions. Remove unused CGI#session.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6733 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-15 00:08:05 +00:00
David Heinemeier Hansson
6e7b593992 Added record identifications to FormHelper#form_for and PrototypeHelper#remote_form_for [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-14 17:30:35 +00:00
Jeremy Kemper
50253edec9 Rationalize route path escaping according to RFC 2396 section 3.3. Closes #7544, #8307.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6730 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-14 11:14:30 +00:00
David Heinemeier Hansson
c769ad8533 Removed deprecated parameters_for_method_reference concept (legacy from before named routes) [DHH] Added record identification with polymorphic routes for ActionController::Base#url_for and ActionView::Base#url_for [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-12 21:12:31 +00:00
Nicholas Seckar
2ca6f57f85 Add broken test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6724 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-12 04:46:17 +00:00
Nicholas Seckar
a5fe13e871 Add ActionController::Routing::Helpers, a module to contain common URL helpers such as polymorphic_url.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6722 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-12 04:18:46 +00:00
David Heinemeier Hansson
20eb59ad8a Included the HttpAuthentication plugin as part of core (ActionController::HttpAuthentication::Basic) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6699 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-08 05:48:18 +00:00
Marcel Molina
b7565075c3 More documentations for typos in routes. Closes #8228 [pam]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6673 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-06 04:26:49 +00:00
Marcel Molina
dac6aae7f8 Sweep flash when filter chain is halted. Closes #6175. [Caio Chassot <lists@v2studio.com>]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-06 04:17:01 +00:00
Michael Koziarski
67ca9224d7 Bug fix for the filter implementation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-06 04:10:26 +00:00
David Heinemeier Hansson
edaf6baea7 Fixed that content_tag with a block will just return the result instead of concate it if not used in a ERb view #7857, #7432 [michael.niessner]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-02 22:30:41 +00:00
Rick Olson
0778464168 Replace the current block/continuation filter chain handling by an implementation based on a simple loop. #8226 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-02 13:22:38 +00:00
Nicholas Seckar
5a3bb880db Update UrlWriter to accept :anchor parameter. Closes #6771.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6648 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-02 04:40:33 +00:00
David Heinemeier Hansson
da257eb81b Added the first part of Simply Helpful to core. The rest is pending a clean integartion of polymorphic urls [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-30 01:17:56 +00:00
David Heinemeier Hansson
70ac560e42 Removed breakpointer and Binding.of_caller in favor of relying on ruby-debug by Kent Sibilev since the breakpointer has been broken since Ruby 1.8.4 and will not be coming back [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-28 15:57:29 +00:00
David Heinemeier Hansson
8326a15784 Added map.namespace to deal with the common situation of admin sections and the like [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6594 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-27 16:58:36 +00:00
David Heinemeier Hansson
f985bfd8f8 Added test case for overwritting the name prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6593 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-27 05:10:23 +00:00
David Heinemeier Hansson
8bf1f25254 Name prefix should nest like path prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-27 05:07:56 +00:00
David Heinemeier Hansson
0adf4a97c1 Actually make the name_prefix work like the previous checkin said it would
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6590 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-27 05:06:38 +00:00
David Heinemeier Hansson
63aea3ffa9 Added :has_many and :has_one for declaring plural and singular resources beneath the current [DHH] Added :name_prefix as standard for nested resources [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-26 23:11:31 +00:00
David Heinemeier Hansson
6a85955642 Added parsing of file type in Hash.xml_in so you can easily do file uploads with base64 from an API [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6578 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-25 17:25:44 +00:00
David Heinemeier Hansson
82d70d1d16 Added that render :xml will try to call to_xml if it can [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6574 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-24 18:29:37 +00:00
David Heinemeier Hansson
5208d8d817 Added :location option to render so that the common pattern of rendering a response after creating a new resource is now a 1-liner [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-24 17:52:03 +00:00
Jeremy Kemper
38d574c6a3 Expect string response body.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6559 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-24 04:12:11 +00:00
Rick Olson
f86ff9fd52 oops! forgot new layout for layout tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6554 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-24 01:26:44 +00:00
Rick Olson
eb7a3045e3 apply [6543] to edge. Closes #5044 [tpope]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6545 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-20 21:44:08 +00:00
Rick Olson
596112dcf8 remove useless mock test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-12 20:26:42 +00:00
Rick Olson
6351e0a541 The default respond_to blocks don't set a specific extension anymore, so that both 'show.rjs' and 'show.js.rjs' will work. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-12 20:25:32 +00:00