github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,905 Commits 34 Branches 105 Tags
c019db8ca1c5639fdae80915cc7520eaad7dcd65
Commit Graph

412 Commits

Author SHA1 Message Date
Santiago Pastorino
cad8bef5ea Bump up rdoc to 2.5.10 2010-08-18 11:44:12 -03:00
Xavier Noria
a0ca3d1067 Merge remote branch 'docrails/master' 2010-08-18 00:25:32 +02:00
Xavier Noria
ea2ad26a8d you rarely want ^ or $ in validations, use \A when you mean \A 2010-08-18 00:15:01 +02:00
Trey Bean
bee414748c Missing object for comparison in ActiveModel::EachValidator example code. 2010-08-17 12:51:13 -06:00
Xavier Noria
fb6b805620 code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them 2010-08-17 03:32:11 +02:00
José Valim
d0cf212cb5 to_key should return all exists keys (if any exists), regardless if the object is persisted or not. If you need it to reflect persistance, you should use to_param. 2010-08-15 11:29:15 -03:00
Subba Rao Pasupuleti
e516378410 Adding missing required statement 
[#5056 state:resolved]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-14 13:17:32 +02:00
Santiago Pastorino
b95d6e84b0 Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 13:17:32 +02:00
Subba Rao Pasupuleti
f8f437191f no callbacks should be created for empty array [#5289 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-14 13:17:30 +02:00
Subba Rao Pasupuleti
b61ff257e9 tidy up validations length code [#5297 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-14 13:17:29 +02:00
Greg Campbell
1577eafe77 Add missing ActiveModel::Validations require 
[#5311 state: resolved]

ActiveModel::Validations uses Hash#except, but does not require it from
ActiveSupport.  (This wasn't showing up in the tests, because it was
required in the helper, and was also required in
ActiveModel::Serialization).

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-14 13:17:29 +02:00
Subba Rao Pasupuleti
b7fdc937fa Adding missing required statement 
[#5056 state:resolved]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-14 06:27:15 -03:00
Santiago Pastorino
b451de0d6d Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:12:33 -03:00
Subba Rao Pasupuleti
ef0da581e9 no callbacks should be created for empty array [#5289 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-12 13:12:26 -03:00
Subba Rao Pasupuleti
e82b38cd57 tidy up validations length code [#5297 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-12 13:12:03 -03:00
Greg Campbell
90a7915ab2 Add missing ActiveModel::Validations require 
[#5311 state: resolved]

ActiveModel::Validations uses Hash#except, but does not require it from
ActiveSupport.  (This wasn't showing up in the tests, because it was
required in the helper, and was also required in
ActiveModel::Serialization).

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-12 13:11:48 -03:00
Xavier Noria
4134d7db34 Merge remote branch 'docrails/master' 2010-08-12 17:36:09 +02:00
Paco Guzman
8a2b69b727 applied guidelines to "# =>" 2010-08-12 17:09:58 +02:00
Santiago Pastorino
a6c6cbfb55 ActiveModel::Base doesn't exist, include_root_in_json is a class_attribute for the classes which includes this module 2010-08-10 11:53:58 -03:00
Xavier Noria
fff917e37d fixes a typo reported by rymai 2010-08-10 15:34:54 +02:00
Adam Meehan
9a43640ed1 typo in AM 2010-08-09 13:44:04 +10:00
Xavier Noria
3e678240f4 edit pass to AMo::Serializers::JSON 2010-08-06 13:56:38 +02:00
Xavier Noria
3cbe111439 Merge remote branch 'docrails/master' 2010-08-05 01:15:57 +02:00
Neeraj Singh
589e6977d7 adding documentation to ActiveSupport::Concern ht:strictly typed for an awesome example 
some minor documentation changes
 2010-08-04 17:03:03 -04:00
Subba Rao Pasupuleti
8d9d8bc93c Tidy up error.rb code 
[#5288 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-03 14:54:13 -03:00
José Valim
84081fcc54 Freeze options so we raise an error when people modify it in place. 2010-08-03 15:36:23 +02:00
José Valim
f23bc8444b validates_length_of should not change the options hash in place. [#5283 state:resolved] 2010-08-03 15:22:54 +02:00
rohit
621246f997 Failing test for validates_length_of, when both too_short and too_long messages are set [#5283 state:open] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 15:11:51 +02:00
Tore Darell
2c8a4a53a8 Remove or fix non-working examples and add a few tests to Dirty [#5185 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:47:30 +02:00
Neeraj Singh
fb2b8fec24 adding test cases for ActiveModel::Errors 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:46:16 +02:00
Neeraj Singh
74f7e172c7 fixing documentation 2010-08-03 04:14:14 -04:00
Alex Le
aeaab06c79 ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 16:26:32 +02:00
Xavier Noria
ccd45618ed Merge remote branch 'rails/master' 2010-07-30 02:35:24 +02:00
Xavier Noria
755af49755 edit pass to apply API guideline wrt the use of "# =>" in example code 2010-07-30 02:30:04 +02:00
Neeraj Singh
1a6d76223b expanding on the will_change! method in documentation 2010-07-29 09:18:29 -04:00
David Heinemeier Hansson
856fc4bbc3 Prep for RC 2010-07-26 12:53:25 -05:00
Xavier Noria
6aa1253588 Merge remote branch 'docrails/master' 2010-07-26 00:23:57 +02:00
Aaron Patterson
b50635a59f update Rakefiles for RDoc 2.5 2010-07-23 21:11:29 +02:00
Santiago Pastorino
b378b19430 Makes Rakefile activate rdoc >= 2.5.9 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-07-23 00:04:06 +02:00
Mislav Marohnić
3e196db6ad improve Active Model README 
- fix indentation problems
 - revised introductory text to state right away what the library is
 - improved examples: reduce heavy usage of ellipsis,
   don't mark paragraphs of text as code
 2010-07-22 10:03:55 +02:00
Neeraj Singh
aa2235be7b replacing around with for in the comments for callbacks 2010-07-22 01:28:30 +02:00
Santiago Pastorino
d16c5cc99b Change some missing README -> README.rdoc 2010-07-22 01:47:06 +08:00
José Valim
53310614d7 Reuse already existing classes for ActiveModel tests. 2010-07-21 13:00:56 +02:00
José Valim
508fba9e07 Add .rdoc extension to README files. 2010-07-21 12:51:14 +02:00
Piotr Sarnacki
6807b08099 Moved a few methods from RecordIdentifier to ActiveModel::Naming 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 11:29:58 +02:00
José Valim
b22c11fa53 Add missing entries and tidy up CHANGELOG. 2010-07-19 15:14:26 +02:00
Neeraj Singh
c9630d9d87 adding proper markup to comment 2010-07-16 09:58:01 -04:00
Santiago Pastorino
060ca6abce Add missing require to use Set 2010-07-11 02:55:47 -03:00
Santiago Pastorino
16c14f7465 Avoid interpreted as grouped expression warnings 2010-07-11 02:55:38 -03:00
José Valim
87f64ef05e Improve a bit the code in latest commits. 2010-07-08 22:59:41 +02:00