github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 16:58:15 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,278 Commits 34 Branches 105 Tags
c11ca0e0bfec41215da2c19b2a09435da2e4450e
Commit Graph

939 Commits

Author SHA1 Message Date
Rick Olson
0fc77b3928 correct the ActionCacheTest from [7346] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-20 13:48:13 +00:00
Rick Olson
1a459e8e7d Fix bug where action caching sets the content type to the ActionCachePath object. Closes #9282 [mindforge] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-20 01:12:43 +00:00
Rick Olson
4954c77b69 add missing layouts from [7321] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-15 21:12:50 +00:00
Rick Olson
0127e586d0 Find layouts even if they're not in the first view_paths directory. Closes #9258 [caio] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-15 18:59:37 +00:00
Michael Koziarski
55f444e694 Send freshness information when sending Etags. Without this internet explorer will not send conditional gets for a resource, but instead hold on to the responses for the current browser session. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-12 22:32:19 +00:00
Michael Koziarski
ab5e1f15a6 Fix number_to_human_size when using different precisions. Closes #7536. [RichardStrand, mpalmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-05 01:00:54 +00:00
David Heinemeier Hansson
bbbc45156b Added partial layouts (see example in action_view/lib/partials.rb) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-02 20:10:03 +00:00
Rick Olson
bdcbfa9944 Allow you to set custom :conditions on resource routes. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-25 02:47:21 +00:00
David Heinemeier Hansson
937a7abe45 Fixed that file.content_type for uploaded files would include a trailing \r #9053 [bgreenlee] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-24 01:20:18 +00:00
Tobias Lütke
9014bf3f26 * url_for now accepts a series of symbols representing the namespace of the record [Josh Knowles]. Closes #8640 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7197 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-19 13:42:11 +00:00
Michael Koziarski
b549366216 Introduce fake_models.rb to avoid platform-specific code. [mpalmer] Closes #8714 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-17 09:44:03 +00:00
Michael Koziarski
5476a6a6c7 Make :trailing_slash work with query parameters for url_for. Closes #4004 [nov] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7186 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-14 09:28:56 +00:00
Michael Koziarski
d4d4a08f6b Make sure missing template exceptions actually say which template they were looking for. Closes #8683 [dasil003] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-11 23:32:02 +00:00
Michael Koziarski
e80fabbbf4 Fix errors with around_filters which do not yield, restore 1.1 behaviour with after filters. Closes #8891 [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-11 02:29:25 +00:00
Tobias Lütke
187e1f85d0 Support for non heterogeneous arrays when serializing to xml. Unless guessable from array name the type name will be included as attribute 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7173 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-09 22:07:39 +00:00
Michael Koziarski
fd65d89e07 Allow you to delete cookies with options. Closes #3685 [josh, Chris Wanstrath] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-01 23:27:59 +00:00
Rick Olson
a450e769f1 Allow you to render views with periods in the name. Closes #8076 [norbert] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-01 00:04:03 +00:00
David Heinemeier Hansson
20045df260 Temporary fix for formatted_polymorphic_urls and other polys that have additional options (need better testing!) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-28 22:27:59 +00:00
Jeremy Kemper
557e19346a Prefix nested resource named routes with their action name, e.g. new_group_user_path(@group) instead of group_new_user_path(@group). The old nested action named route is deprecated in Rails 1.2.4. Closes #8558. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7138 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-27 08:38:55 +00:00
Jeremy Kemper
a72fe4ea45 Give the legacy X-POST_DATA_FORMAT header greater precedence during params parsing for backward compatibility. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-26 01:19:18 +00:00
David Heinemeier Hansson
4de8c63abb Fixed that link_to with an href of # when using :method will not allow for click-through without JavaScript (closes #7037) [stevenbristol/josh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-23 17:11:01 +00:00
David Heinemeier Hansson
62a9203a5e Fixed that radio_button_tag should generate unique ids (closes #3353) [BobSilva/rebecca/josh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7093 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-23 16:58:31 +00:00
David Heinemeier Hansson
73fba4faf1 Fixed that HTTP authentication should work if the header is called REDIRECT_X_HTTP_AUTHORIZATION as well (closes #6754) [mislaw] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-23 16:43:08 +00:00
Jeremy Kemper
9159489872 Don't mistakenly interpret the request uri as the query string. Closes #8731. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-23 00:13:40 +00:00
Rick Olson
7f517348db Make ActionView#view_paths an attr_accessor for real this time. Also, don't perform an unnecessary #compact on the @view_paths array in #initialize. Closes #8582 [dasil003, julik, rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7034 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-15 23:52:37 +00:00
Jeremy Kemper
17927cbddc Improve UrlRewriter tests. Improve helper test coverage. Closes #7207, #7208, #7212. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-13 01:34:16 +00:00
Jeremy Kemper
71b77a3d6a Improve helper test coverage. Closes #7215, #7233, #7234, #7235, #7236, #7237, #7238. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-13 01:20:55 +00:00
Jeremy Kemper
c0c001839c Take advantage of Mocha support for sequenced returns. Closes #8639 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-13 00:55:11 +00:00
Jeremy Kemper
979c22444d Tolerate missing content type on multipart file uploads. Fix for Safari 3. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-12 07:44:23 +00:00
Jeremy Kemper
43c6d7ee95 Deprecation: remove pagination. Install the classic_pagination plugin for forward compatibility, or move to the superior will_paginate plugin. Closes #8157. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-11 00:51:11 +00:00
Jeremy Kemper
160af194e4 Routing: improve static segment test coverage. #7117 [Kevin Clark] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6979 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-09 04:39:01 +00:00
Jeremy Kemper
a308ff0cdd Test javascript_tag. Closes #7239. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-08 22:20:18 +00:00
Jeremy Kemper
c9397e684c Action caching is limited to GET requests returning 200 OK status. Closes #3335. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-08 05:01:35 +00:00
Jeremy Kemper
b195ed61c8 Improve Text Helper test coverage. Closes #7274. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-08 04:05:35 +00:00
Jeremy Kemper
34b94de8b8 Improve Action View test coverage. Closes #7241, #7243, #7244. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-08 04:00:15 +00:00
Jeremy Kemper
bab8966064 Test periodically_call_remote with frequency. Closes #7244 [Rich Collins] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-08 01:30:47 +00:00
Jeremy Kemper
c7df5bd6ac More nested polymorphic url helper fixes. Closes #6432, references #8601. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-07 21:35:01 +00:00
Jeremy Kemper
5600776e30 Fix incomplete work from [6951] that was hidden by test stubs. Closes #6432. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-06 16:52:37 +00:00
Jeremy Kemper
5dd3db8615 Resources: url_for([parent, child]) generates /parents/1/children/2 for the nested resource. Likewise with the other simply helpful methods like form_for and link_to. Closes #6432. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6951 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 19:10:59 +00:00
Rick Olson
b83efadb32 Assume html format when rendering partials in RJS. #8076 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6950 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 16:51:49 +00:00
Jeremy Kemper
7709df5f17 Don't double-escape url_for in views. Closes #8144. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 04:29:19 +00:00
Jeremy Kemper
f80468c3c3 Remove junk form helper test. Closes #8416 [eric_oconnell] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 04:09:39 +00:00
Thomas Fuchs
3cfb894bac Allow JSON-style values for the :with option of observe_field. Closes #8557 [kommen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-03 14:27:43 +00:00
Jeremy Kemper
8ce5479307 Routing: map.resource :logo routes to LogosController so the controller may be reused for multiple nestings or namespaces. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6922 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-01 04:40:30 +00:00
Jeremy Kemper
a6a1dc967c render :partial recognizes Active Record associations as Arrays. Closes #8538. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-01 03:53:39 +00:00
David Heinemeier Hansson
0cf79f07b0 Fixed that DateHelper#date_select should set the day to the 1st when its a hidden option and the month is visible (or invalid dates can be produced) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-31 16:38:36 +00:00
Rick Olson
32b307bc32 fix test cases to match new json output. Closes #8371 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-29 09:42:13 +00:00
Jeremy Kemper
8139de2812 Routing: drop semicolon and comma as route separators. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-29 06:40:33 +00:00
Jeremy Kemper
e5b3d4b3b5 request.remote_ip understands X-Forwarded-For addresses with nonstandard whitespace. Closes #7386. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6877 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-28 00:10:13 +00:00
Jeremy Kemper
0aed1d629e Don't croak if ruby-debug isn't installed. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-28 00:00:07 +00:00