github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-29 16:28:09 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,843 Commits 34 Branches 105 Tags
c326851e4db8a41d76cf05a8db71bc853fa08821
Commit Graph

729 Commits

Author SHA1 Message Date
Jeremy Kemper
5991e5c789 PostgreSQL: correctly parse negative integer column defaults. References #3776. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3554 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 18:06:29 +00:00
Michael Koziarski
d49a5fcb4c * Fix pagination problems when using include 
* Introduce Unit Tests for pagination
* Allow count to work with :include by using count distinct.

[Kevin Clark & Jeremy Hopple]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 09:17:40 +00:00
Tobias Lütke
796295dba6 ActiveRecord::RecordInvalid now states which validations failed in its default error message 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-05 17:39:54 +00:00
David Heinemeier Hansson
0633bb865b Update versions to match latest from stable 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-05 00:59:57 +00:00
David Heinemeier Hansson
5cbc062c8a Just go with Subclasses instead of OnlySubclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 16:26:55 +00:00
David Heinemeier Hansson
ed080863d5 Just go with Subclasses instead of OnlySubclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 06:11:42 +00:00
David Heinemeier Hansson
05eb14d55a Using AssociationCollection#build with arrays of hashes should call build, not create [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-03 18:20:19 +00:00
Nicholas Seckar
1129e5b915 Remove definition of reloadable? from ActiveRecord::Base to make way for new Reloadable code. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3523 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-02 06:13:18 +00:00
Nicholas Seckar
1bce58b312 Add Reloadable::OnlySubclasses which handles the common case where a base class should not be reloaded, but its subclasses should be. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-02 05:41:00 +00:00
David Heinemeier Hansson
65c337ac85 Fixed schema handling for DB2 adapter that didn't work: an initial schema could be set, but it wasn't used when getting tables and indexes (closes #3678) [Maik Schmidt] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 23:34:18 +00:00
David Heinemeier Hansson
f791fe7621 Silly me 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3513 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 04:18:07 +00:00
David Heinemeier Hansson
1f8f982ee0 Added Errors#any? to mean !Errors#empty? [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 04:11:24 +00:00
Marcel Molina
2bf3fa076e Support the :column option for remove_index with the PostgreSQL adapter. Closes #3661. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-31 14:31:16 +00:00
David Heinemeier Hansson
01b1a87729 Added reusable reloading support through the inclusion of the Relodable module that all subclasses of ActiveRecord::Base, ActiveRecord::Observer, ActiveController::Base, and ActionMailer::Base automatically gets [DHH]. Added auto-loading support for classes in modules, so Conductor::Migration will look for conductor/migration.rb and Conductor::Database::Settings will look for conductor/database/settings.rb [Nicholas Seckar]. Refactored extensions to module, class, and object in active support [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-29 00:37:39 +00:00
Marcel Molina
94046542e2 Add documentation for add_index and remove_index. Closes #3600. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3487 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-25 22:17:59 +00:00
Marcel Molina
463d208277 If the OCI library is not available, raise an exception indicating as much. Closes #3593. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3486 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-25 20:50:33 +00:00
Tobias Lütke
2dc16df10c give helpful error messages when fixtures accessed style table_name(:name) cannot be found [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-25 02:40:25 +00:00
Marcel Molina
297618bddc Make dynamic finders honor additional passed in :conditions. Closes #3569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-22 09:34:41 +00:00
Nicholas Seckar
cffd1a9c3a Show a meaningful error when the DB2 adapter cannot be loaded due to missing dependencies. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3460 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-22 06:28:49 +00:00
David Heinemeier Hansson
1facce6c24 allow has_many :through to work with custom :foreign key (closes #3422) [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3456 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-21 23:40:20 +00:00
Michael Koziarski
8fe6b90e5f Fix .count for has_many associations with multi-line finder-sql. Closes #3540 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3450 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-21 07:53:45 +00:00
Jamis Buck
d2f47503f8 Add AR::Base.base_class for querying the ancestor AR::Base subclass [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3439 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-20 20:43:40 +00:00
Michael Koziarski
a471e6b4d7 allow the 'lock_version' column to be configured with set_locking_column. Closes #3402 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-14 09:36:52 +00:00
Michael Koziarski
62d749ab0e Don't hardcode id in acts_as_list. Closes #3370 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-14 09:26:14 +00:00
Michael Koziarski
f41feb349c Don't alter the Hash passed to attributes=, closes #3385 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-14 08:26:20 +00:00
Marcel Molina
1e2b3d8b5a Escape database name in MySQL adapter when creating and dropping databases. Closes #3409. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-13 01:58:11 +00:00
Marcel Molina
f1a01c80db Disambiguate table names for columns in validates_uniquness_of's WHERE clause. Closes #3423. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-13 01:51:45 +00:00
Tobias Lütke
16718e3e21 Fixed that .with_scope imposed create parameters bypass attr_protected 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3393 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-10 22:15:49 +00:00
David Heinemeier Hansson
7dd2d38b9a Fix doc bug 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3389 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-09 04:43:27 +00:00
Marcel Molina
945dd920ab Don't raise an exception when there are more keys than there are named bind variables when sanitizing conditions. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-05 21:40:15 +00:00
Marcel Molina
a5708b4c1f Multiple enhancements and adjustments to DB2 adaptor. Closes #3377. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-04 04:17:23 +00:00
Marcel Molina
bbec3ae512 Sanitize scoped conditions. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-04 03:43:28 +00:00
David Heinemeier Hansson
b5ba377b78 Added option to Base.reflection_of_all_associations to specify a specific association to scope the call. For example Base.reflection_of_all_associations(:has_many) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3357 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-27 05:41:23 +00:00
Tobias Lütke
d4e02f755d ActiveRecord::Base.schema_ignore_tables => ActiveRecord::SchemaDumper.ignore_tables 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-24 17:31:26 +00:00
Tobias Lütke
87535f50e9 SchemaDumper now doesn't fail anymore when there are unknown column types in the schema. Instead the table is ignored and a Comment is left in the schema.rb also added ActiveRecord::Base.schema_ignore_tables for dealing with funky tables like the tesearch2 ones. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-24 16:55:55 +00:00
Florian Weber
c6e01f5b60 Fixed that saving a model with multiple habtm associations, would only save the first habtm association. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-21 15:50:31 +00:00
David Heinemeier Hansson
43f6643b8b Fix form_for use of datetime_select and date_select as well as a few stylistic upgrades to AR 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3330 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-21 06:16:42 +00:00
Scott Barron
88bb279df7 Fix change_column to work with postgres 7.x and 8.x. 
Closes #3141


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3327 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-20 21:43:47 +00:00
Tobias Lütke
581f12b7b1 removed :piggyback in favor of just allowing :select on :through associations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3326 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-20 21:26:27 +00:00
Tobias Lütke
90099e9dc2 made .find() and class method delegation work on :through relations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-20 21:20:35 +00:00
Scott Barron
d5441b2d50 DRY up PG's add_column a bit to use change_column_default and match the other 
methods.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3324 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-20 20:37:19 +00:00
Tobias Lütke
1d2c6ee8f3 added :piggyback option to has_many :through relationships to pick up values from the join table as needed 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-20 20:32:47 +00:00
Scott Barron
1235d26bfb Check for the key instead of the value, because it (the value) can be false. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-20 20:24:19 +00:00
Marcel Molina
3c01e01ded Fix typo in association docs. Closes #3296. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-20 03:26:17 +00:00
Tobias Lütke
5f06c483ca Fixed :through relations when using STI inherited classes would use the inherited class's name as foreign key on the join model 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-16 23:24:58 +00:00
Jeremy Kemper
4ac2593e4e Roll back [3244]. References #3116. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3294 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-13 17:32:39 +00:00
Jeremy Kemper
224d47e0a3 MySQL: allow encoding option for mysql.rb driver. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3293 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-13 16:45:58 +00:00
David Heinemeier Hansson
e5d9ad3e29 Added option inheritance for find calls on has_and_belongs_to_many and has_many assosociations [DHH] Added option to specify :group, :limit, :offset, and :select options from find on has_and_belongs_to_many and has_many assosociations [DHH] 
Added form_remote_for (form_for meets form_remote_tag) [DHH]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-13 00:39:51 +00:00
David Heinemeier Hansson
6427db6baa Added tests for join models and fixed a bug #3177 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-11 18:06:51 +00:00
Jeremy Kemper
809dd8e87e MySQL: fixes for the bundled mysql.rb driver. References #3160. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-12-10 21:38:28 +00:00