github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-16 17:15:29 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,155 Commits 34 Branches 105 Tags
c45ea78c6aeebaae1cfd3b936da54c8472dfdebc
Commit Graph

158 Commits

Author SHA1 Message Date
Marcel Molina
ebf618b7fc Delegate access to a customized primary key to the conventional id method. Closes #2444. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2569 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 20:44:39 +00:00
Sam Stephenson
24c3599cc0 Support using different database adapters for development and test with ActiveRecord::Base.schema_format = :ruby 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2549 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 04:12:32 +00:00
Marcel Molina
b840e4ed50 Deprecated ActiveRecord::Base.threaded_connection in favor of ActiveRecord::Base.allow_concurrency. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 22:37:28 +00:00
Marcel Molina
0e0e774085 Protect id attribute from mass assigment even when the primary key is set to something else. Closes #2438. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 19:59:13 +00:00
Marcel Molina
2948910b56 Misc doc fixes (typos/grammar/etc.). Closes #2430. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 03:55:49 +00:00
Marcel Molina
dcc2263b3a Speed up for unthreaded environments. Closes #2431. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2530 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 03:40:11 +00:00
Marcel Molina
d736568f41 Speed up the setting of table_name. Closes #2428. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2520 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 18:59:56 +00:00
Marcel Molina
eb2fbf05c6 Optimize instantiation of STI subclass records. In partial fullfilment of #1236. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2511 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 22:26:54 +00:00
Marcel Molina
f4d1af3085 Fix typo of 'constrains' to 'contraints'. Closes #2069. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 22:08:16 +00:00
Jeremy Kemper
60a60f9798 Don't tell me about defined reader methods, even at debug level. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2489 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-07 18:22:40 +00:00
Marcel Molina
f218771d3e Add option (true by default) to generate reader methods for each attribute of a record to avoid the overhead of calling method missing. In partial fullfilment of #1236. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2483 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-07 00:53:05 +00:00
Marcel Molina
c0899bca10 Add convenience predicate methods on Column class. In partial fullfilment of #1236. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2482 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 23:19:55 +00:00
Marcel Molina
e8b427cdef Raise an exception when invalid options are passed to ActiveRecord::Base.find. Closes #2363. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2481 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 22:21:10 +00:00
Michael Koziarski
656fb866f9 Quote booleans according the rules defined by the adapter 
* SQLite schema has been updated
* Postgresql schema needs to be fixed too
Simplify AR::Base#toggle to store the boolean, not the quoted value
* expand the tests


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-06 04:15:14 +00:00
Jeremy Kemper
e19bd169fa Association validation does not belong in a before_save callback: move it into a validation method. Restores the expected model.valid? == model.save. Add tests for cancelling save by returning false from a before_save callback. Remove assumption that before_destroy's return value indicates whether the record was destroyed. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-02 02:00:50 +00:00
Scott Barron
76a7a52557 Fix serialization problem with YAML in 1.8.3 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2360 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 09:25:17 +00:00
Marcel Molina
1d738cab80 Make update_attribute use the same writer method that update_attributes uses. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 21:55:37 +00:00
Jamis Buck
2a35baa0bb Wrap :conditions in parentheses to prevent problems with OR's #1871 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2324 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-24 23:58:13 +00:00
David Heinemeier Hansson
caaf40d535 Added AbstractAdapter#select_value and AbstractAdapter#select_values as convenience methods for selecting single values, instead of hashes, of the first column in a SELECT #2283 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-24 19:50:57 +00:00
David Heinemeier Hansson
3c0129af6d Fixed memory leak with Active Record classes when Dependencies.mechanism = :load #1704 [c.r.mcgrath@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2273 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 10:33:26 +00:00
David Heinemeier Hansson
b646e0ddf7 Rolled back broken #1814 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2203 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 10:05:46 +00:00
David Heinemeier Hansson
57070277b4 Added better exception error when unknown column types are used with migrations #1814 [fbeausoleil@ftml.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 09:41:24 +00:00
David Heinemeier Hansson
0faca07056 Fixed comparison of Active Record objects so two new objects are not equal #2099 [deberg] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2172 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:54:02 +00:00
David Heinemeier Hansson
febc24dee7 An explicit include ClassInheritableAttributes is no longer needed #1948 [Caleb Tennis] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:28:10 +00:00
David Heinemeier Hansson
eec24a16c7 Fixed that Active Record would call SHOW FIELDS twice (or more) for the same model when the cached results were available #1947 [sd@notso.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 12:21:36 +00:00
David Heinemeier Hansson
f2a89d7862 Give AR the new benchmark method too 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2143 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:47:31 +00:00
David Heinemeier Hansson
f86276b305 Fix fragment benchmark calls and limit timings to 5 decimals 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:33:11 +00:00
David Heinemeier Hansson
5e8e8d6564 Added use_silence parameter to ActiveRecord::Base.benchmark that can be passed false to include all logging statements during the benchmark block. Added ActionController::Base.benchmark and ActionController::Base.silence to allow for easy benchmarking and turning off the log 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 16:48:18 +00:00
Jamis Buck
69d662051e Modify read_attribute to allow a symbol argument #2024 [Ken Kunz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 08:31:11 +00:00
Jamis Buck
b1a4f91a58 Make destroy return self #1913 [sebastian.kanthak@muehlheim.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-14 08:58:53 +00:00
Jamis Buck
e17bf81823 Fix typo in count_by_sql documentation #1969 [Alexey Verkhovsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-14 08:20:51 +00:00
David Heinemeier Hansson
14ea312808 Made Oracle a first-class connection adapter by adhering closer to idiomatic Oracle style #1798 [The Gang of Oracles] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1912 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 14:01:35 +00:00
David Heinemeier Hansson
34f9d30e39 Added support for calling constrained class methods on has_many and has_and_belongs_to_many collections #1764 [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 20:05:42 +00:00
David Heinemeier Hansson
1aab0e2c30 Doc fixes #1775, #1776 [jon@instance-design.co.uk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 06:27:07 +00:00
David Heinemeier Hansson
6f05696ceb Added :select option to find which can specify a different value than the default *, like find(:all, :select => "first_name, last_name"), if you either only want to select part of the columns or exclude columns otherwise included from a join #1338 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 07:18:26 +00:00
David Heinemeier Hansson
5b9b904f14 Added support for limit and offset with eager loading of has_one and belongs_to associations. Using the options with has_many and has_and_belongs_to_many associations will now raise an ActiveRecord::ConfigurationError #1692 [Rick Olsen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-11 06:09:08 +00:00
David Heinemeier Hansson
60499774c2 Fixed that each request with the WEBrick adapter would open a new database connection #1685 [Sam Stephenson]. Added ActiveRecord::Base.threaded_connections flag to turn off 1-connection per thread (required for thread safety). By default it's on, but WEBrick in Rails need it off #1685 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1792 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-10 04:54:34 +00:00
Jeremy Kemper
5495b14a09 r2979@asus: jeremy | 2005-07-10 01:51:00 -0700 
Split association reflection test into has_many and has_one tests.  TODO: extend to belongs_to and habtm as well.  Kill trailing whitespace.
 r2980@asus:  jeremy | 2005-07-10 01:53:41 -0700
 Test that eager load of firm.account (a has_one) returns the correct account.  This doesn't cover the regression in Ticket #1688, however.  Need a case where class name is not provided and the singular name is over-singularized by active_record.class_name.  Kill trailing whitespace.
 r2981@asus:  jeremy | 2005-07-10 01:56:44 -0700
 Fix class name resolution in AssociationReflection#name_to_class_name.  Use the equivalent of the idiomatic ||= (read or write if nil) for the class_inheritable_attribute reflection arrays.  Kill trailing whitespace.
 r2982@asus:  jeremy | 2005-07-10 01:59:08 -0700
 Remove superfluous assignment in compute_type.  In an inject, the return value is used for the next injection, so assigning to the injected value is unnecessary.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-10 04:22:08 +00:00
Jamis Buck
56c3d72aa7 Fix regression from [1631] that caused an attribute to be set to nil if it was assigned false 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1709 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 12:38:06 +00:00
David Heinemeier Hansson
aaa5637249 Fixed Base#write_attribute to work with both symbols and strings #1190 [Paul Legato] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 09:51:24 +00:00
Jeremy Kemper
b210edce38 r1618@asus: jeremy | 2005-07-03 08:24:19 -0700 
base attribute_present? on blank?, accounting for zero


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:33:03 +00:00
Jeremy Kemper
9a10b31fe8 r1615@asus: jeremy | 2005-07-03 08:06:00 -0700 
oops, back out DELETE typo


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:47 +00:00
Jeremy Kemper
6e39c9e561 r1614@asus: jeremy | 2005-07-03 08:01:08 -0700 
minor perf tweaks + excise trailing whitespace


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1632 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:43 +00:00
Jeremy Kemper
81737fc0dd r1613@asus: jeremy | 2005-07-03 07:04:53 -0700 
optimize method_missing for common case (read_attribute).  minor perf tweaks


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:39 +00:00
Jeremy Kemper
af9d03824a r1609@asus: jeremy | 2005-07-03 00:18:43 -0700 
more minor perf tweaks


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1627 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:17 +00:00
Jeremy Kemper
397c8ee2a9 r1608@asus: jeremy | 2005-07-03 00:13:57 -0700 
quoter required for column quoting


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:12 +00:00
David Heinemeier Hansson
f2a29ca43c Added support for ODBC connections to MS SQL Server so you can connect from a non-Windows machine #1569 [Mark Imbriaco/DeLynn Berry] Added support for limit/offset with the MS SQL Server driver so that pagination will now work #1569 [DeLynn Berry] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1583 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-01 17:20:04 +00:00
David Heinemeier Hansson
c92ecb82b8 Fixed that multiparameter posts ignored attr_protected #1532 [alec+rails@veryclever.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 17:15:01 +00:00
David Heinemeier Hansson
3dfa56ccfb Updated all references to the old find_first and find_all to use the new style #1511 [Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1520 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-26 11:25:32 +00:00
David Heinemeier Hansson
302c23d5a6 Fixed Base#find to honor the documentation on how :joins work and make them consistent with Base#count #1405 [pritchie@gmail.com] Improved dynamic finder docs #1495 [laurel@gorgorg.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-25 11:47:37 +00:00