github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 16:58:15 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,341 Commits 34 Branches 105 Tags
c66b44e76daa96bcff62267cd2690a3755ca6bbd
Commit Graph

877 Commits

Author SHA1 Message Date
David Heinemeier Hansson
949bf2937a Get the green light for Oracle AR unit tests (closes #4573) [Michael Schoen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-04 16:33:31 +00:00
Florian Weber
bb4c6797bf Fixed that AssociationCollection#delete_all should work even if the records of the association are not loaded yet. [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-03 22:37:56 +00:00
David Heinemeier Hansson
109c56df3a Doc fix #3960 [jonrailsdev@shumi.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-03 18:47:49 +00:00
Rick Olson
db7fadd730 Changed those private ActiveRecord methods to take optional third argument :auto instead of nil for performance optimizations. (closes #4456) [Stefan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-03 16:09:47 +00:00
Nicholas Seckar
6c2d167cd9 Abort broken tighter resolution suppression. Closes #4431 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-03 05:30:43 +00:00
Rick Olson
a3f20132db Private ActiveRecord methods add_limit, add_joins, and add_conditions take an OPTIONAL third argument 'scope' (closes #4456) [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-01 23:15:35 +00:00
David Heinemeier Hansson
12c5287e30 Doc fix (closes #4515) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4124 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-01 20:10:42 +00:00
David Heinemeier Hansson
53aa8da1a7 Fixed that records returned from has_and_belongs_to_many associations with additional attributes should be marked as read only (fixes #4512) [DHH] DEPRECATED: Using additional attributes on has_and_belongs_to_many associations. Instead upgrade your association to be a real join model [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4123 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-01 20:03:10 +00:00
David Heinemeier Hansson
217f67bf84 Doc fix (closes #4521) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-01 19:14:17 +00:00
David Heinemeier Hansson
5fd7118cbc dont merge when you can update (closes #4529) [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4116 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-01 06:57:43 +00:00
Marcel Molina
3f049b0b6b Do not implicitly mark recordss of has_many :through as readonly but do mark habtm records as readonly (eventually only on join tables without rich attributes). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4107 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-30 22:27:32 +00:00
Rick Olson
58dd49a7ae pass the correct reflection to HasManyThroughAssociationPolymorphicError 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-30 19:25:07 +00:00
David Heinemeier Hansson
0703149e71 Fixed broken OCIAdapter (closes #4457) [schoenm@earthlink.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-30 03:38:15 +00:00
David Heinemeier Hansson
479b4fb5d9 Made ready for release 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-28 05:03:05 +00:00
Michael Koziarski
9babb2014b to_xml documentation [DHH, Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4087 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-28 04:25:31 +00:00
Rick Olson
2597bd6970 documentation for polymorphic joins 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-28 04:01:17 +00:00
David Heinemeier Hansson
fed7d334f2 Fixed documentation 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-28 03:06:40 +00:00
Nicholas Seckar
b55fc9e85a Replace 'rescue Object' with a finer grained rescue. Closes #4431 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4076 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-28 01:48:59 +00:00
David Heinemeier Hansson
31199a9e4a Update description 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-28 01:11:09 +00:00
David Heinemeier Hansson
c9c185200d Making ActiveRecord faster [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-27 23:28:19 +00:00
Rick Olson
ed6c3c17f7 Fixed eager loading so that an aliased table cannot clash with a has_and_belongs_to_many join table [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-27 08:09:36 +00:00
Michael Koziarski
445cb5c08d Add support for :include to with_scope [andrew@redlinesoftware.com] 
Remove overrated warning from adapter_test




git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-27 06:19:31 +00:00
David Heinemeier Hansson
1886de8612 Support the use of public synonyms with the Oracle adapter; required ruby-oci8 v0.1.14 (closes #4390) [schoenm@earthlink.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 21:43:48 +00:00
David Heinemeier Hansson
91ea35307a Only string_to_binary if the column responds 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4040 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 04:15:57 +00:00
Rick Olson
a5991d8491 Change periods (.) in table aliases to _'s. Closes #4251 [jeff@ministrycentered.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 04:13:25 +00:00
Rick Olson
56af14d5aa Changed has_and_belongs_to_many join to INNER JOIN for Mysql 3.23.x. Closes #4348 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4038 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 04:08:50 +00:00
Rick Olson
6636eb16c5 Fixed issue that kept :select options from being scoped [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4036 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 00:36:55 +00:00
David Heinemeier Hansson
3cec029685 Do it in style 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4032 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-25 23:10:09 +00:00
David Heinemeier Hansson
5b63c84307 Fixed db_schema_import when binary types are present (closes #3101) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-25 23:09:52 +00:00
David Heinemeier Hansson
75de3cbb13 Fixed that MySQL enums should always be returned as strings (closes #3501) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4028 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-25 21:42:27 +00:00
Rick Olson
ef1297d896 remove some documentation cruft on has_many 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4023 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-24 14:56:31 +00:00
Rick Olson
38bae0a969 Change has_many :through to use the :source option to specify the source association. :class_name is now ignored. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4022 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-24 14:46:17 +00:00
Rick Olson
ed10f873a1 STI associations are now aliased to the table name for backwards compatibility. Added docs for table aliasing [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4015 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-23 06:01:01 +00:00
David Heinemeier Hansson
2d24bed3a0 Fixed DB2 adapter so nullable columns will be determines correctly now and quotes from column default values will be removed (closes #4350) [contact@maik-schmidt.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-22 19:30:02 +00:00
Rick Olson
6fbf408238 Allow overriding of find parameters in scoped has_many :through calls [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-21 16:33:22 +00:00
David Heinemeier Hansson
1aff68d615 Fix bug introduced by changeset 3679 which caused custom attribute? methods to be overridden. Also ensure that ? methods are defined even if read method is customised. (closes #3677) [jonathan@bluewire.net.nz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-20 06:45:34 +00:00
David Heinemeier Hansson
6d627b6725 Fixed that schema changes while the database was open would break any connections to a SQLite database (now we reconnect if that error is throw) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-20 06:09:57 +00:00
David Heinemeier Hansson
df62dea1ff Fixed that schema changes while the database was open would break any connections to a SQLite database (now we reconnect if that error is throw) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-20 06:05:16 +00:00
Rick Olson
9a72cd22cf Don't classify the has_one class when eager loading, it is already singular. Add tests. (closes #4117) [jonathan@bluewire.net.nz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3983 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 19:32:07 +00:00
Rick Olson
753010ac39 add support for COUNT(DISTINCT id) queries in sqlite2 (closes #4300) [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3979 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 17:42:51 +00:00
Rick Olson
ea25e246e0 Quit ignoring default :include options in has_many :through calls [Mark James] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 16:13:52 +00:00
Rick Olson
fcd4c9529c Allow has_many :through associations to find the source association by setting a custom class (closes #4307) [jonathan@bluewire.net.nz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 07:14:48 +00:00
Rick Olson
639ce3b21d Remember kiddies, Dir[] uses Dir#glob, not a Regexp 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 04:30:10 +00:00
Rick Olson
9412c0531d Eager Loading support added for has_many :through => :has_many associations (see below). [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 03:05:21 +00:00
David Heinemeier Hansson
3f77a04cb5 Only run migrations that look like migrations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 02:38:35 +00:00
Rick Olson
0925c6b6a0 Allow has_many :through to work on has_many associations (closes #3864) [sco@scottraymond.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3964 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 02:01:40 +00:00
Rick Olson
57af961a80 Raise error when trying to select many polymorphic objects with has_many :through or :include (closes #4226) [josh@hasmanythrough.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 00:53:24 +00:00
Rick Olson
9c9069a675 Fixed has_many :through to include :conditions set on the :through association. closes #4020 [jonathan@bluewire.net.nz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-18 23:14:31 +00:00
Rick Olson
fbd1e01bd6 Fix that has_many :through honors the foreign key set by the belongs_to association in the join model (closes #4259) [andylien@gmail.com / Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3954 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-18 22:38:49 +00:00
David Heinemeier Hansson
9db8f3e57a SQL Server adapter gets some love (closes #4298) [rtomayko@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-18 21:27:40 +00:00