Commit Graph

816 Commits

Author SHA1 Message Date
Rick Olson
c963f8e955 Tweak RoutingError message to show option diffs, not just missing named route significant keys. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4756 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-13 18:00:08 +00:00
Nicholas Seckar
84bacf99d6 Invoke method_missing directly for hidden actions. Closes #3030.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-13 04:15:22 +00:00
Marcel Molina
9b204641c0 Fix typo in caching docs.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-09 15:30:43 +00:00
Rick Olson
f06cae3652 Require Tempfile explicitly for TestUploadedFile due to changes in class auto loading. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4734 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-09 00:11:28 +00:00
Rick Olson
4679e1bf7f Add RoutingError exception when RouteSet fails to generate a path from a Named Route. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4733 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-09 00:02:08 +00:00
Nicholas Seckar
74165eb6ac New dependencies implementation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-08 21:21:04 +00:00
Jeremy Kemper
c3cdd3b659 Deprecation: check whether instance variables have been monkeyed with before assigning them to deprecation proxies. Raises a RuntimeError if so.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 21:58:31 +00:00
Jeremy Kemper
c40b1a4a67 Deprecate direct usage of @params. Update ActionView::Base for instance var deprecation.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 12:40:14 +00:00
Nicholas Seckar
c469e4653d it's me, john wayne
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4700 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 06:13:01 +00:00
Jeremy Kemper
2399a223c3 Deprecation! @session and @flash will be removed after 1.2. Use the session and flash methods instead. You'll get printed warnings during tests and logged warnings in dev mode when you access either instance variable directly.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4699 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 06:11:56 +00:00
Rick Olson
a27ccf1765 add Rdocs to map.resources
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-06 16:33:22 +00:00
Nicholas Seckar
127ee8c8f8 Make Routing noisy when an anchor regexp is assigned to a segment. Closes #5674
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 22:12:50 +00:00
David Heinemeier Hansson
5130fc84c6 Remove duplicate routes from mapped resources (closes #5712) [eigentone@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 20:46:49 +00:00
Michael Koziarski
6c50597489 Short documentation to mention use of Mime::Type.register. Closes #5710 [choonkeat@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 02:00:04 +00:00
Jeremy Kemper
12ab93b72b Make controller_path available as an instance method. Closes #5724.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 01:56:58 +00:00
David Heinemeier Hansson
6b5ef885d9 The white space inquisition is coming for you!
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-04 16:47:48 +00:00
Nicholas Seckar
f39180eded Fix broken query parameter tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4660 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-04 16:03:21 +00:00
Marcel Molina
08f40a5e06 Fix typo in caching docs. [Marcel Molina Jr.]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4657 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-04 00:02:44 +00:00
Marcel Molina
d17bd6a043 Make action caching aware of different formats for the same action so that, e.g. foo.xml is cached separately from foo.html. Implicitly set content type when reading in cached content with mime revealing extensions so the entire onous isn't on the webserver. PDI MORE CACHING TESTS [Marcel Molina Jr.]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4656 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-03 23:59:38 +00:00
Jamis Buck
49f44daf17 More tweaks to make sure assert_redirected_to works with symbols
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 21:34:58 +00:00
Jamis Buck
0cfde5f8c0 Make sure assert_respond_to works with symbol parameters
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4648 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 20:56:26 +00:00
Rick Olson
58b996f9b0 Restrict Request Method hacking with ?_method to POST requests. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4644 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 03:02:31 +00:00
Jeremy Kemper
c9417dcef3 Nested resource testing.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 01:23:06 +00:00
Jeremy Kemper
a247d72139 Nesting map.resources
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 00:29:02 +00:00
Rick Olson
78e37f45c6 Fix bug when passing multiple options to SimplyRestful, like :new => { :preview => :get, :draft => :get }. [Rick Olson, Josh Susser, Lars Pind]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4641 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 21:57:59 +00:00
Rick Olson
d2eafa8b73 Dup the options passed to map.resources so that multiple resources get the same options. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4639 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 20:32:48 +00:00
Rick Olson
ed4c295c47 Fixed the new_#{resource}_url route and added named route tests for Simply Restful. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4638 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 20:00:18 +00:00
David Heinemeier Hansson
865b175765 Added map.resources from the Simply Restful plugin (backwards incompatible with the plugin!) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 18:59:58 +00:00
Jeremy Kemper
ffaecb792e r4886@ks: jeremy | 2006-07-31 00:01:55 -0700
comma


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 07:02:08 +00:00
David Heinemeier Hansson
df7efd7e21 Fixed that integration simulation of XHRs should set Accept header as well [Edward Frederick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 06:18:20 +00:00
Rick Olson
efff453148 show missing file path on failed fixture_file_upload
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-30 16:16:46 +00:00
Michael Koziarski
d02c07dbb9 Ensure TestRequest#session always returns a TestSession [Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-28 23:15:12 +00:00
Jamis Buck
d70d521955 Don't search a load-path of '.' for controller files, since it may include symlinks to all kinds of things and result in far too many irrelevant files being considered
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4625 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-27 15:31:07 +00:00
Nicholas Seckar
9d17f882ee Update integration.rb to require test_process explicitly instead of via Dependencies
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-27 14:30:23 +00:00
David Heinemeier Hansson
45e319d0f8 Added ICS to extension lookup recognition [Lars Pind]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-26 16:34:49 +00:00
Rick Olson
04d9e94e88 Fixed that you can still access the flash after the flash has been reset in reset_session. Closes #5584 [lmarlow@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-22 02:31:21 +00:00
Nicholas Seckar
378a935430 Remove leak in development mode
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-17 17:03:47 +00:00
Jeremy Kemper
71234daef1 r4487@asus: jeremy | 2006-04-29 12:21:39 -0700
Check whether @flash is defined? for warnings-safety.
 r4488@asus:  jeremy | 2006-04-29 12:23:15 -0700
 Check whether @flash is defined? for warnings-safety. Obviates nil? check.
 r4489@asus:  jeremy | 2006-04-29 12:45:18 -0700
 Check whether @session is defined? for warnings-safety.
 r4490@asus:  jeremy | 2006-04-29 12:50:41 -0700
 Check whether @rendering_runtime is defined? for warnings-safety.
 r4491@asus:  jeremy | 2006-04-29 12:55:01 -0700
 Check whether @_cycles is defined? for warnings-safety.
 r4492@asus:  jeremy | 2006-04-29 12:59:19 -0700
 Check whether instance variables are defined? for warnings-safety.
 r4493@asus:  jeremy | 2006-04-29 13:14:09 -0700
 Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
 r4494@asus:  jeremy | 2006-04-29 13:31:34 -0700
 Check whether @auto_index defined? for warnings-safety.
 r4495@asus:  jeremy | 2006-04-29 13:32:24 -0700
 Wrap content_columns redefinitions with silence_warnings.
 r4496@asus:  jeremy | 2006-04-29 13:35:28 -0700
 Wrap more redefinitions with silence_warnings.
 r4829@asus:  jeremy | 2006-07-08 10:59:20 -0700
 abstract unit, fix warnings
 r4830@asus:  jeremy | 2006-07-08 11:06:12 -0700
 Use parens to silence warning.
 r4831@asus:  jeremy | 2006-07-08 11:06:48 -0700
 Use parens to silence warning.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 18:14:49 +00:00
Jeremy Kemper
eede40bcf0 Reset @html_document between requests so assert_tag works. Closes #4810.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 04:58:55 +00:00
Jeremy Kemper
e5cbb849f9 Update render :partial documentation. Closes #5646.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4590 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 01:50:58 +00:00
Jeremy Kemper
c396c5ab31 Integration tests behave well with render_component. Closes #4632.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4582 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 00:18:42 +00:00
Jeremy Kemper
cf965cda5c Clarify partial filename constraints. Closes #1161.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4581 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-07 22:53:46 +00:00
David Heinemeier Hansson
11c715a53f Added exception handling of missing layouts (closes #5373) [chris@ozmm.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-05 02:38:55 +00:00
David Heinemeier Hansson
40f50fd7e5 Doc fix (closes #5429)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4547 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-05 02:18:34 +00:00
David Heinemeier Hansson
f780bb8f58 Doc fix (closes #5576)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-05 01:16:41 +00:00
David Heinemeier Hansson
28ef328baa Fixed that the flash should be reset when reset_session is called (closes #5584) [shugo@ruby-lang.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4540 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-05 01:14:53 +00:00
Jeremy Kemper
d0526ede40 r4748@asus: jeremy | 2006-06-29 22:40:35 -0700
Loosen urlencoded content type check.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-30 05:41:03 +00:00
David Heinemeier Hansson
bdac94e990 Fixed proper form-encoded parameter parsing for requests with "Content-Type: application/x-www-form-urlencoded; charset=utf-8" (note the presence of a charset directive) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-30 05:19:15 +00:00
Nicholas Seckar
e494b0a441 Add route_name_path method to generate only the path for a named routes. For example, map.person will add person_path.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-30 02:36:17 +00:00
Marcel Molina
c02d1f7d9b Fix CGI extensions when they expect string but get nil in Windows. Closes #5276 [mislav@nippur.irb.hr]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-28 13:51:25 +00:00