Commit Graph

256 Commits

Author SHA1 Message Date
Jeremy Kemper
229ea65374 simple_format helper doesn't choke on nil. Closes #6644.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5561 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 09:57:16 +00:00
Jeremy Kemper
5b50504f48 Missed pluralize nil test in [5431].
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-06 21:39:16 +00:00
Thomas Fuchs
e52e803a55 Deprecate JavaScriptHelper#update_element_function, which is superseeded by RJS [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-06 09:40:30 +00:00
Jeremy Kemper
7f6c5a5654 Set ActionView::Base.default_form_builder once rather than passing the :builder option to every form or overriding the form helper methods.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-03 04:16:58 +00:00
Rick Olson
d4e35666d1 Deprecate start_form_tag and end_form_tag. Use form_tag / '</form>' from now on. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-24 03:22:48 +00:00
Rick Olson
f7c916ece6 Added block-usage to PrototypeHelper#form_remote_tag, document block-usage of FormTagHelper#form_tag [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-24 03:06:57 +00:00
David Heinemeier Hansson
e407b44ba1 Made FormTagHelper#form_tag work with blocks, rendering start/end_form_tag deprecated
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-23 23:30:36 +00:00
David Heinemeier Hansson
6c062054cd Added block-usage to TagHelper#content_tag [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5344 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-23 22:57:59 +00:00
David Heinemeier Hansson
b34ed9b339 Docfix (closes #6393)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5339 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-22 23:58:41 +00:00
David Heinemeier Hansson
986c1a6240 Deprecated UrlHelper#link_to_image and UrlHelper#link_to :post => true (closes #6409) [BobSilva]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5338 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-22 23:54:41 +00:00
David Heinemeier Hansson
1c71a5d25f Upgraded NumberHelper with number_to_phone support international formats to comply with ITU E.123 by supporting area codes with less than 3 digits, added precision argument to number_to_human_size (defaults to 1) (closes #6421) [BobSilva]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5336 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-22 23:47:18 +00:00
David Heinemeier Hansson
afd288cf81 Fixed that setting RAILS_ASSET_ID to "" should not add a trailing slash after assets (closes #6454) [BobSilva/chrismear]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5335 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-22 23:41:11 +00:00
Rick Olson
1d7196b552 Force *_url named routes to show the host in ActionView [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-20 18:00:20 +00:00
Sam Stephenson
351a224d90 Add support for converting blocks into function arguments in JavaScriptGenerator#call and JavaScriptProxy#call.
Add JavaScriptGenerator#literal for wrapping a string in an object whose #to_json is the string itself.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-19 22:03:27 +00:00
Rick Olson
dbd0bd5e5c Add <%= escape_once html %> to escape html while leaving any currently escaped entities alone. Fix button_to double-escaping issue. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-18 16:42:19 +00:00
Rick Olson
02358c83b7 Fix double-escaped entities, such as &amp;amp;, &amp;#123;, etc. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-18 15:58:07 +00:00
Jeremy Kemper
a0f74092a8 test deprecated instance variables using to_s instead of inspect which touches other ivars
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-18 00:04:47 +00:00
Michael Koziarski
81ddeadd49 Replace KCODE checks with String#chars for truncate. Closes #6385 [Manfred Stienstra]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5300 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-14 00:31:30 +00:00
Michael Koziarski
41c3623524 Use String#chars in TextHelper::excerpt. Closes #6386 [Manfred Stienstra]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5288 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-12 21:13:05 +00:00
David Heinemeier Hansson
a49e7d5c0c Fixed that NumberHelper#number_to_delimiter should respect precision of higher than two digits (closes #6231) [phallstrom]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-09 00:59:19 +00:00
David Heinemeier Hansson
211ffd3f79 Fixed that FormHelper#radio_button didn't respect an :id being passed in (closes #6266) [evansj]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-09 00:53:59 +00:00
David Heinemeier Hansson
8ff92e2435 Added an html_options hash parameter to javascript_tag() and update_page_tag() helpers #6311 [tzaharia]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-09 00:50:11 +00:00
David Heinemeier Hansson
4b3e964a1a Fixed escaping of backslashes in JavaScriptHelper#escape_javascript (closes #6302) [sven@c3d2.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-09 00:34:43 +00:00
Jeremy Kemper
c554a9caba strip_links is case-insensitive. Closes #6285.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5191 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-26 16:26:00 +00:00
Thomas Fuchs
8734da9bca Update JavaScriptGenerator#show/hide/toggle/remove to new Prototype syntax for multiple ids, fixes #6068 [petermichaux@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 09:19:35 +00:00
David Heinemeier Hansson
8c9ce617c9 Fixed JavaScriptHelper#link_to_function and JavaScriptHelper#button_to_function to have the script argument be optional [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 01:31:04 +00:00
David Heinemeier Hansson
1d4d037b0d Added access to nested attributes in RJS (closes #4548) [richcollins@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:54:10 +00:00
David Heinemeier Hansson
bf8b101dd6 Fixed that AssetTagHelper#image_tag and others using compute_public_path should not modify the incoming source argument (closes #5102) [eule@space.ch]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:43:38 +00:00
David Heinemeier Hansson
9514e4e6ad Deprecated the auto-appending of .png to AssetTagHelper#image_tag calls that doesn't have an extension [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:25:43 +00:00
David Heinemeier Hansson
d4bb22b220 Fixed TextHelper#simple_format to deal with multiple single returns within a single paragraph (closes #5835) [moriq@moriq.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:26:32 +00:00
David Heinemeier Hansson
a693b3beca Fixed TextHelper#pluralize to handle 1 as a string (closes #5905) [rails@bencurtis.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:23:07 +00:00
David Heinemeier Hansson
17f7eaa141 Improved resolution of DateHelper#distance_of_time_in_words for better precision (closes #5994) [Bob Silva]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4989 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 17:00:37 +00:00
David Heinemeier Hansson
6d88a992b5 Added deprecation language for in_place_editor and auto_complete_field that both pieces will become plugins by Rails 2.0 [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:22:24 +00:00
Jeremy Kemper
4fc6c872ef radio_button_tag generates unique id attributes. Closes #3353.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4925 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 19:32:31 +00:00
Jeremy Kemper
6d17ece9f2 strip_tags returns nil for a blank arg such as nil or "". Closes #2229.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4916 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 16:47:05 +00:00
Jeremy Kemper
a769b88819 button_to accepts :method so you can PUT and DELETE with it. Closes #6005.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4914 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 15:59:18 +00:00
Rick Olson
0c999f4125 Update sanitize text helper to strip plaintext tags, and <img src=javascript:bang>. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 00:02:14 +00:00
Jamis Buck
bdf91d6748 Make auto_link parse a greater subset of valid url formats.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-02 01:47:32 +00:00
Jeremy Kemper
96c6ca369a Deprecation: test deprecated instance vars in partials.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4824 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 05:58:16 +00:00
Nicholas Seckar
74165eb6ac New dependencies implementation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-08 21:21:04 +00:00
Jeremy Kemper
c40b1a4a67 Deprecate direct usage of @params. Update ActionView::Base for instance var deprecation.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 12:40:14 +00:00
Thomas Fuchs
a3b045a73e Add support for the param_name parameter to the auto_complete_field helper. Fixes #5026 [david.a.williams@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 11:08:32 +00:00
David Heinemeier Hansson
4699c336f7 Make test_tag_options pass (closes #5600) [shugo]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4675 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 21:38:03 +00:00
David Heinemeier Hansson
8eaf479156 Added months and years to the resolution of DateHelper#distance_of_time_in_words, such that "60 days ago" becomes "2 months ago" (closes #5611) [pjhyett@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4674 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 21:34:18 +00:00
Rick Olson
101ebc996a Allow form_for and fields_for to work with indexed form inputs. [Jeremy Kemper, Matt Lyon]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-18 15:42:22 +00:00
Jeremy Kemper
71234daef1 r4487@asus: jeremy | 2006-04-29 12:21:39 -0700
Check whether @flash is defined? for warnings-safety.
 r4488@asus:  jeremy | 2006-04-29 12:23:15 -0700
 Check whether @flash is defined? for warnings-safety. Obviates nil? check.
 r4489@asus:  jeremy | 2006-04-29 12:45:18 -0700
 Check whether @session is defined? for warnings-safety.
 r4490@asus:  jeremy | 2006-04-29 12:50:41 -0700
 Check whether @rendering_runtime is defined? for warnings-safety.
 r4491@asus:  jeremy | 2006-04-29 12:55:01 -0700
 Check whether @_cycles is defined? for warnings-safety.
 r4492@asus:  jeremy | 2006-04-29 12:59:19 -0700
 Check whether instance variables are defined? for warnings-safety.
 r4493@asus:  jeremy | 2006-04-29 13:14:09 -0700
 Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
 r4494@asus:  jeremy | 2006-04-29 13:31:34 -0700
 Check whether @auto_index defined? for warnings-safety.
 r4495@asus:  jeremy | 2006-04-29 13:32:24 -0700
 Wrap content_columns redefinitions with silence_warnings.
 r4496@asus:  jeremy | 2006-04-29 13:35:28 -0700
 Wrap more redefinitions with silence_warnings.
 r4829@asus:  jeremy | 2006-07-08 10:59:20 -0700
 abstract unit, fix warnings
 r4830@asus:  jeremy | 2006-07-08 11:06:12 -0700
 Use parens to silence warning.
 r4831@asus:  jeremy | 2006-07-08 11:06:48 -0700
 Use parens to silence warning.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 18:14:49 +00:00
Jeremy Kemper
f801cd7959 Pass :id => nil or :class => nil to error_messages_for to supress that html attribute. Closes #3586.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 05:35:08 +00:00
Jeremy Kemper
f833a78049 text_field_with_auto_complete stylesheet uses <style type="text/css"> instead of bare <style>. Closes #5610.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4558 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-05 23:24:14 +00:00
David Heinemeier Hansson
ead99f3f2e Fixed that real files and symlinks should be treated the same when compiling templates (closes #5438) [zachary@panandscan.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4546 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-05 02:17:25 +00:00
David Heinemeier Hansson
532627452d Added special case for "1 Byte" in NumberHelper#number_to_human_size (closes #5593) [murpyh@rubychan.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4537 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-05 01:04:32 +00:00