github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
15,876 Commits 34 Branches 105 Tags
cb8fa3573c7cfcbc8a59acb6cfbde99f71dcccaa
Commit Graph

5316 Commits

Author SHA1 Message Date
Jeremy Kemper
4691c696b0 Expect an incompatible encoding exception when a template with a magic comment renders a partial without one and its source encoding doesn't match the default external encoding 2010-04-08 20:22:07 -07:00
Jeremy Kemper
bd2bf5390d Expect an incompatible encoding exception when a template doesn't have a magic comment and its source encoding doesn't match the default external encoding 2010-04-08 19:27:39 -07:00
Xavier Noria
fd7202a756 adds #favicon_link_tag back, rdoc explains why it is useful, and how to get a link for Mobile Safari with it 2010-04-08 18:13:23 -07:00
Carl Lerche
99d5459921 Fixed that default locale templates should be used if the current locale template is missing [DHH] 2010-04-08 18:11:26 -07:00
Michael Koziarski
82514c2897 Add accessors for request and response so tests don't have to mess with internal ivars 2010-04-09 11:30:39 +12:00
David Heinemeier Hansson
5f808b865c Consistently use lowercase instead of camelCase for all JS class names in Rails 2010-04-08 12:17:46 -07:00
David Heinemeier Hansson
00ee9b3369 Revert "adds #favicon_link_tag and #apple_touch_icon_link_tag" -- these tags are too specific. 
This reverts commit 6891f46d10, ec8610cfdc, and  d18ff1b7ef.
 2010-04-08 11:49:34 -07:00
Jeremy Kemper
e7f0d37c91 Remove superfluous condition 2010-04-08 11:38:25 -07:00
Jeremy Kemper
ab5aa55cb8 Merge branch 'master' of github.com:rails/rails 2010-04-08 10:25:13 -07:00
José Valim
4e92134dfa Fix a bug in ActionDispatch::Static where Rails cannot find assets if started in another directory which is not the RAILS_ROOT. 2010-04-08 12:52:37 +02:00
Xavier Noria
6891f46d10 adds #favicon_link_tag and #apple_touch_icon_link_tag to AP's CHANGELOG 2010-04-07 15:07:07 -07:00
Xavier Noria
ec8610cfdc adds a default source to #apple_touch_icon_link_tag 2010-04-07 13:20:52 -07:00
Xavier Noria
d18ff1b7ef new helpers #favicon_link_tag and #apple_touch_icon_link_tag 2010-04-07 13:04:52 -07:00
Jeremy Kemper
3957d44fd1 Use request.body IO and rewind, if possible 2010-04-07 11:42:07 -07:00
Joshua Peek
086392492c Remove #size call on rack input io 2010-04-07 11:41:14 -07:00
José Valim
149d13e1f0 Move the error raising to api_behavior. 2010-04-07 16:18:13 +02:00
José Valim
eb063538bd Use config.filter_parameters on in-browser request dump. [#4335 state:resolved] 2010-04-07 01:42:51 +02:00
Xavier Noria
4c4fd1a60f Merge commit 'rails/master' 2010-04-06 15:38:05 -07:00
José Valim
46e2a44ee1 Rename search_field to test_search_field (ht: Piotr Usewicz) 2010-04-06 11:53:34 +02:00
David Heinemeier Hansson
ebc80ea1cb Merge branch 'master' of github.com:rails/rails 2010-04-05 16:08:03 -07:00
David Heinemeier Hansson
f8730e5ce6 Added all the new HTML5 form types as individual form tag methods (search, url, number, etc) (Closes #3646) [Stephen Celis] 2010-04-05 16:07:44 -07:00
wycats
0087d0748b Include author in changelog 2010-04-05 16:07:35 -07:00
Joshua Peek
570c54c39a Fix cookie access in integration tests with other host names 2010-04-05 15:22:09 -07:00
Santiago Pastorino
d270da569e changed from :object_name to :as on form_for api 2010-04-05 18:55:37 -03:00
Santiago Pastorino
c6746ffaf4 deprecate form_for(symbol_or_string, ...) in favor of :object_name option 2010-04-05 17:47:02 -03:00
Xavier Noria
89978f10af moves Object#singleton_class to Kernel#singleton_class to match Ruby also there, same for #class_eval to simplify, and adds coverage for class_eval 2010-04-05 12:15:08 -07:00
José Valim
6690d66292 Rename config.cookie_secret to config.secret_token and pass it as configuration in request.env. This is another step forward removing global configuration. 2010-04-05 12:00:24 +02:00
Xavier Noria
9ed919eb0b revises some <%= in rdoc 2010-04-05 02:51:26 -07:00
Xavier Noria
43d02dffcb <% yield to <%= yield in rdoc of _layout_for, and copy-edits it now that we are on it 2010-04-05 02:16:24 -07:00
wycats
5c8b4c6e23 Move filter_parameter_logger to deprecated.rb 2010-04-04 21:06:39 -07:00
wycats
79d194e920 Make it easier to subclass AC::Metal with most, but not all, of the modules in AC::Base 2010-04-04 21:06:26 -07:00
wycats
b96486d457 Whitespace 2010-04-04 20:09:03 -07:00
wycats
485512c50f Whitespace 2010-04-04 19:58:16 -07:00
wycats
209fb5190b render_to_string should have the identical signature as render 2010-04-04 19:58:15 -07:00
Rizwan Reza
181e4aac52 We don't need explicit :url => { :action => "create" } in form_for when following Rails conventions. 2010-04-05 06:45:15 +04:30
Xavier Noria
723e91e9fd Merge commit 'docrails/master' 2010-04-04 13:36:15 -07:00
wycats
b546945b51 Reapply redirect {|params, request| } with passing tests this time 2010-04-04 13:17:14 -07:00
Jeremy Kemper
3e5f5f2a48 Revert "Pass in the request as an optional second parameter to redirect" 
Was not tested.

This reverts commit a8c3c71af1.
 2010-04-04 11:12:19 -07:00
Jeremy Kemper
e3959970e1 Fix signed cookies by explicitly passing config to the cookie jar 2010-04-04 11:10:00 -07:00
Andrew White
00884a5901 Merge branch 'master' of github.com:lifo/docrails 2010-04-04 17:34:23 +01:00
Andrew White
48b2451142 Update various documentation examples to use new routing DSL 2010-04-04 17:34:13 +01:00
Aman Gupta
af89c58696 Use a constant proc to generate ActionView::Template finalizers. For some strange reason, finalizers created via ActionView::Template.finalizer_for cause Template instances to leak on MRI. 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-04 02:10:21 -07:00
wycats
a8c3c71af1 Pass in the request as an optional second parameter to redirect 2010-04-03 21:20:45 -07:00
wycats
ab8bf9e152 * Change the object used in routing constraints to be an instance of 
ActionDispatch::Request rather than Rack::Request.

* Changed ActionDispatch::Request#method to return a String, to be
  compatible with the Rack::Request superclass.

* Changed ActionDispatch::Request#method to return the original
  method in the case of methodoverride and #request_method not to,
  to be compatible with Rack::Request
 2010-04-03 20:24:30 -07:00
Santiago Pastorino
8f9becb426 :action => "create" added to form_for with name only to show appropiate behavior 2010-04-03 18:36:29 -03:00
Santiago Pastorino
10ad15861f :action => "update" used in a non RESTful way confuses 2010-04-03 18:22:58 -03:00
Xavier Noria
11161e6c96 Merge commit 'rails/master' 2010-04-03 10:56:15 -07:00
wycats
3eb97531b8 Refactored url_for in AV to have its own instances of the helpers instead of proxying back to the controller. This potentially allows for more standalone usage of AV. It also kicked up a lot of dust in the tests, which were mocking out controllers to get this behavior. By moving it to the view, it made a lot of the tests more standalone (a win) 2010-04-03 02:44:02 -07:00
wycats
b29e893688 Fix memory leak in dev mode 2010-04-02 19:21:19 -07:00
Jeremy Kemper
ee7605ecf0 Key partial name cache on controller and object class *names* to avoid memory leaks in dev mode 2010-04-02 15:54:38 -07:00