Commit Graph

4370 Commits

Author SHA1 Message Date
Joshua Peek
6c581f5fd5 Kill routing tests expecting path to be unescaped. Most rack servers already escape PATH_INFO. 2009-10-19 22:42:11 -05:00
Joshua Peek
33258d713a Fix brittle query string comparisons 2009-10-19 22:42:11 -05:00
Jeremy Kemper
c9cd10c4fa Bundle arel for AR integration tests 2009-10-19 19:00:17 -07:00
Jeremy Kemper
418ce487c4 Only undef to_json if it's defined 2009-10-19 18:46:59 -07:00
Jeremy Kemper
acb1624f27 Merge commit 'josevalim/fixes'
Conflicts:
	railties/test/generators/app_generator_test.rb
2009-10-19 18:37:19 -07:00
Jeremy Kemper
a49c3b0365 Merge branch 'master' of github.com:rails/rails 2009-10-19 12:33:36 -07:00
Joshua Peek
91726c201b Relax generation requirements and only enforce the requirements used in the path segment 2009-10-18 11:05:24 -05:00
Joshua Peek
6873b1d658 Don't use use_controllers in routing tests 2009-10-18 00:26:36 -05:00
Joshua Peek
2c3ca9ae80 This is routing error message test is tightly coupled to the implementation. Just test that it raises an exception. 2009-10-17 21:56:43 -05:00
Joshua Peek
f1767c1513 Drop legacy support for case insensitive controller recognition 2009-10-17 21:21:34 -05:00
Joshua Peek
cc0103fe83 Fix brittle query string comparisons 2009-10-17 19:18:18 -05:00
Joshua Peek
e900a8437a Fix brittle query string comparisons 2009-10-17 17:35:21 -05:00
Joshua Peek
702df0d238 Fix standalone run of routing test. Only reference controllers that are provided in fake_controllers 2009-10-17 17:35:21 -05:00
Joshua Peek
6c2a73909e Stop using with_controllers in tests 2009-10-17 17:35:20 -05:00
Joshua Peek
e00f57e208 No longer need this special routing exception message because these kinds of ambiguous generations are deprecated 2009-10-17 17:35:20 -05:00
Joshua Peek
20f0b33035 Drop support for routing :generate_all 2009-10-17 17:35:20 -05:00
Joshua Peek
d50413826f Invalid route requirements should always raise an exception even if they are unused 2009-10-17 17:35:19 -05:00
José Valim
cb87302689 Bring agnosticism to error_messages_for. 2009-10-17 13:03:28 -03:00
José Valim
2e37effd72 Unify class_inheritable_accessor and extlib_inheritable_accessor and allow responder to be set in the class level. 2009-10-17 12:54:03 -03:00
Jeremy Kemper
028911ad00 Use rails/rack 2009-10-16 17:39:12 -07:00
Yehuda Katz
7e9e370e03 Make encodings work with Erubis and 1.9 again 2009-10-16 17:28:44 -07:00
Joshua Peek
c1261b5484 Use Rails.application where we want a valid rack app 2009-10-16 19:04:28 -05:00
Carl Lerche
2110a524a4 Deprecate RAILS_ROOT in favor of Rails.root (which proxies to the application's object root) 2009-10-16 12:51:02 -07:00
Joshua Peek
6094e65169 We won't be publishing tars and zips anymore 2009-10-16 13:56:59 -05:00
Yehuda Katz
a565c19c5b Fix a bug where templates with locales were not being sorted correctly 2009-10-16 11:26:19 -07:00
Jeremy Kemper
71f7e75d95 Merge branch 'master' into orchestra 2009-10-15 17:36:54 -07:00
Yehuda Katz
ef70ad5538 Fix a few more 1.9 bugs. Rack 1.0.1 is required for 1.9 compliance but not release, so bundling 1.0.1 from git 2009-10-15 17:16:42 -07:00
Yehuda Katz
c44d560145 Rack responses need to wrap Strings in 1.9 2009-10-15 16:37:27 -07:00
Yehuda Katz
e9d6bcd19f Update MetalTest for constant scoping change in 1.9 2009-10-15 16:33:47 -07:00
Yehuda Katz
4869b74aee Fix test to correctly handle 1.9 Array#to_s behavior 2009-10-15 16:27:26 -07:00
Yehuda Katz
b71f83c9cc Work around apparent bug in 1.9 2009-10-15 16:03:30 -07:00
José Valim
2d7abe245e Renamed Orchestra to Notifications once again [#3321 state:resolved] 2009-10-15 18:51:51 -03:00
Yehuda Katz
e1490d4e4c Change config implementation in AV slightly 2009-10-15 14:41:59 -07:00
José Valim
a15e02d44a Unify benchmark APIs. 2009-10-15 18:19:25 -03:00
José Valim
8f59d7a8d8 Instrument cache store events only if required. 2009-10-15 18:19:24 -03:00
José Valim
af0d1fa892 Update Orchestra instrumentations and move part of logging to Orchestra. 2009-10-15 18:18:44 -03:00
José Valim
8b340ab2f6 Revert "Rename Orchestra to Notifications [#3321 state:resolved]"
This reverts commit 8cbf825425.
2009-10-15 18:06:15 -03:00
Yehuda Katz
cb8b0f4a5a Make this less brittle and work on 1.8 2009-10-15 13:35:22 -07:00
Jeremy Kemper
428c0bd4ba Kill rake bundle 2009-10-15 00:29:21 -07:00
Jeremy Kemper
deafa10e6c AP tests depend on AR 2009-10-15 00:22:15 -07:00
Michael Koziarski
b1201792a7 Make the erubis implementation easier for plugins to change. 2009-10-15 17:54:01 +13:00
Michael Koziarski
cc1ad46ead Add a read-only method which plugin authors can use to determine if xss escaping.
This doesn't provide a way to turn off the escaping, but alternative template engine authors
can figure out what their default should be by calling this.  Avoids a messy version + plugin check.
2009-10-15 17:22:50 +13:00
Jeremy Kemper
4484f0bccf Don't push siblings on load path if using bundled env 2009-10-14 20:59:45 -07:00
Jeremy Kemper
c09a5ffea7 Merge branch 'arel' 2009-10-14 19:32:09 -07:00
Jeremy Kemper
6eee1dd62c Clarify AR dependency 2009-10-14 19:31:29 -07:00
Joshua Peek
bc1a18d7bd Punt on ConcurrentHash [#3322 state:resolved] 2009-10-14 19:53:52 -05:00
Joshua Peek
8cbf825425 Rename Orchestra to Notifications [#3321 state:resolved] 2009-10-14 19:50:36 -05:00
George Ogata
3de8b44b26 Make IntegrationTest::Runner propagate method_missing to ancestors.
Fixes RSpec integration example groups, which mixes its Matchers
module into ActiveSupport::TestCase.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-10-15 11:01:42 +13:00
Craig Smith
316f4704ea Test cases should see all the cookies, not just cookies that have been set in the controller.
Previously this example would always pass, even when cookies.delete was not called.

@request.cookies['foo'] = 'bar'
get :delete_cookie
assert_nil cookies['foo']

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#2768 state:committed]
2009-10-15 10:58:55 +13:00
Michael Koziarski
1d01bad3ce Make sure non-escaped urls aren't considered safe 2009-10-15 09:58:35 +13:00