Commit Graph

952 Commits

Author SHA1 Message Date
David Heinemeier Hansson
ccfcd9fe22 Doc fixes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3780 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 20:00:04 +00:00
David Heinemeier Hansson
4f00c70580 Fixed eager loading problems with single-table inheritance [Rick Olson] Added smarter table aliasing for eager associations for multiple self joins [Rick Olson] (closes #3580)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3776 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 18:43:56 +00:00
David Heinemeier Hansson
55854c4195 Added cascading eager loading that allows for queries like Author.find(:all, :include=> { :posts=> :comments }), which will fetch all authors, their posts, and the comments belonging to those posts in a single query (using LEFT OUTER JOIN) #3913 [anna@wota.jp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 23:33:10 +00:00
Jamis Buck
ff881c7f8b Make counter cache work when replacing an association (closes #3245). Thanks for the patch!
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 19:42:41 +00:00
Jamis Buck
c0fb67c0f8 Make migrations verbose
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3760 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 18:46:51 +00:00
David Heinemeier Hansson
3dcf7fe4e9 Fixed that Date was in incorrect format in tasks.yml (closes #4072) [mlaster@metavillage.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 17:17:43 +00:00
Jamis Buck
964b67dd0e Make counter_cache work with polymorphic belongs_to
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3756 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 15:11:17 +00:00
David Heinemeier Hansson
116658e69b Fixed that calling HasOneProxy#build_model repeatedly would cause saving to happen (closes #4058) [anna@wota.jp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3753 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-03 06:25:39 +00:00
Jeremy Kemper
68ff2ebbea fix unreplaced class var
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 22:04:38 +00:00
Jeremy Kemper
215852745b Revert allow_concurrency change for better testing. Retrieve_connection in two steps to avoid side-effect bug (yuk).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3745 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 14:36:06 +00:00
David Heinemeier Hansson
a4c6442612 More docs for observers (closes #3996) [Robby Russel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 03:02:51 +00:00
David Heinemeier Hansson
b0245a57d6 No longer needed (closes #4017)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3742 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 02:54:34 +00:00
David Heinemeier Hansson
456ddc6f61 Doc fix (closes #4014) [thijs@fngtps.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3741 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 02:53:57 +00:00
David Heinemeier Hansson
f62b8af688 Catch requirement of Sybase adapter, if we cant, dont have it
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3737 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 01:37:41 +00:00
David Heinemeier Hansson
5ba5dd68da Dont require sybase unless you try to connect
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 01:31:29 +00:00
David Heinemeier Hansson
ec4dd572e7 Added Sybase database adapter that relies on the Sybase Open Client bindings (see http://raa.ruby-lang.org/project/sybase-ctlib) (closes #3765) [John Sheets]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3735 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 01:25:50 +00:00
David Heinemeier Hansson
6a3f4c932a Added Sybase database adapter that relies on the Sybase Open Client bindings (see http://raa.ruby-lang.org/project/sybase-ctlib) (closes #3765) [John Sheets]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3734 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 01:15:41 +00:00
Jeremy Kemper
a434cec2e6 (duh :)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3732 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-01 22:14:00 +00:00
Jeremy Kemper
d28c0f7405 Typo in stale thread removal.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-01 22:09:46 +00:00
Jeremy Kemper
7568f18a2a Clear stale, cached connections left behind by defunct threads. Eliminate duplicate connection cache.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-01 22:05:41 +00:00
Jeremy Kemper
d8641ca34f CHANGED DEFAULT: set ActiveRecord::Base.allow_concurrency to false. Most AR usage is in single-threaded applications.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-01 22:04:30 +00:00
David Heinemeier Hansson
a8d085adf0 Make calculations typecasty! (closes #4016) [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3722 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-01 16:25:14 +00:00
David Heinemeier Hansson
631181ca18 Renamed the "oci" adapter to "oracle", but kept the old name as an alias (closes #4017) [schoenm@earthlink.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-01 16:01:53 +00:00
David Heinemeier Hansson
491554f6dd Make #save return true on success, even if locking is enabled (closes #4015) [schoenm@earthlink.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3716 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-01 05:43:50 +00:00
David Heinemeier Hansson
6417cdd846 Fixed tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3708 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-28 20:39:21 +00:00
David Heinemeier Hansson
4c7555aef7 Fixed that Base.save should always return false if the save didn't succeed, including if it has halted by before_save's (closes #1861, #2477) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3707 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-28 20:37:21 +00:00
Michael Koziarski
17ff70ac84 Make rake load_fixtures work with the new, flexible, fixtures api. [Rick Olson]. Closes #3995
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3706 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-28 20:18:02 +00:00
Michael Koziarski
a117d68f0f Add more documentation for Reflection. [robby@planetargon.com]. Closes #4001
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-28 20:13:37 +00:00
Jeremy Kemper
1b3bae967d Add missing fixtures for #3937.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3700 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-28 17:46:16 +00:00
David Heinemeier Hansson
b56cac56dd Added new column to all db definitions. Where, oh where, is our hereo that will convert all the legacy fixture schemas to schema.rb? (closes #3993) [Bob Silva]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3695 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-28 04:23:44 +00:00
Nicholas Seckar
1383d1c3b9 Change Fixtures.create_fixtures arity to be backwards compatible
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-28 00:40:33 +00:00
Jeremy Kemper
3cfea287ba Speed up class -> connection caching and stale connection verification. Closes #3979.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3693 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-27 21:37:30 +00:00
Nicholas Seckar
2bb52dcba0 Fix delerious changelog
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3691 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-27 20:36:40 +00:00
Nicholas Seckar
ada11d6313 Add set_fixture_class to allow the use of table name accessors with models which use set_default_name. Closes #3935
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3690 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-27 20:29:28 +00:00
David Heinemeier Hansson
018e7f24f0 Only load .yml files in sub-directories
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-27 05:26:42 +00:00
David Heinemeier Hansson
91247b6167 Added that fixtures to placed in subdirectories of the main fixture files are also loaded (closes #3937) [dblack@wobblini.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3683 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-27 05:14:57 +00:00
David Heinemeier Hansson
adccb319e2 doc fix (closes #3972) [robby]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3682 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-27 05:10:04 +00:00
David Heinemeier Hansson
8203a2afc1 Dont require association classes before theyre supposed to be used (closes #3976) [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3681 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-27 04:45:36 +00:00
Jeremy Kemper
1a06d324df Define attribute query methods to avoid method_missing calls. Closes #3677.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3679 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-27 00:27:48 +00:00
David Heinemeier Hansson
660952e5b0 CHANGED DEFAULT: ActiveRecord::Base.schema_format is now :ruby by default instead of :sql. This means that we'll assume you want to live in the world of db/schema.rb where the grass is green and the girls are pretty. If your schema contains un-dumpable elements, such as constraints or database-specific column types, you just got an invitation to either 1) patch the dumper to include foreign key support, 2) stop being db specific, or 3) just change the default in config/environment.rb to config.active_record.schema_format = :sql -- we even include an example for that on new Rails skeletons now. Brought to you by the federation of opinionated framework builders! [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3678 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-27 00:23:49 +00:00
David Heinemeier Hansson
c5ff33cd7b Example for validates_presence_of method (closes #3966) [Robby Russell]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-26 23:58:22 +00:00
Jeremy Kemper
6bd8e35136 ActiveRecord::Base.remove_connection explicitly closes database connections and doesn't corrupt the connection cache. Introducing the disconnect! instance method for the PostgreSQL, MySQL, and SQL Server adapters; implementations for the others are welcome. References #3591.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3674 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-26 23:12:01 +00:00
Jeremy Kemper
3848634a4b fix method scoping test for postgresql
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3673 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-26 23:03:59 +00:00
David Heinemeier Hansson
1215d54c2f Added support for nested scopes (closes #3407) [anna@wota.jp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-26 20:12:09 +00:00
David Heinemeier Hansson
3d0a9ff437 Aesthetics, baby
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3658 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-26 00:41:01 +00:00
David Heinemeier Hansson
09751e57b0 Fixed db2 connection with empty user_name and auth options (closes #3622) [phurley@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3655 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-26 00:01:13 +00:00
David Heinemeier Hansson
272729e0a3 Fixed validates_length_of to work on UTF-8 strings by using characters instead of bytes (closes #3699) [Masao Mutoh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3654 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-25 23:54:57 +00:00
David Heinemeier Hansson
ad9f678d13 Compatibility patches for calculations
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3653 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-25 23:41:51 +00:00
David Heinemeier Hansson
5e99422d61 Updated docs (closes #3799) [ruby@bobsilva.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3651 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-25 23:33:08 +00:00
David Heinemeier Hansson
c350291ae7 Fixed that reflections would bleed across class boundaries in single-table inheritance setups (closes #3796) [lars@pind.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3650 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-25 23:32:24 +00:00