Commit Graph

737 Commits

Author SHA1 Message Date
Jeremy Kemper
ce99c87551 Cope with missing content type and length headers. Parse parameters from multipart and urlencoded request bodies only. Accept multipart PUT parameters. Closes #5235.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-01 00:01:48 +00:00
David Heinemeier Hansson
f9cd92f4ee Added interrogation of params[:format] to determine Accept type. If :format is specified and matches a declared extension, like "rss" or "xml", that mime type will be put in front of the accept handler. This means you can link to the same action from different extensions and use that fact to determine output [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4384 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-31 18:52:24 +00:00
David Heinemeier Hansson
bf1b06e90a Easy way to set accepting for functional tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-31 04:49:18 +00:00
David Heinemeier Hansson
4a98cbe2dd If not passing a hash, assume :id => whatever
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4381 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-31 04:48:46 +00:00
Jeremy Kemper
6ce3bf70a2 follow_redirect doesn't complain about being redirected to the same controller. Closes #5153.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-22 22:59:56 +00:00
Jeremy Kemper
0cd883e1e1 Change the request.env example in AC::Base docs to a var that exists (REMOTE_IP doesn't) and isn't already wrapped by a request method (i.e. request.remote_ip). Closes #5113.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-17 19:52:06 +00:00
Marcel Molina
7252666b74 Add layout attribute to response object with the name of the layout that was rendered, or nil if none rendered. [Kevin Clark kevin.clark@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-17 07:25:36 +00:00
Michael Koziarski
ff96498848 performance enhancement for previous patch [skaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4344 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-16 21:09:41 +00:00
Michael Koziarski
d153525c53 Fix NoMethodError when parsing params like &&. [Adam Greenfield]. Closes #4955
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-16 20:56:41 +00:00
Marcel Molina
6ef5b747b3 Fix flip flopped logic in docs for url_for's :only_path option. Closes #4998. [esad@esse.at]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4341 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-14 19:03:14 +00:00
Rick Olson
04ef7f4be6 Small fix in routing to allow dynamic routes (broken after [4242]) [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-30 21:06:49 +00:00
Rick Olson
59bd6586c8 Add Integration Session methods for PUT and DELETE requests [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-30 20:17:06 +00:00
Marcel Molina
9f92dd3984 Replace alias method chaining with Module#alias_method_chain. [Marcel Molina Jr.]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4312 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-29 20:20:22 +00:00
Marcel Molina
6186490962 Replace Ruby's deprecated append_features in favor of included. [Marcel Molina Jr.]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4310 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-29 18:10:14 +00:00
Marcel Molina
869c41d8d6 Revert unintential change to filter parameters
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4308 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-29 17:47:10 +00:00
Marcel Molina
0049bd729f Update README
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-29 16:34:23 +00:00
Marcel Molina
c745f47804 Use #flush between switching from #write to #syswrite. Closes #4907. [Blair Zajac <blair@orcaware.com>]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4306 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-29 05:06:49 +00:00
Marcel Molina
f3ce39749c Documentation fix: integration test scripts don't require integration_test. Closes #4914. [Frederick Ros <sl33p3r@free.fr>]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4292 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-27 22:51:39 +00:00
Marcel Molina
dd5397a57c ActionController::Base Summary documentation rewrite. Closes #4900. [kevin.clark@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4290 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-27 18:22:20 +00:00
Marcel Molina
8ee378f3c4 Enhance documentation for setting headers in integration tests. Skip auto HTTP prepending when its already there. Closes #4079. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4286 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-26 22:13:31 +00:00
Marcel Molina
cbded64014 Documentation for AbstractRequest. Closes #4895. [kevin.clark@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4277 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-26 18:35:53 +00:00
Marcel Molina
09095c7204 Remove all remaining references to @params in the documentation.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-25 17:42:48 +00:00
Marcel Molina
21142201c9 Add documentation for redirect_to :back's RedirectBackError exception.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-25 06:32:07 +00:00
Marcel Molina
7bb20659c2 Update layout and content_for documentation to use yield rather than magic @content_for instance variables.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-25 04:03:51 +00:00
Rick Olson
51cd1aec00 Fix assert_redirected_to tests according to real-world usage.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-25 03:54:46 +00:00
Rick Olson
e1c7b5a7f6 Cache CgiRequest#request_parameters so that multiple calls don't re-parse multipart data.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-23 18:18:17 +00:00
Rick Olson
3900b36896 Diff compared routing options. Allow #assert_recognizes to take a second arg as a hash to specify optional request method [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-23 18:16:51 +00:00
Rick Olson
7bd6923c7f allow -'s in tag names for html scanner when scanning AR xml documents
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-22 18:12:31 +00:00
Rick Olson
92bd54ea19 Use ActiveSupport's String#join method
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-22 15:17:56 +00:00
Rick Olson
526c69b49e Diff compared options with #assert_redirected_to [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-22 15:08:25 +00:00
Rick Olson
ed02f415d7 reset TestRequest#parameters after assigning paramters
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-22 04:59:15 +00:00
Jamis Buck
0a0b5bd722 fix to ';' interpretation in route recognition--only follow a route with ';' if the segment in question actually contains a ';'
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-21 17:21:26 +00:00
Jamis Buck
1f80f540a7 Add support in routes for semicolon delimited "subpaths", like /books/:id;:action
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-21 15:17:02 +00:00
Jamis Buck
7a8883eee9 Modify routing so that you can say :require => { :method => :post } for a route, and the route will never be selected unless the request method is POST. Only works for route recognition, not for route generation.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4209 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-13 05:44:23 +00:00
Sam Stephenson
23585d721d Added :add_headers option to verify which merges a hash of name/value pairs into the response's headers hash if the prerequisites cannot be satisfied
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-08 07:04:21 +00:00
David Heinemeier Hansson
47b74e6e16 Added ActionController.filter_parameter_logging that makes it easy to remove passwords, credit card numbers, and other sensitive information from being logged when a request is handled #1897 [jeremye@bsa.ca.gov]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-07 22:26:25 +00:00
Marcel Molina
ac97c7a90e Do filter condition lookup against the actual hash
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4180 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-06 04:50:45 +00:00
Marcel Molina
4859b6c09e Honor skipping filters conditionally for only certain actions even when the parent class sets that filter to conditionally be executed only for the same actions. Closes #4522.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-05 04:39:59 +00:00
Jamis Buck
3bf3bc228c Delegate xml_http_request in integration tests to the session instance.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4161 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-04 20:16:29 +00:00
Nicholas Seckar
e714b25723 Update the diagnostics template skip the useless '<controller not set>' text.
Fix symbol extensions test case.
Clean paths inside of exception messages and traces.
Add Pathname.clean_within for cleaning all the paths inside of a string.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-04 19:37:29 +00:00
David Heinemeier Hansson
62dc792a48 CHANGED DEFAULT: Don't parse YAML input by default, but keep it available as an easy option [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-04 19:28:25 +00:00
David Heinemeier Hansson
dc87eba062 Fixed fragment caching of binary data on Windows (closes #4493) [bellis@deepthought.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-01 20:41:53 +00:00
Marcel Molina
f28d619534 Add documentation for respond_to
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4083 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-28 03:39:23 +00:00
David Heinemeier Hansson
dfd953ea96 Fixed docs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-28 03:19:27 +00:00
David Heinemeier Hansson
b6e7cc63de Spell existence properly (closes #4442)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4072 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-27 23:43:50 +00:00
Rick Olson
3f496c6638 add the TestCase.fixture_path when testing file uploads
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-27 02:24:47 +00:00
David Heinemeier Hansson
9326222941 Use example.com as standard (closes #4413) [anna]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4026 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-25 19:43:40 +00:00
Jamis Buck
7bcf4c6659 Enable application/x-yaml processing by default
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4024 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-25 18:44:28 +00:00
Jamis Buck
b0189f3f2f Fix assert_redirected_to so it works with symbols
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 18:16:48 +00:00
David Heinemeier Hansson
6d7335752a Comments, comments
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 05:40:42 +00:00