Commit Graph

76 Commits

Author SHA1 Message Date
David Heinemeier Hansson
4b8d156ca5 Removed unused statement
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 18:39:05 +00:00
David Heinemeier Hansson
d440cf6483 Fixed snag in status reporting
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 18:35:38 +00:00
David Heinemeier Hansson
65e4e5e337 Only log status if there is one different from 200 set
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 12:38:50 +00:00
David Heinemeier Hansson
e9cfe955cc Add a catch-all eraser
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-25 08:49:19 +00:00
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985 Added test for template to layout variable transfer
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 08:43:01 +00:00
David Heinemeier Hansson
1aab0e2c30 Doc fixes #1775, #1776 [jon@instance-design.co.uk]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 06:27:07 +00:00
David Heinemeier Hansson
bd558ef98e Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-21 07:14:35 +00:00
David Heinemeier Hansson
d2d38f6700 Added Base#expires_in(seconds)/Base#expires_now to control HTTP content cache headers #1755 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1845 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 09:20:20 +00:00
David Heinemeier Hansson
cb0f8fda96 Worked around a Safari bug where it wouldn't pass headers through if the response was zero length by having render :nothing return ' ' instead of ''
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1818 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 19:31:48 +00:00
David Heinemeier Hansson
fede0f573e Fixed documentation for :action/:template confusion #1643
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1813 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 07:10:32 +00:00
David Heinemeier Hansson
14e7c7c21d Better documentation for Calling multiple redirects or renders #1687 [courtenay]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1795 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:26:55 +00:00
Jamis Buck
8266867881 Improved error message for DoubleRenderError
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 15:31:06 +00:00
David Heinemeier Hansson
93ec99c246 Partly tuned docs for release (AP)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 08:27:11 +00:00
David Heinemeier Hansson
977b4be208 Changed logging of SQL statements to use the DEBUG level instead of INFO. Added logging of the request URI in the benchmark statement (makes it easy to grep for slow actions). Changed the default logging level in config/environment.rb to INFO for production (so SQL statements won't be logged)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 17:23:41 +00:00
Jeremy Kemper
fa158ff07a r2829@asus: jeremy | 2005-07-04 23:31:55 -0700
cache protected_instance_variables


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1690 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 01:31:03 +00:00
Jeremy Kemper
d2b9e39c85 r2828@asus: jeremy | 2005-07-04 22:02:44 -0700
cache controller_name and controller_path


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 01:30:49 +00:00
Jeremy Kemper
c6f819edb7 r2827@asus: jeremy | 2005-07-04 21:30:06 -0700
precompute action_name


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 01:30:44 +00:00
David Heinemeier Hansson
eb2b86d795 Added ActionController::Base.enable_upload_progress for people who want to play with the experimental upload progress
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1607 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 11:29:41 +00:00
David Heinemeier Hansson
f0e9fd74ae Make render(:inline) use locals #1556 [Michael Shuerig]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1584 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-01 18:21:29 +00:00
David Heinemeier Hansson
62ed6950c9 Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1552 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 17:42:51 +00:00
David Heinemeier Hansson
8e56f5ea3e Improved performance of Routes generation by a factor of 5 #1434 [Nicholas Seckar] Added named routes (NEEDS BETTER DESCRIPTION) #1434 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1496 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 16:40:01 +00:00
David Heinemeier Hansson
0c3298f2f2 Added ActionController::Base.allow_concurrency to control whether the application is thread-safe, so multi-threaded servers like WEBrick knows whether to apply a mutex around the performance of each action. Action Pack and Active Record are by default thread-safe, but many applications may not be. Turned off by default.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1487 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-23 06:56:12 +00:00
Jamis Buck
e4c047e489 render(:action) and render() are the only two render calls to use a layout by default. All others default to :layout => false. Also, allow :layout => true to be a synonym for :layout => nil.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-01 13:39:58 +00:00
Jamis Buck
00db6f0faa render(:partial => "...") uses an empty hash for the local assigns #1365. render(:partial => true) is identical to the older render_partial()
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:20:37 +00:00
David Heinemeier Hansson
060ecf1a24 Set redirected_to proper
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 16:52:54 +00:00
David Heinemeier Hansson
2f7c5f84e4 Cure some ills discovered with the refactoring
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 11:07:09 +00:00
David Heinemeier Hansson
da0c4c5c96 Deprecated all render_* methods in favor of consolidating all rendering behavior in Base#render(options). This enables more natural use of combining options, such as layouts
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 08:58:43 +00:00
David Heinemeier Hansson
0367317dd6 Deprecated redirect_to_path and redirect_to_url in favor of letting redirect_to do the right thing when passed either a path or url. Introduced r as a unified method for render (still under construction)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 07:43:05 +00:00
David Heinemeier Hansson
dab360e181 Added DoubleRenderError exception that'll be raised if render* is called twice #518 [Nicholas Seckar]. Fixed exceptions occuring after render has been called #1096 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-21 18:51:08 +00:00
David Heinemeier Hansson
7159402c6d Fixed use of an integer as return code for renders, so render_text "hello world", 404 now works #1327
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-21 17:50:57 +00:00
David Heinemeier Hansson
c971c24839 Changed RAILS_ASSET_HOST to become ActionController::Base.asset_host
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-06 05:10:36 +00:00
David Heinemeier Hansson
537efa36d0 Doc fix #1200
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 13:36:40 +00:00
David Heinemeier Hansson
6d0ddd818a Fixed render_partial_collection to output an empty string instead of nil when handed an empty array #1202 [Ryan Carver]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:29:50 +00:00
David Heinemeier Hansson
e5b3d08a0a Added that render_partial called from a controller will use the action name as default #828 [Dan Peterson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:25:54 +00:00
David Heinemeier Hansson
6ee06ebec6 Changed render_partial to take local assigns as the second parameter instead of an explicit object and then the assigns
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 16:08:29 +00:00
David Heinemeier Hansson
2119e0699a Fixed that the content-type for some browsers could include an additional \r which made wonky things happen #1067 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:22:32 +00:00
David Heinemeier Hansson
7a6a923f98 Added trailing_slash option to url_for, so you can generate urls ending in a slash. Note that is currently not recommended unless you need it for special reasons since it breaks caching #937 [stian@grytoyr.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 13:38:21 +00:00
David Heinemeier Hansson
cef57e0cc2 Added documentation on models in sessions #929 [c.r.mcgrath@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 13:35:22 +00:00
David Heinemeier Hansson
9c605227ec Added a bit more to the session documentation on how to clear sessions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@922 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 13:34:07 +00:00
David Heinemeier Hansson
7ece0e166d Added render_partial/render_partial_collection from controllers for easier Ajaxing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@880 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-09 15:26:36 +00:00
David Heinemeier Hansson
6d566e82b4 Fixed rails_generator to be usable without RubyGems #686 [Cristi BALAN]. Moved all active support dependencies into active support
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 12:20:53 +00:00
David Heinemeier Hansson
e4efcfd43e Updated documentation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@780 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 01:29:43 +00:00
David Heinemeier Hansson
41ea6963a3 Added Base#render_to_string to parse a template and get the result back as a string #479
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 14:57:08 +00:00
David Heinemeier Hansson
5c4f185997 Fixed that send_file/data can work even if render* has been called before in action processing to render the content of a file to be send for example #601
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 14:05:00 +00:00
David Heinemeier Hansson
69f18a7a81 Keep the singular style, like before_filter, etc
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 12:53:08 +00:00
David Heinemeier Hansson
12a7573630 Added new keyword to specify load paths as being component based. Added better logging for component calls
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-20 13:50:13 +00:00
David Heinemeier Hansson
04b8bc1bdd Fixed that a bunch of methods from ActionController::Base was accessible as actions (callable through a URL) when they shouldn't have been #644 [Nicholas Seckar]. Base#hide_actions(*names) to hide public methods from a controller that would otherwise have been callable through the URL. For the majority of cases, its preferred just to make the methods you don't want to expose protected or private (so they'll automatically be hidden) -- but if you must have a public method, this is a way to make it uncallable. Base#hidden_actions retrieve the list of all hidden actions for the controller #644 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 18:59:51 +00:00
David Heinemeier Hansson
dc3d6eb9b4 Moved Active Support into its own gem
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 15:57:44 +00:00