github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-29 08:18:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,114 Commits 34 Branches 105 Tags
cee92312cfe6d573945b341e2de5d4ae7268bfcd
Commit Graph

978 Commits

Author SHA1 Message Date
David Heinemeier Hansson
cee92312cf Stop the MySQL adapter crashing when views are present. (closes #3782) [Jonathan Viney] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-16 03:00:27 +00:00
Rick Olson
e74ec90a07 added test checking that NOT NULL is properly reflected on [nathaniel@talbott.ws] closes #4125 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-16 02:55:38 +00:00
Rick Olson
def746030c Added Base.abstract_class? that marks which classes are not part of the Active Record hierarchy. closes #3704 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3882 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-16 02:46:01 +00:00
Rick Olson
0859779d6f Allow :dependent options to be used with polymorphic joins. #3820 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-16 02:10:11 +00:00
Jamis Buck
6e283e9dc7 Upgrade to Transaction::Simple 1.3 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3875 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-15 18:22:12 +00:00
Rick Olson
fa4fb50186 fix calculation tests to get around inconsistent ordering of nils 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3872 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-15 03:50:47 +00:00
Michael Koziarski
c42cd3c383 make save! return true on success[johan@johansorensen.com]. Closes #4173 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3871 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-15 02:32:14 +00:00
Michael Koziarski
c32fa73ea1 Unit test fixes for postgresql. 
Allow to_xml tests to pass in time zones other than CST.



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3870 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-15 02:17:31 +00:00
Michael Koziarski
eccf39203f Correct syntax error in postgresql schema definition 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3868 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-15 01:31:00 +00:00
Rick Olson
4965a754d5 Catch FixtureClassNotFound when using instantiated fixtures on a fixture that has no ActiveRecord model [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-14 15:15:06 +00:00
Rick Olson
796a43dead Allow ordering of calculated results and/or grouped fields in calculations [solo@gatelys.com] closes #4228 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3865 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-14 14:59:14 +00:00
Jeremy Kemper
25fb2db409 Dynamically set allow_concurrency. Closes #4044. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-13 17:28:55 +00:00
David Heinemeier Hansson
51d6bc2807 Passing comment 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3835 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-10 17:28:21 +00:00
David Heinemeier Hansson
3442e0c671 Added options to control the :only/:except for included associations on Base#to_xml [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-10 03:50:00 +00:00
David Heinemeier Hansson
db37c0c95f Added association inclusion in to_xml [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-10 00:25:29 +00:00
David Heinemeier Hansson
d872281975 Fixed to_xml across the board to use nice indention, better skip_attributes workings, no type on strings, and cleaned tests [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3829 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-09 21:12:28 +00:00
Jamis Buck
966c276d60 Fix counter cache setting in belongs-to proxy 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3828 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-09 20:55:14 +00:00
Jamis Buck
532f9d484c Add suppress_messages to migrations, to temporarily turn off verbose messages 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3827 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-09 18:38:39 +00:00
Jamis Buck
b95b09f32d a few more tests for the custom counter_cache naming code 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-09 18:11:41 +00:00
Jamis Buck
87898badba Allow counter_cache to accept a column name 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-09 17:23:57 +00:00
Michael Koziarski
57565b3506 format fix for locking [Michael Koziarski] 
Add documentation for :dependent on associations. [robby@planetargon.com] Closes #4151


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-09 08:40:34 +00:00
Rick Olson
2383a60443 Allow set_fixture_class to take Classes instead of strings for a class in a module. Raise FixtureClassNotFound if a fixture can't load. [Rick Olson] closes #4095 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3804 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-06 23:03:35 +00:00
Rick Olson
7c4b7affdb Fix quoting of inheritance column for STI eager loading #4098 [Jonathan Viney <jonathan@bluewire.net.nz>] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-06 16:00:46 +00:00
Rick Olson
c58dff1c9c slight change to eager associations table aliasing: use class_reflection, like 'post_comments' or 'tree_children' 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3788 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-06 04:47:58 +00:00
Rick Olson
5a7722de98 added assert_queries for the AR test suite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3784 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 23:41:17 +00:00
David Heinemeier Hansson
c450a36f16 Doc fixes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 21:37:12 +00:00
David Heinemeier Hansson
ccfcd9fe22 Doc fixes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3780 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 20:00:04 +00:00
David Heinemeier Hansson
4f00c70580 Fixed eager loading problems with single-table inheritance [Rick Olson] Added smarter table aliasing for eager associations for multiple self joins [Rick Olson] (closes #3580) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3776 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 18:43:56 +00:00
David Heinemeier Hansson
55854c4195 Added cascading eager loading that allows for queries like Author.find(:all, :include=> { :posts=> :comments }), which will fetch all authors, their posts, and the comments belonging to those posts in a single query (using LEFT OUTER JOIN) #3913 [anna@wota.jp] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-04 23:33:10 +00:00
Jamis Buck
ff881c7f8b Make counter cache work when replacing an association (closes #3245). Thanks for the patch! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-04 19:42:41 +00:00
Jamis Buck
c0fb67c0f8 Make migrations verbose 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3760 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-04 18:46:51 +00:00
David Heinemeier Hansson
3dcf7fe4e9 Fixed that Date was in incorrect format in tasks.yml (closes #4072) [mlaster@metavillage.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-04 17:17:43 +00:00
Jamis Buck
964b67dd0e Make counter_cache work with polymorphic belongs_to 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3756 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-04 15:11:17 +00:00
David Heinemeier Hansson
116658e69b Fixed that calling HasOneProxy#build_model repeatedly would cause saving to happen (closes #4058) [anna@wota.jp] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3753 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-03 06:25:39 +00:00
Jeremy Kemper
68ff2ebbea fix unreplaced class var 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 22:04:38 +00:00
Jeremy Kemper
215852745b Revert allow_concurrency change for better testing. Retrieve_connection in two steps to avoid side-effect bug (yuk). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3745 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 14:36:06 +00:00
David Heinemeier Hansson
a4c6442612 More docs for observers (closes #3996) [Robby Russel] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 03:02:51 +00:00
David Heinemeier Hansson
b0245a57d6 No longer needed (closes #4017) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3742 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 02:54:34 +00:00
David Heinemeier Hansson
456ddc6f61 Doc fix (closes #4014) [thijs@fngtps.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3741 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 02:53:57 +00:00
David Heinemeier Hansson
f62b8af688 Catch requirement of Sybase adapter, if we cant, dont have it 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3737 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 01:37:41 +00:00
David Heinemeier Hansson
5ba5dd68da Dont require sybase unless you try to connect 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 01:31:29 +00:00
David Heinemeier Hansson
ec4dd572e7 Added Sybase database adapter that relies on the Sybase Open Client bindings (see http://raa.ruby-lang.org/project/sybase-ctlib) (closes #3765) [John Sheets] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3735 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 01:25:50 +00:00
David Heinemeier Hansson
6a3f4c932a Added Sybase database adapter that relies on the Sybase Open Client bindings (see http://raa.ruby-lang.org/project/sybase-ctlib) (closes #3765) [John Sheets] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3734 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 01:15:41 +00:00
Jeremy Kemper
a434cec2e6 (duh :) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3732 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 22:14:00 +00:00
Jeremy Kemper
d28c0f7405 Typo in stale thread removal. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 22:09:46 +00:00
Jeremy Kemper
7568f18a2a Clear stale, cached connections left behind by defunct threads. Eliminate duplicate connection cache. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 22:05:41 +00:00
Jeremy Kemper
d8641ca34f CHANGED DEFAULT: set ActiveRecord::Base.allow_concurrency to false. Most AR usage is in single-threaded applications. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 22:04:30 +00:00
David Heinemeier Hansson
a8d085adf0 Make calculations typecasty! (closes #4016) [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3722 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 16:25:14 +00:00
David Heinemeier Hansson
631181ca18 Renamed the "oci" adapter to "oracle", but kept the old name as an alias (closes #4017) [schoenm@earthlink.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 16:01:53 +00:00
David Heinemeier Hansson
491554f6dd Make #save return true on success, even if locking is enabled (closes #4015) [schoenm@earthlink.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3716 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 05:43:50 +00:00