github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
9,902 Commits 34 Branches 105 Tags
cf3ccd7be0caae67dfddf5bc5056dcfdaab6f369
Commit Graph

3388 Commits

Author SHA1 Message Date
Joshua Peek
4e50a35fa2 Break up DependencyModule's dual function of providing a "depend_on" DSL and "included" block DSL into separate modules. But, unify both approaches under AS::Concern. 2009-05-28 11:35:36 -05:00
Joshua Peek
de203245af Revert "Revert "Whitespace!"" 
This reverts commit 0cac68d3be.
 2009-05-28 09:49:02 -05:00
Johan Sörensen
dd98280e38 Only save the session if we're actually writing to it [#2703 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-28 09:35:17 -05:00
Johan Sörensen
72cb6f58be The FlashHash and friends causes a lot of needless session storing, when we know for a fact that there's no content in the flash. By not storing the empty hash in the session we save a lot of communication with the various session backends, while still keeping the same interface to the flash. [#2703 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-28 09:30:49 -05:00
Olly Legg
0349278f3d Memoize cookies so that updates to cookies are available in the current request. [#2733 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-28 09:18:27 -05:00
Yehuda Katz + Carl Lerche
f2f58f5355 Fix failing ActionCacheFilter tests due to around filter changes. 2009-05-27 17:31:48 -07:00
Yehuda Katz + Carl Lerche
e70bd6bdfa Added hook point in new base #send_action which does the actual action method dispatching 2009-05-27 16:16:33 -07:00
Carl Lerche
a5688fa907 Add the ability to prepend filters to new callbacks 2009-05-27 16:15:53 -07:00
Hongli Lai (Phusion)
760cb63339 Make the default 500 Internal Server Error page more friendly. Many people don't know they're supposed to look in the log files. [#2716 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-27 15:01:03 -05:00
Eduard Bondarenko
61c471eebb Add % to RESERVED_PCHAR [#2574 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-27 14:53:05 -05:00
Niels Ganser
bb8e5843f3 ActionController::Flash::FlashHash.use now returns either the value corresponding to the passed key or itself when no key is passed [#1792 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-27 14:51:33 -05:00
Yehuda Katz
6bbe965ccd Reduce the cost of using ActionController::Http significantly by: 
* Removing the dependency on AD::Request and AD::Response
  * Moving the logic for the request and response object
    into a new module that is included by default.
  * Changing Renderer and Redirector to use self.headers,
    self.content_type, and self.status, which have very basic
    default implementations on AC::Http. When RackConvenience
    is included (which it is by default on AC::Base), the full
    Request/Response logic is used instead of the simple logic.
 2009-05-27 10:40:43 +02:00
Carl Lerche
7211048b2b Get all template tests passing on new base 2009-05-26 15:19:39 -07:00
Carl Lerche
a1f280e83d Got all the dispatch tests running on new base 2009-05-26 15:03:09 -07:00
Carl Lerche
a3ca5638d3 Get controller/test_test.rb to pass on new base 2009-05-26 14:13:35 -07:00
Carl Lerche
7dd094329e Add html-scanner to the new base set of autoloads 2009-05-26 13:40:58 -07:00
Carl Lerche
09907d1b93 Get controller/view_paths_test.rb to pass on new base 2009-05-26 12:14:50 -07:00
Carl Lerche
cbb0724f0d In new base Rails2Compatibility, move @template assignment to right before the first action is processed. 2009-05-26 12:06:48 -07:00
Pratik Naik
10085114ce Make Filter#filter work with around filters 2009-05-25 18:09:12 +02:00
Jeremy Kemper
8097da93cc Don't want Rack's Content-Type default header though 2009-05-24 19:25:53 -07:00
Jeremy Kemper
b1d4fb71bf Construct a single HeaderHash. Speed up assign_default_content_type_and_charset 2009-05-24 17:35:49 -07:00
Jeremy Kemper
6e039e863a Speed up Request#formats 2009-05-23 19:30:23 -07:00
Yehuda Katz
e0ed4b7aa4 Make a couple more tests pass. 
A large number of the remaining failing tests have to do with
  the semantics of filters that are Objects. The right solution
  is probably to just implement the filter/before/after semantics
  in NewCallbacks directly (the current semantics are based
  on the old AS::Callbacks specs)
 2009-05-23 01:30:25 -07:00
Yehuda Katz
e22a3d893e Slightly modify things to get content type matching working without breaking other code 2009-05-23 00:39:32 -07:00
Pratik Naik
3ac6d8f8b0 Remove unnecessary asset_host initialization 2009-05-23 02:35:34 +02:00
Pratik Naik
9286d422f8 Add asset_host to Rails2Compatibility 2009-05-23 02:29:55 +02:00
Yehuda Katz + Carl Lerche
69a1ea8b5d Created an ActionController::Renderers::All that includes all the default render options (:json, :js, :rjs, :xml) 2009-05-22 17:17:16 -07:00
Yehuda Katz + Carl Lerche
7b3fb1d43f Got controller/render_js_test.rb to pass on new base 2009-05-22 17:08:58 -07:00
Jeremy Kemper
f9dde8fe4e Port cookies to new base 2009-05-22 17:05:44 -07:00
Pratik Naik
c90f613ad6 Add Translation to the new base 2009-05-23 02:03:22 +02:00
Yehuda Katz + Carl Lerche
28dbeb3a64 Get controller/render_other_test.rb to pass on new base and fixed a bug in new base with regards to rendering layouts. 2009-05-22 16:55:27 -07:00
Pratik Naik
f766f66946 Make logging_test pass with the new base 2009-05-23 01:36:09 +02:00
Pratik Naik
8a336d01d2 Use super wherever possible in ActionController::Helpers#helper 2009-05-23 00:30:32 +02:00
Yehuda Katz + Carl Lerche
72a574b507 Get controller/layout_test.rb running on new base except for ActionController::Base.exempt_from_layout which is going to be deprecated. 2009-05-22 15:25:13 -07:00
Yehuda Katz + Carl Lerche
01129534cd Cleaned up the #render_to_body chain by extracting determining the templates to render to a separate hook point. 2009-05-22 15:24:31 -07:00
Pratik Naik
e976c489e6 Add all the existing helpers related features to the new base 2009-05-23 00:17:10 +02:00
Pratik Naik
1d168afcb1 Move FilterParameterLogging to a stand alone module and make it work on new base 2009-05-22 19:51:17 +02:00
Pratik Naik
9d08f86cd4 Make assertion tests pass with the new base 2009-05-22 19:01:52 +02:00
Jeremy Kemper
1fa7e3322d Ruby 1.9 compat: don't rely on lexical scoping since the included block is called from dependency_module 2009-05-21 20:54:28 -07:00
Jeremy Kemper
4c52ba278b Move Safari response-padding fix to Rails2Compatibility. Should be a Rack concern. 2009-05-21 20:27:24 -07:00
Jeremy Kemper
8f3cbb4773 Dead local 2009-05-21 20:27:24 -07:00
Yehuda Katz + Carl Lerche
68a207ccf6 Implemented layout conditions in new base 2009-05-21 18:14:20 -07:00
Yehuda Katz + Carl Lerche
6923b392b7 Added the :rjs render option 2009-05-21 16:35:40 -07:00
Yehuda Katz + Carl Lerche
e773d0e68a Renamed #implicit_render to #default_render in new base to support the default_render API 2009-05-21 16:31:05 -07:00
Pratik Naik
1a52b246eb Add HTTP Authentication to the new base 2009-05-22 00:29:47 +02:00
Pratik Naik
d2cac9dd0e Add missing dependency in Streaming 2009-05-22 00:27:08 +02:00
Yehuda Katz + Carl Lerche
9d3d774670 Update render options to remove performance implications of many render options types 2009-05-21 15:23:52 -07:00
Yehuda Katz + Carl Lerche
ad1c90de3a Added the :xml render option 2009-05-21 14:51:29 -07:00
Yehuda Katz + Carl Lerche
2daac47d58 Added the ability to register methods to handle specific render option keys and render :json 2009-05-21 14:36:00 -07:00
Yehuda Katz + Carl Lerche
e693f45e15 Remove some response content type concepts from ActionView 2009-05-21 14:34:56 -07:00