Johan Sörensen
72cb6f58be
The FlashHash and friends causes a lot of needless session storing, when we know for a fact that there's no content in the flash. By not storing the empty hash in the session we save a lot of communication with the various session backends, while still keeping the same interface to the flash. [ #2703 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-28 09:30:49 -05:00
Olly Legg
0349278f3d
Memoize cookies so that updates to cookies are available in the current request. [ #2733 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-28 09:18:27 -05:00
Yehuda Katz + Carl Lerche
bd7e3dc47d
Added a compatibility layer to get legacy filter tests to pass on new base
2009-05-27 16:49:04 -07:00
Eduard Bondarenko
61c471eebb
Add % to RESERVED_PCHAR [ #2574 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-27 14:53:05 -05:00
Niels Ganser
bb8e5843f3
ActionController::Flash::FlashHash.use now returns either the value corresponding to the passed key or itself when no key is passed [ #1792 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-27 14:51:33 -05:00
Carl Lerche
cd8fb1800d
Remove a no-op from view path tests and removed a Symbol#to_proc
2009-05-26 11:47:42 -07:00
Pratik Naik
10085114ce
Make Filter#filter work with around filters
2009-05-25 18:09:12 +02:00
Jeremy Kemper
4e3fd23e31
test depends on html-scanner
2009-05-23 03:10:48 -07:00
Yehuda Katz + Carl Lerche
5097bd6241
Modify render_test's determine_layout to match RJS
2009-05-22 17:26:27 -07:00
Pratik Naik
595107f22e
Move html-scanner tests one dir up
2009-05-23 02:21:07 +02:00
Jeremy Kemper
8a03a999ef
Cordon off missing filter methods
2009-05-22 17:16:03 -07:00
Yehuda Katz + Carl Lerche
7b3fb1d43f
Got controller/render_js_test.rb to pass on new base
2009-05-22 17:08:58 -07:00
Jeremy Kemper
f9dde8fe4e
Port cookies to new base
2009-05-22 17:05:44 -07:00
Yehuda Katz + Carl Lerche
28dbeb3a64
Get controller/render_other_test.rb to pass on new base and fixed a bug in new base with regards to rendering layouts.
2009-05-22 16:55:27 -07:00
Pratik Naik
b77602824a
Add some more tests to the test_new_base_on_old_tests task
2009-05-23 01:46:37 +02:00
Pratik Naik
f766f66946
Make logging_test pass with the new base
2009-05-23 01:36:09 +02:00
Jeremy Kemper
a01d2a2586
Remove gratuitous filter_chain internal testing. Not part of the API and other tests are sufficient to catch regressions.
2009-05-22 16:25:49 -07:00
Jeremy Kemper
ca72078388
Move fake controllers and models to a common load path
2009-05-22 16:11:54 -07:00
Yehuda Katz + Carl Lerche
72a574b507
Get controller/layout_test.rb running on new base except for ActionController::Base.exempt_from_layout which is going to be deprecated.
2009-05-22 15:25:13 -07:00
Pratik Naik
e976c489e6
Add all the existing helpers related features to the new base
2009-05-23 00:17:10 +02:00
Pratik Naik
1d168afcb1
Move FilterParameterLogging to a stand alone module and make it work on new base
2009-05-22 19:51:17 +02:00
Pratik Naik
9d08f86cd4
Make assertion tests pass with the new base
2009-05-22 19:01:52 +02:00
Jeremy Kemper
4c52ba278b
Move Safari response-padding fix to Rails2Compatibility. Should be a Rack concern.
2009-05-21 20:27:24 -07:00
Yehuda Katz + Carl Lerche
68a207ccf6
Implemented layout conditions in new base
2009-05-21 18:14:20 -07:00
Yehuda Katz + Carl Lerche
6923b392b7
Added the :rjs render option
2009-05-21 16:35:40 -07:00
Pratik Naik
1a52b246eb
Add HTTP Authentication to the new base
2009-05-22 00:29:47 +02:00
Yehuda Katz + Carl Lerche
e693f45e15
Remove some response content type concepts from ActionView
2009-05-21 14:34:56 -07:00
Pratik Naik
386ff66e5e
Add Streaming to new base
2009-05-21 21:48:42 +02:00
Pratik Naik
e21d1614bb
Made ActionController::Verification work with new_base
2009-05-21 02:55:25 +02:00
Yehuda Katz + Carl Lerche
c4a6109286
Got controller/mime_responds_test.rb running on the new base
2009-05-20 16:54:21 -07:00
Pratik Naik
8e7a87d299
Make ActionController::Flash work with new_base
2009-05-21 01:41:35 +02:00
Yehuda Katz + Carl Lerche
01f032f256
Added responds_to to new base.
2009-05-20 15:34:26 -07:00
Bryan Helmkamp
0029d5e594
Integrating Rack::MockSession (from Rack::Test)
2009-05-19 22:43:21 -05:00
Pratik Naik
4a6f4b92ad
Change integration test helpers to accept Rack environment instead of just HTTP Headers.
...
Before : get '/path', {}, 'Accept' => 'text/javascript'
After : get '/path', {}, 'HTTP_ACCEPT' => 'text/javascript'
2009-05-19 23:50:03 +02:00
Yehuda Katz + Carl Lerche
07f733c631
Ported simple benchmarking in new base
2009-05-18 17:33:45 -07:00
Pratik Naik
195fadbfd3
Ensure HTTP Digest auth uses appropriate HTTP method [ #2490 state:resolved] [Steve Madsen]
2009-05-18 16:59:37 +02:00
Joshua Peek
092089015b
Extract generic callbacks middleware from dispatcher
2009-05-17 13:39:55 -05:00
Mike Breen
edc9c226d1
Add tests for assert_template :template
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 19:50:00 +02:00
Joshua Peek
8118fca9be
Merge Failsafe middleware into ShowExceptions
2009-05-17 12:24:59 -05:00
Joshua Peek
c3319504f0
Rescue hack was supposed to be removed. Some how it crept back in.
2009-05-17 12:24:59 -05:00
Yehuda Katz + Carl Lerche
da65320433
Got new base to pass controller/base_test.rb, implemented method_missing action semantics in compatibility mode, and fixed a few action_missing bugs.
2009-05-14 17:25:10 -07:00
Yehuda Katz + Carl Lerche
8fac2c88ca
Cleaning up more render tests
2009-05-14 15:30:35 -07:00
Yehuda Katz + Carl Lerche
49a84ff69c
Ported over render :file tests.
2009-05-13 17:00:59 -07:00
Jeremy Kemper
e8550ee032
Cherry-pick core extensions
2009-05-13 12:00:15 -07:00
Yehuda Katz + Carl Lerche
216309c165
Implemented redirects and partial rendering in new base.
2009-05-12 16:21:34 -07:00
Yehuda Katz + Carl Lerche
00a9d4b91c
Merge branch 'master' into wip_abstract_controller
...
Conflicts:
actionpack/lib/action_controller/abstract/callbacks.rb
actionpack/lib/action_controller/abstract/renderer.rb
actionpack/lib/action_controller/base/base.rb
actionpack/lib/action_controller/dispatch/dispatcher.rb
actionpack/lib/action_controller/routing/route_set.rb
actionpack/lib/action_controller/testing/process.rb
actionpack/test/abstract_controller/layouts_test.rb
actionpack/test/controller/filters_test.rb
actionpack/test/controller/helper_test.rb
actionpack/test/controller/render_test.rb
actionpack/test/new_base/test_helper.rb
2009-05-11 17:07:05 -07:00
Yehuda Katz + Carl Lerche
6694bd46f5
Aliased AbstractController::ActionNotFound to ActionController::UnknownAction
2009-05-11 12:45:26 -07:00
Yehuda Katz + Carl Lerche
94ee9d2452
Ported ConditionalGet to new Base
2009-05-11 12:04:43 -07:00
Joshua Peek
d4402c5554
assert_redirect_to's partial hash matching was deprecated in 2-3 stable 7f1f16c01
2009-05-04 20:26:43 -05:00
Joshua Peek
11af089cee
Extract ActionController rescue templates into Rescue and ShowExceptions middleware.
...
This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public.
2009-05-02 23:02:22 -05:00
